From e61315d8c935be26b72280dd30123d68118e1d9d Mon Sep 17 00:00:00 2001 From: Sam <94756474+SUI298@users.noreply.github.com> Date: Mon, 13 Mar 2023 12:06:38 +0100 Subject: [PATCH 01/32] Update api.md --- docs/api.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/api.md b/docs/api.md index 636fe52c..f93d0430 100644 --- a/docs/api.md +++ b/docs/api.md @@ -2672,7 +2672,8 @@ Create a new Bluetooth® Low Energy characteristic. #### Syntax ``` -BLECharacteristic(uuid, properties, value, valueSize) +BLECharacteristic(uuid, properties, valueSize) +BLECharacteristic(uuid, properties, valueSize, fixedLength) BLECharacteristic(uuid, properties, stringValue) BLEBoolCharacteristic(uuid, properties) @@ -2696,6 +2697,7 @@ BLEDoubleCharacteristic(uuid, properties) - **uuid**: 16-bit or 128-bit UUID in **String** format - **properties**: mask of the properties (BLEBroadcast, BLERead, BLEWriteWithoutResponse, BLEWrite, BLENotify, BLEIndicate) - **valueSize**: (maximum) size of characteristic value +- **fixedLength**: if true, size of characteristic value is fixed - **stringValue**: value as a string #### Returns From 910dd44389ea5b00a1e09cbdf4ae7a041e6ee2b5 Mon Sep 17 00:00:00 2001 From: fabik111 Date: Wed, 4 Sep 2024 16:18:56 +0200 Subject: [PATCH 02/32] clear advertising data when BLE end is called --- src/local/BLELocalDevice.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/local/BLELocalDevice.cpp b/src/local/BLELocalDevice.cpp index 1d1036be..5792353f 100644 --- a/src/local/BLELocalDevice.cpp +++ b/src/local/BLELocalDevice.cpp @@ -224,7 +224,9 @@ void BLELocalDevice::end() digitalWrite(NINA_RESETN, LOW); #elif defined(ARDUINO_PORTENTA_H7_M4) || defined(ARDUINO_PORTENTA_H7_M7) || defined(ARDUINO_NICLA_VISION) || defined(ARDUINO_GIGA) || defined(ARDUINO_OPTA) digitalWrite(BT_REG_ON, LOW); -#endif +#endif + _advertisingData.clear(); + _scanResponseData.clear(); } void BLELocalDevice::poll() From 5a531356080351ac03ea0258d82d3842f23db5d8 Mon Sep 17 00:00:00 2001 From: per1234 Date: Tue, 4 Feb 2025 18:16:56 -0800 Subject: [PATCH 03/32] Modernize spell checking infrastructure The repository contains a CI workflow to check for commonly misspelled words in the project files. This is done using the "codespell" tool. A GitHub Actions action handles the installation and execution of the tool. At the time Arduino started setting up such infrastructure in project repositories, no such action was available and so Arduino created an action. Since that time, the codespell developers created an equivalent action and so Arduino's action was abandoned. Most of the libraries were migrated to the new action, but somehow this repository is still using the abandoned action. Due to bit rot, Arduino's action now fails to initialize: ``` #8 [3/4] RUN pip3 install codespell #8 0.401 error: externally-managed-environment [...] ERROR: failed to solve: process "/bin/sh -c pip3 install codespell" did not complete successfully: exit code: 1 Error: Docker build failed with exit code 1 ``` The problem is solved by migrating the spell check workflow to using the codespell action. --- .codespellrc | 9 +++++++++ .github/workflows/spell-check.yml | 21 +++++++++++++++------ 2 files changed, 24 insertions(+), 6 deletions(-) create mode 100644 .codespellrc diff --git a/.codespellrc b/.codespellrc new file mode 100644 index 00000000..cffc2173 --- /dev/null +++ b/.codespellrc @@ -0,0 +1,9 @@ +# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/spell-check/.codespellrc +# See: https://github.com/codespell-project/codespell#using-a-config-file +[codespell] +# In the event of a false positive, add the problematic word, in all lowercase, to a comma-separated list here: +ignore-words-list = , +skip = ./.git,./.licenses,__pycache__,node_modules,./go.mod,./go.sum,./package-lock.json,./poetry.lock,./yarn.lock,./extras/test +builtin = clear,informal,en-GB_to_en-US +check-filenames = +check-hidden = diff --git a/.github/workflows/spell-check.yml b/.github/workflows/spell-check.yml index 94b57020..6faf09c8 100644 --- a/.github/workflows/spell-check.yml +++ b/.github/workflows/spell-check.yml @@ -1,16 +1,25 @@ +# Source: https://github.com/per1234/.github/blob/main/workflow-templates/spell-check.md name: Spell Check -on: [push, pull_request] +# See: https://docs.github.com/en/actions/reference/events-that-trigger-workflows +on: + push: + pull_request: + schedule: + # Run every Tuesday at 8 AM UTC to catch new misspelling detections resulting from dictionary updates. + - cron: "0 8 * * TUE" + workflow_dispatch: + repository_dispatch: jobs: - build: + spellcheck: runs-on: ubuntu-latest + permissions: + contents: read steps: - - name: Checkout + - name: Checkout repository uses: actions/checkout@v4 - name: Spell check - uses: arduino/actions/libraries/spell-check@master - with: - skip-paths: ./extras/test \ No newline at end of file + uses: codespell-project/actions-codespell@v2 From 0178fdfc2cdb101a08d30a6481c621e78f5bc5ee Mon Sep 17 00:00:00 2001 From: per1234 Date: Tue, 4 Feb 2025 19:03:19 -0800 Subject: [PATCH 04/32] Fix typos The "codespell" spellchecker tool is used to automatically detect commonly misspelled words in the files of this project. The misspelled words dictionary was expanded in recent releases of codespell, which resulted in the detection of misspelled words in the project files: > Error: ./src/utility/HCI.cpp:761: Signalling ==> Signaling > Error: ./docs/readme.md:22: acknowledgement ==> acknowledgment The typos are hereby corrected, which will restore the spell check to a passing state. --- I supplemented the correction of the automatically detected typos with a general review of the project content, fixing the additional typos I identified during that review. --- CHANGELOG | 2 +- README.md | 4 +- docs/api.md | 143 +++++++----------- docs/readme.md | 8 +- .../SensorTagButton/SensorTagButton.ino | 2 +- .../RawDataAdvertising/RawDataAdvertising.ino | 6 +- .../BatteryMonitor/BatteryMonitor.ino | 4 +- .../Peripheral/CallbackLED/CallbackLED.ino | 2 +- .../EncryptedBatteryMonitor.ino | 22 +-- examples/Peripheral/LED/LED.ino | 2 +- library.properties | 2 +- src/utility/HCI.cpp | 51 +++---- 12 files changed, 103 insertions(+), 145 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index a29f8598..d8a84716 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -2,7 +2,7 @@ ArduinoBLE ?.?.? - ????.??.?? ArduinoBLE 1.1.2 - 2019.11.12 -* cordio: switch to lower power when polling with timeout +* cordio: switch to lower power when polling with timeout * Fixed issue with wrong types for disconnection event handling. Thanks @cparata ArduinoBLE 1.1.1 - 2019.09.05 diff --git a/README.md b/README.md index 6808502c..b0027583 100644 --- a/README.md +++ b/README.md @@ -2,11 +2,11 @@ [![Compile Examples Status](https://github.com/arduino-libraries/ArduinoBLE/workflows/Compile%20Examples/badge.svg)](https://github.com/arduino-libraries/ArduinoBLE/actions?workflow=Compile+Examples) [![Spell Check Status](https://github.com/arduino-libraries/ArduinoBLE/workflows/Spell%20Check/badge.svg)](https://github.com/arduino-libraries/ArduinoBLE/actions?workflow=Spell+Check) -Enables Bluetooth® Low Energy connectivity on the Arduino MKR WiFi 1010, Arduino UNO WiFi Rev.2, Arduino Nano 33 IoT, Arduino Nano 33 BLE, Arduino Portenta H7, Arduino Giga R1 and Arduino UNO R4 WiFi. +Enables Bluetooth® Low Energy connectivity on the Arduino MKR WiFi 1010, Arduino UNO WiFi Rev2, Arduino Nano 33 IoT, Arduino Nano 33 BLE, Arduino Portenta H7, Arduino Giga R1 and Arduino UNO R4 WiFi. This library supports creating a Bluetooth® Low Energy peripheral & central mode. -For the Arduino MKR WiFi 1010, Arduino UNO WiFi Rev.2, and Arduino Nano 33 IoT boards, it requires the NINA module to be running [Arduino NINA-W102 firmware](https://github.com/arduino/nina-fw) v1.2.0 or later. +For the Arduino MKR WiFi 1010, Arduino UNO WiFi Rev2, and Arduino Nano 33 IoT boards, it requires the NINA module to be running [Arduino NINA-W102 firmware](https://github.com/arduino/nina-fw) v1.2.0 or later. For the Arduino UNO R4 WiFi, it requires the ESP32-S3 module to be running [firmware](https://github.com/arduino/uno-r4-wifi-usb-bridge) v0.2.0 or later. diff --git a/docs/api.md b/docs/api.md index 636fe52c..c9f41840 100644 --- a/docs/api.md +++ b/docs/api.md @@ -80,7 +80,7 @@ Poll for Bluetooth® Low Energy radio events and handle them. #### Syntax ``` -BLE.poll() +BLE.poll() BLE.poll(timeout) ``` @@ -100,7 +100,6 @@ Nothing BLE.setEventHandler(BLEConnected, blePeripheralConnectHandler); BLE.setEventHandler(BLEDisconnected, blePeripheralDisconnectHandler); - BLE.poll(); @@ -142,7 +141,6 @@ Nothing. BLE.setEventHandler(BLEConnected, blePeripheralConnectHandler); BLE.setEventHandler(BLEDisconnected, blePeripheralDisconnectHandler); - void blePeripheralConnectHandler(BLEDevice central) { @@ -176,7 +174,7 @@ BLE.connected() None #### Returns -- **true** if another Bluetooth® Low Energy device is connected, +- **true** if another Bluetooth® Low Energy device is connected, - otherwise **false**. #### Example @@ -208,7 +206,7 @@ BLE.disconnect() None #### Returns -- **true** if any Bluetooth® Low Energy device that was previously connected was disconnected, +- **true** if any Bluetooth® Low Energy device that was previously connected was disconnected, - otherwise **false**. #### Example @@ -216,8 +214,6 @@ None ```arduino if (BLE.connected()) { - - BLE.disconnect(); } @@ -246,9 +242,9 @@ None ```arduino - **String** address = BLE.address(); + String address = BLE.address(); - Serial.print(“Local address is: “); + Serial.print("Local address is: "); Serial.println(address); @@ -277,9 +273,7 @@ None ```arduino if (BLE.connected()) { - - - Serial.print(“RSSI = “); + Serial.print("RSSI = "); Serial.println(BLE.rssi()); } @@ -315,9 +309,9 @@ Nothing while (1); } - BLE.setAdvertisedServiceUuid(“19B10000-E8F2-537E-4F6C-D104768A1214"); + BLE.setAdvertisedServiceUuid("19B10000-E8F2-537E-4F6C-D104768A1214"); - // ... + // ... // start advertising BLE.advertise(); @@ -360,7 +354,7 @@ BLEService ledService("19B10000-E8F2-537E-4F6C-D104768A1214"); // Bluetooth® Lo BLE.setAdvertisedService(ledService); - // ... + // ... // start advertising BLE.advertise(); @@ -402,7 +396,7 @@ Nothing BLE.setManufacturerData(data, 5); - // ... + // ... // start advertising BLE.advertise(); @@ -442,7 +436,7 @@ Nothing BLE.setLocalName("LED"); - // ... + // ... // start advertising BLE.advertise(); @@ -453,7 +447,7 @@ Nothing ### `BLE.setDeviceName()` -Set the device name in the built in device name characteristic. If not set, the value defaults “Arduino”. +Set the device name in the built in device name characteristic. If not set, the value defaults to “Arduino”. #### Syntax @@ -482,7 +476,7 @@ Nothing BLE.setDeviceName("LED"); - // ... + // ... // start advertising BLE.advertise(); @@ -493,7 +487,7 @@ Nothing ### `BLE.setAppearance()` -Set the appearance in the built in appearance characteristic. If not set, the value defaults 0x0000. +Set the appearance in the built in appearance characteristic. If not set, the value defaults to 0x0000. #### Syntax @@ -522,7 +516,7 @@ Nothing BLE.setAppearance(0x8000); - // ... + // ... // start advertising BLE.advertise(); @@ -568,7 +562,7 @@ BLEService ledService("19B10000-E8F2-537E-4F6C-D104768A1214"); // Bluetooth® Lo BLE.addService(ledService); - // ... + // ... ``` @@ -607,7 +601,7 @@ None BLE.advertise(); - // ... + // ... ``` @@ -645,7 +639,7 @@ Nothing BLE.advertise(); - // ... + // ... BLE.stopAdvertise(); @@ -682,8 +676,6 @@ None Serial.print("Connected to central: "); // print the central's MAC address: Serial.println(central.address()); - - } @@ -820,7 +812,7 @@ BLE.scan(withDuplicates) - **withDuplicates:** optional, defaults to **false**. If **true**, advertisements received more than once will not be filtered #### Returns -- 1 on success, +- 1 on success, - 0 on failure. #### Example @@ -839,7 +831,6 @@ BLE.scan(withDuplicates) // start scanning for peripheral BLE.scan(); - BLEDevice peripheral = BLE.available(); @@ -887,7 +878,6 @@ BLE.scanForName(name, withDuplicates) // start scanning for peripheral BLE.scanForName("LED"); - BLEDevice peripheral = BLE.available(); @@ -916,7 +906,7 @@ BLE.scanForAddress(address, withDuplicates) - **withDuplicates:** optional, defaults to **false**. If **true**, advertisements received more than once will not be filtered #### Returns -- 1 on success, +- 1 on success, - 0 on failure. #### Example @@ -935,7 +925,6 @@ BLE.scanForAddress(address, withDuplicates) // start scanning for peripheral BLE.scanForAddress("aa:bb:cc:ee:dd:ff"); - BLEDevice peripheral = BLE.available(); @@ -983,7 +972,6 @@ BLE.scanForUuid(uuid, withDuplicates) // start scanning for peripheral BLE.scanForUuid("aa10"); - BLEDevice peripheral = BLE.available(); @@ -1028,7 +1016,6 @@ Nothing // start scanning for peripheral BLE.scan(); - BLE.stopScan(); @@ -1068,7 +1055,6 @@ Nothing // start scanning for peripheral BLE.scan(); - BLEDevice peripheral = BLE.available(); @@ -1111,8 +1097,6 @@ Nothing // if a central is connected to peripheral: if (central) { - - central.poll(); // ... @@ -1182,7 +1166,6 @@ None // listen for Bluetooth® Low Energy centrals to connect: BLEDevice central = BLE.central(); - central.disconnect(); @@ -1219,8 +1202,6 @@ None Serial.print("Connected to central: "); // print the central's MAC address: Serial.println(central.address()); - - . } @@ -1249,9 +1230,7 @@ None ```arduino if (bleDevice.connected()) { - - - Serial.print(“RSSI = “); + Serial.print("RSSI = "); Serial.println(bleDevice.rssi()); } @@ -1295,7 +1274,6 @@ bleDevice.characteristic(uuid, index) // start scanning for peripheral BLE.scan(); - BLEDevice peripheral = BLE.available(); @@ -1321,9 +1299,9 @@ bleDevice.characteristic(uuid, index) return; } - BLECharacteristic batteryLevelCharacterisic = peripheral.characteristic("2a19"); + BLECharacteristic batteryLevelCharacteristic = peripheral.characteristic("2a19"); - if (batteryLevelCharacterisic) { + if (batteryLevelCharacteristic) { // use the characteristic } else { Serial.println("Peripheral does NOT have battery level characteristic"); @@ -1351,7 +1329,7 @@ bleDevice.discoverAttributes() None #### Returns -- **true**, if successful, +- **true**, if successful, - **false** on failure. #### Example @@ -1370,7 +1348,6 @@ None // start scanning for peripheral BLE.scan(); - BLEDevice peripheral = BLE.available(); @@ -1437,7 +1414,6 @@ bleDevice.discoverService(serviceUuid) // start scanning for peripheral BLE.scan(); - BLEDevice peripheral = BLE.available(); @@ -1503,7 +1479,6 @@ None // start scanning for peripheral BLE.scan(); - BLEDevice peripheral = BLE.available(); @@ -1577,7 +1552,6 @@ None // start scanning for peripheral BLE.scan(); - BLEDevice peripheral = BLE.available(); @@ -1651,7 +1625,6 @@ None // start scanning for peripheral BLE.scan(); - BLEDevice peripheral = BLE.available(); @@ -1725,7 +1698,6 @@ bleDevice.hasService(uuid, index) // start scanning for peripheral BLE.scan(); - BLEDevice peripheral = BLE.available(); @@ -1798,7 +1770,6 @@ bleDevice.service(uuid, index) // start scanning for peripheral BLE.scan(); - BLEDevice peripheral = BLE.available(); @@ -1872,7 +1843,6 @@ None // start scanning for peripheral BLE.scan(); - BLEDevice peripheral = BLE.available(); @@ -1901,7 +1871,7 @@ None int characteristicCount = peripheral.characteristicCount(); Serial.print(characteristicCount); - Serial.println(" characteristis discovered"); + Serial.println(" characteristics discovered"); // ... } @@ -1927,7 +1897,7 @@ bleDevice.hasCharacteristic(uuid, index) - **index**: optional, index of characteristic to check if the device provides more than on. Defaults to 0, if not provided. #### Returns -- **true**, if the device provides the characteristic, +- **true**, if the device provides the characteristic, - **false** otherwise. #### Example @@ -1946,7 +1916,6 @@ bleDevice.hasCharacteristic(uuid, index) // start scanning for peripheral BLE.scan(); - BLEDevice peripheral = BLE.available(); @@ -1998,7 +1967,7 @@ bleDevice.hasLocalName() Nothing #### Returns -- **true**, if the device is advertising a local name, +- **true**, if the device is advertising a local name, - **false** otherwise. #### Example @@ -2017,7 +1986,6 @@ Nothing // start scanning for peripheral BLE.scan(); - BLEDevice peripheral = BLE.available(); @@ -2053,7 +2021,7 @@ bleDevice.hasAdvertisedServiceUuid(index) - **index**: optional, defaults to 0, the index of the service UUID, if the device is advertising more than one. #### Returns -- **true**, if the device is advertising a service UUID, +- **true**, if the device is advertising a service UUID, - **false** otherwise. #### Example @@ -2072,7 +2040,6 @@ bleDevice.hasAdvertisedServiceUuid(index) // start scanning for peripheral BLE.scan(); - BLEDevice peripheral = BLE.available(); @@ -2129,7 +2096,6 @@ None // start scanning for peripheral BLE.scan(); - BLEDevice peripheral = BLE.available(); @@ -2186,7 +2152,6 @@ Nothing // start scanning for peripheral BLE.scan(); - BLEDevice peripheral = BLE.available(); @@ -2240,7 +2205,6 @@ bleDevice.advertisedServiceUuid(index) // start scanning for peripheral BLE.scan(); - BLEDevice peripheral = BLE.available(); @@ -2279,7 +2243,7 @@ bleDevice.connect() None #### Returns -- **true**, if the connection was successful, +- **true**, if the connection was successful, - **false** otherwise. #### Example @@ -2298,7 +2262,6 @@ None // start scanning for peripheral BLE.scan(); - BLEDevice peripheral = BLE.available(); @@ -2376,7 +2339,7 @@ None BLEService ledService("19B10000-E8F2-537E-4F6C-D104768A1214"); // Bluetooth® Low Energy LED Service -Serial.print(“LED service UUID = “); +Serial.print("LED service UUID = "); Serial.println(ledService.uuid()); @@ -2385,7 +2348,7 @@ Serial.println(ledService.uuid()); ### `bleService.addCharacteristic()` -Add a BLECharateristic to the Bluetooth® Low Energy service. +Add a BLECharacteristic to the Bluetooth® Low Energy service. #### Syntax @@ -2454,7 +2417,6 @@ None // start scanning for peripheral BLE.scan(); - BLEDevice peripheral = BLE.available(); @@ -2535,7 +2497,6 @@ bleService.hasCharacteristic(uuid, index) // start scanning for peripheral BLE.scan(); - BLEDevice peripheral = BLE.available(); if (peripheral) { @@ -2614,7 +2575,6 @@ bleService.characteristic(uuid, index) // start scanning for peripheral BLE.scan(); - BLEDevice peripheral = BLE.available(); @@ -2644,9 +2604,9 @@ bleService.characteristic(uuid, index) if (batteryService) { // use the service - BLECharacteristic batteryLevelCharacterisic = peripheral.characteristic("2a19"); + BLECharacteristic batteryLevelCharacteristic = peripheral.characteristic("2a19"); - if (batteryLevelCharacterisic) { + if (batteryLevelCharacteristic) { // use the characteristic } else { Serial.println("Peripheral does NOT have battery level characteristic"); @@ -2739,7 +2699,7 @@ None BLEByteCharacteristic switchCharacteristic("19B10001-E8F2-537E-4F6C-D104768A1214", BLERead | BLEWrite); -Serial.print(“Switch characteristic UUID = “); +Serial.print("Switch characteristic UUID = "); Serial.println(switchCharacteristic.uuid()); @@ -2812,7 +2772,7 @@ BLEByteCharacteristic switchCharacteristic("19B10001-E8F2-537E-4F6C-D104768A1214 -Serial.print(“value size = “); +Serial.print("value size = "); Serial.println(switchCharacteristic.valueSize()); @@ -2845,13 +2805,13 @@ BLEByteCharacteristic switchCharacteristic("19B10001-E8F2-537E-4F6C-D104768A1214 - if (switchCharacteristic.value()) { // any value other than 0 - Serial.println("LED on"); - digitalWrite(ledPin, HIGH); // will turn the LED on - } else { // a 0 value - Serial.println(F("LED off")); - digitalWrite(ledPin, LOW); // will turn the LED off - } + if (switchCharacteristic.value()) { // any value other than 0 + Serial.println("LED on"); + digitalWrite(ledPin, HIGH); // will turn the LED on + } else { // a 0 value + Serial.println(F("LED off")); + digitalWrite(ledPin, LOW); // will turn the LED off + } @@ -2884,7 +2844,7 @@ BLEByteCharacteristic switchCharacteristic("19B10001-E8F2-537E-4F6C-D104768A1214 -Serial.print(“value length = “); +Serial.print("value length = "); Serial.println(switchCharacteristic.valueLength()); @@ -2904,7 +2864,7 @@ bleCharacteristic.readValue(value) #### Parameters -- **buffer:** byte array to read value into length: size of buffer argument in bytes +- **buffer:** byte array to read value into length: size of buffer argument in bytes - **value**: variable to read value into (by reference) #### Returns @@ -2958,7 +2918,7 @@ bleCharacteristic.writeValue(value) - **value**: value to write #### Returns -- 1 on success, +- 1 on success, - 0 on failure #### Example @@ -3001,7 +2961,7 @@ bleCharacteristic.setEventHandler(eventType, callback) #### Parameters -- **eventType**: event type (BLESubscribed, BLEUnsubscribed, BLERead, BLEWritten) +- **eventType**: event type (BLESubscribed, BLEUnsubscribed, BLERead, BLEWritten) - **callback**: function to call when the event occurs #### Returns @@ -3035,7 +2995,6 @@ void switchCharacteristicWritten(BLEDevice central, BLECharacteristic characteri } } - ``` @@ -3324,7 +3283,7 @@ bleCharacteristic.canRead() None #### Returns -- **true**, if characteristic is readable, +- **true**, if characteristic is readable, - **false** otherwise #### Example @@ -3354,7 +3313,7 @@ bleCharacteristic.read() None #### Returns -- **true**, if successful, +- **true**, if successful, - **false** on failure #### Example @@ -3669,7 +3628,7 @@ None BLEDescriptor millisLabelDescriptor("2901", "millis"); -Serial.print(“millis label descriptor UUID = “); +Serial.print("millis label descriptor UUID = "); Serial.println(millisLabelDescriptor.uuid()); @@ -3701,7 +3660,7 @@ None BLEDescriptor millisLabelDescriptor("2901", "millis"); -Serial.print(“millis label descriptor value size = “); +Serial.print("millis label descriptor value size = "); Serial.println(millisLabelDescriptor.valueSize()); @@ -3819,7 +3778,7 @@ bleDescriptor.readValue(value) byte value = 0; - /get the value, descriptor is 1 byte so use byte value + // get the value, descriptor is 1 byte so use byte value descriptor.readValue(value); diff --git a/docs/readme.md b/docs/readme.md index 5ba0dfb4..b584d71e 100644 --- a/docs/readme.md +++ b/docs/readme.md @@ -1,6 +1,6 @@ # ArduinoBLE library -This library supports all the Arduino boards that have the hardware enabled for Bluetooth® Low Energy and Bluetooth® 4.0 and above; these include Nano 33 BLE, Arduino NANO 33 IoT, Uno WiFi Rev 2, MKR WiFi 1010, Nicla Sense ME. +This library supports all the Arduino boards that have the hardware enabled for Bluetooth® Low Energy and Bluetooth® 4.0 and above; these include Nano 33 BLE, Arduino NANO 33 IoT, Uno WiFi Rev2, MKR WiFi 1010, Nicla Sense ME. To use this library ``#include `` @@ -9,7 +9,7 @@ To use this library Bluetooth® 4.0 includes both traditional Bluetooth®, now labeled "Bluetooth® Classic", and the Bluetooth® Low Energy. Bluetooth® Low Energy is optimized for low power use at low data rates, and was designed to operate from simple lithium coin cell batteries. -Unlike standard Bluetooth® communication basically based on an asynchronous serial connection (UART) a Bluetooth® LE radio acts like a community bulletin board. The computers that connect to it are like community members that read the bulletin board. Each radio acts as either the bulletin board or the reader. If your radio is a bulletin board (called a peripheral device in Bluetooth® LE parlance) it posts data for all radios in the community to read. If your radio is a reader (called a central device in Blueooth LE terms) it reads from any of the bulletin boards (peripheral devices) that have information about which it cares. You can also think of peripheral devices as the servers in a client-server transaction, because they contain the information that reader radios ask for. Similarly, central devices are the clients of the Bluetooth® LE world because they read information available from the peripherals. +Unlike standard Bluetooth® communication basically based on an asynchronous serial connection (UART) a Bluetooth® LE radio acts like a community bulletin board. The computers that connect to it are like community members that read the bulletin board. Each radio acts as either the bulletin board or the reader. If your radio is a bulletin board (called a peripheral device in Bluetooth® LE parlance) it posts data for all radios in the community to read. If your radio is a reader (called a central device in Bluetooth LE terms) it reads from any of the bulletin boards (peripheral devices) that have information about which it cares. You can also think of peripheral devices as the servers in a client-server transaction, because they contain the information that reader radios ask for. Similarly, central devices are the clients of the Bluetooth® LE world because they read information available from the peripherals. ![Communication between central and peripheral devices](https://raw.githubusercontent.com/arduino-libraries/ArduinoBLE/master/docs/assets/ble-bulletin-board-model.png) @@ -19,7 +19,7 @@ The information presented by a peripheral is structured as **services**, each of ## Notify -The Bluetooth® LE specification includes a mechanism known as **notify** that lets you know when data's changed. When notify on a characteristic is enabled and the sender writes to it, the new value is automatically sent to the receiver, without the receiver explicitly issuing a read command. This is commonly used for streaming data such as accelerometer or other sensor readings. There's a variation on this specification called **indicate** which works similarly, but in the indicate specification, the reader sends an acknowledgement of the pushed data. +The Bluetooth® LE specification includes a mechanism known as **notify** that lets you know when data's changed. When notify on a characteristic is enabled and the sender writes to it, the new value is automatically sent to the receiver, without the receiver explicitly issuing a read command. This is commonly used for streaming data such as accelerometer or other sensor readings. There's a variation on this specification called **indicate** which works similarly, but in the indicate specification, the reader sends an acknowledgment of the pushed data. The client-server structure of Bluetooth® LE, combined with the notify characteristic, is generally called a **publish-and-subscribe model**. @@ -58,7 +58,7 @@ You could also combine readings into a single characteristic, when a given senso |Motor Speed, Direction|150,1| |Accelerometer X, Y, Z|200,133,150| -This is more efficient, but you need to be careful not to exceed the 512-byte limit. The accelerometer characteristic above, for example, takes 11 bytes as a ASCII-encoded string. +This is more efficient, but you need to be careful not to exceed the 512-byte limit. The accelerometer characteristic above, for example, takes 11 bytes as an ASCII-encoded string. ## Read/write/notify/indicate diff --git a/examples/Central/SensorTagButton/SensorTagButton.ino b/examples/Central/SensorTagButton/SensorTagButton.ino index a56504f6..27c421fe 100644 --- a/examples/Central/SensorTagButton/SensorTagButton.ino +++ b/examples/Central/SensorTagButton/SensorTagButton.ino @@ -114,7 +114,7 @@ void monitorSensorTagButtons(BLEDevice peripheral) { if (simpleKeyCharacteristic.valueUpdated()) { // yes, get the value, characteristic is 1 byte so use byte value byte value = 0; - + simpleKeyCharacteristic.readValue(value); if (value & 0x01) { diff --git a/examples/Peripheral/Advertising/RawDataAdvertising/RawDataAdvertising.ino b/examples/Peripheral/Advertising/RawDataAdvertising/RawDataAdvertising.ino index d025dd62..5e7ba7f3 100644 --- a/examples/Peripheral/Advertising/RawDataAdvertising/RawDataAdvertising.ino +++ b/examples/Peripheral/Advertising/RawDataAdvertising/RawDataAdvertising.ino @@ -4,7 +4,7 @@ BLEService myService("fff0"); BLEIntCharacteristic myCharacteristic("fff1", BLERead | BLEBroadcast); // Advertising parameters should have a global scope. Do NOT define them in 'setup' or in 'loop' -const uint8_t completeRawAdvertisingData[] = {0x02,0x01,0x06,0x09,0xff,0x01,0x01,0x00,0x01,0x02,0x03,0x04,0x05}; +const uint8_t completeRawAdvertisingData[] = {0x02,0x01,0x06,0x09,0xff,0x01,0x01,0x00,0x01,0x02,0x03,0x04,0x05}; void setup() { Serial.begin(9600); @@ -21,7 +21,7 @@ void setup() { // Build advertising data packet BLEAdvertisingData advData; // If a packet has a raw data parameter, then all the other parameters of the packet will be ignored - advData.setRawData(completeRawAdvertisingData, sizeof(completeRawAdvertisingData)); + advData.setRawData(completeRawAdvertisingData, sizeof(completeRawAdvertisingData)); // Copy set parameters in the actual advertising packet BLE.setAdvertisingData(advData); @@ -30,7 +30,7 @@ void setup() { scanData.setLocalName("Test advertising raw data"); // Copy set parameters in the actual scan response packet BLE.setScanResponseData(scanData); - + BLE.advertise(); Serial.println("advertising ..."); diff --git a/examples/Peripheral/BatteryMonitor/BatteryMonitor.ino b/examples/Peripheral/BatteryMonitor/BatteryMonitor.ino index f013c6f5..0d786627 100644 --- a/examples/Peripheral/BatteryMonitor/BatteryMonitor.ino +++ b/examples/Peripheral/BatteryMonitor/BatteryMonitor.ino @@ -73,11 +73,11 @@ void loop() { // turn on the LED to indicate the connection: digitalWrite(LED_BUILTIN, HIGH); - // check the battery level every 200ms + // check the battery level every 200 ms // while the central is connected: while (central.connected()) { long currentMillis = millis(); - // if 200ms have passed, check the battery level: + // if 200 ms have passed, check the battery level: if (currentMillis - previousMillis >= 200) { previousMillis = currentMillis; updateBatteryLevel(); diff --git a/examples/Peripheral/CallbackLED/CallbackLED.ino b/examples/Peripheral/CallbackLED/CallbackLED.ino index 23f67bc3..59bda5ed 100644 --- a/examples/Peripheral/CallbackLED/CallbackLED.ino +++ b/examples/Peripheral/CallbackLED/CallbackLED.ino @@ -28,7 +28,7 @@ const int ledPin = LED_BUILTIN; // pin to use for the LED void setup() { Serial.begin(9600); while (!Serial); - + pinMode(ledPin, OUTPUT); // use the LED pin as an output // begin initialization diff --git a/examples/Peripheral/EncryptedBatteryMonitor/EncryptedBatteryMonitor.ino b/examples/Peripheral/EncryptedBatteryMonitor/EncryptedBatteryMonitor.ino index 9f9d453b..dfc9f4a0 100644 --- a/examples/Peripheral/EncryptedBatteryMonitor/EncryptedBatteryMonitor.ino +++ b/examples/Peripheral/EncryptedBatteryMonitor/EncryptedBatteryMonitor.ino @@ -54,7 +54,7 @@ void setup() { Serial.println("Serial connected"); - + // Callback function with confirmation code when new device is pairing. BLE.setDisplayCode([](uint32_t confirmCode){ Serial.println("New device pairing request."); @@ -63,7 +63,7 @@ void setup() { sprintf(code, "%06d", confirmCode); Serial.println(code); }); - + // Callback to allow accepting or rejecting pairing BLE.setBinaryConfirmPairing([&acceptOrReject](){ Serial.print("Should we confirm pairing? "); @@ -98,7 +98,7 @@ void setup() { (*BDaddrTypes)[0] = 0; // Type 0 is for pubc address, type 1 is for static random - (*BDAddrs)[0] = new uint8_t[6]; + (*BDAddrs)[0] = new uint8_t[6]; (*IRKs)[0] = new uint8_t[16]; memcpy((*IRKs)[0] , device1IRK,16); memcpy((*BDAddrs)[0], device1Mac, 6); @@ -124,7 +124,7 @@ void setup() { uint8_t device1LTK[16] = {0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}; uint8_t device2Mac[6] = {0x00, 0x00, 0x00, 0x00, 0x00, 0x00}; uint8_t device2LTK[16] = {0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}; - + if(memcmp(device1Mac, address, 6) == 0) { memcpy(LTK, device1LTK, 16); @@ -159,7 +159,7 @@ void setup() { } Serial.println("BT init"); delay(200); - + /* Set a local name for the BLE device This name will appear in advertising packets and can be used by remote devices to identify this BLE device @@ -180,16 +180,16 @@ void setup() { stringCharValue = "string"; stringcharacteristic.writeValue(stringCharValue); secretValue.writeValue(0); - + delay(1000); // prevent pairing until button is pressed (will show a pairing rejected message) BLE.setPairable(false); - + /* Start advertising BLE. It will start continuously transmitting BLE advertising packets and will be visible to remote BLE central devices until it receives a new connection */ - + // start advertising if(!BLE.advertise()){ Serial.println("failed to advertise bluetooth."); @@ -214,13 +214,13 @@ void loop() { if (!BLE.pairable() && digitalRead(PAIR_BUTTON) == LOW){ pairingStarted = millis(); BLE.setPairable(Pairable::ONCE); - Serial.println("Accepting pairing for 30s"); + Serial.println("Accepting pairing for 30 s"); } else if (BLE.pairable() && millis() > pairingStarted + PAIR_INTERVAL){ BLE.setPairable(false); Serial.println("No longer accepting pairing"); } // Make LED blink while pairing is allowed - digitalWrite(PAIR_LED, (BLE.pairable() ? (millis()%400)<200 : BLE.paired()) ? PAIR_LED_ON : !PAIR_LED_ON); + digitalWrite(PAIR_LED, (BLE.pairable() ? (millis()%400)<200 : BLE.paired()) ? PAIR_LED_ON : !PAIR_LED_ON); // if a central is connected to the peripheral: @@ -246,7 +246,7 @@ void loop() { Serial.print("Disconnected from central: "); Serial.println(central.address()); } - + } void updateBatteryLevel() { diff --git a/examples/Peripheral/LED/LED.ino b/examples/Peripheral/LED/LED.ino index 2e6d6db9..65b88605 100644 --- a/examples/Peripheral/LED/LED.ino +++ b/examples/Peripheral/LED/LED.ino @@ -48,7 +48,7 @@ void setup() { // add service BLE.addService(ledService); - // set the initial value for the characeristic: + // set the initial value for the characteristic: switchCharacteristic.writeValue(0); // start advertising diff --git a/library.properties b/library.properties index 543998b7..6e248f5f 100644 --- a/library.properties +++ b/library.properties @@ -2,7 +2,7 @@ name=ArduinoBLE version=1.3.7 author=Arduino maintainer=Arduino -sentence=Enables Bluetooth® Low Energy connectivity on the Arduino MKR WiFi 1010, Arduino UNO WiFi Rev.2, Arduino Nano 33 IoT, Arduino Nano 33 BLE, Nicla Sense ME and UNO R4 WiFi. +sentence=Enables Bluetooth® Low Energy connectivity on the Arduino MKR WiFi 1010, Arduino UNO WiFi Rev2, Arduino Nano 33 IoT, Arduino Nano 33 BLE, Nicla Sense ME and UNO R4 WiFi. paragraph=This library supports creating a Bluetooth® Low Energy peripheral & central mode. category=Communication url=https://www.arduino.cc/en/Reference/ArduinoBLE diff --git a/src/utility/HCI.cpp b/src/utility/HCI.cpp index e9743758..fb30b3ca 100644 --- a/src/utility/HCI.cpp +++ b/src/utility/HCI.cpp @@ -137,7 +137,7 @@ void HCIClass::poll(unsigned long timeout) while (HCITransport.available()) { byte b = HCITransport.read(); - + if (_recvIndex >= sizeof(_recvBuffer)) { _recvIndex = 0; if (_debug) { @@ -161,7 +161,7 @@ void HCIClass::poll(unsigned long timeout) handleAclDataPkt(pktLen, &_recvBuffer[1]); #ifdef ARDUINO_AVR_UNO_WIFI_REV2 - digitalWrite(NINA_RTS, LOW); + digitalWrite(NINA_RTS, LOW); #endif } } else if (_recvBuffer[0] == HCI_EVENT_PKT) { @@ -363,7 +363,7 @@ int HCIClass::leSetAdvertiseEnable(uint8_t enable) return sendCommand(OGF_LE_CTL << 10 | OCF_LE_SET_ADVERTISE_ENABLE, sizeof(enable), &enable); } -int HCIClass::leSetScanParameters(uint8_t type, uint16_t interval, uint16_t window, +int HCIClass::leSetScanParameters(uint8_t type, uint16_t interval, uint16_t window, uint8_t ownBdaddrType, uint8_t filter) { struct __attribute__ ((packed)) HCILeSetScanParameters { @@ -437,7 +437,7 @@ int HCIClass::leCancelConn() return sendCommand(OGF_LE_CTL << 10 | OCF_LE_CANCEL_CONN, 0, NULL); } -int HCIClass::leConnUpdate(uint16_t handle, uint16_t minInterval, uint16_t maxInterval, +int HCIClass::leConnUpdate(uint16_t handle, uint16_t minInterval, uint16_t maxInterval, uint16_t latency, uint16_t supervisionTimeout) { struct __attribute__ ((packed)) HCILeConnUpdateData { @@ -464,7 +464,7 @@ void HCIClass::saveNewAddress(uint8_t addressType, uint8_t* address, uint8_t* pe if(_storeIRK!=0){ _storeIRK(address, peerIrk); } - // Again... this should work + // Again... this should work // leAddResolvingAddress(addressType, address, peerIrk, localIrk); } void HCIClass::leAddResolvingAddress(uint8_t addressType, uint8_t* peerAddress, uint8_t* peerIrk, uint8_t* localIrk){ @@ -490,7 +490,7 @@ void HCIClass::leAddResolvingAddress(uint8_t addressType, uint8_t* peerAddress, btct.printBytes(addDevice.peerIRK,16); Serial.print("localIRK :"); btct.printBytes(addDevice.localIRK,16); - sendCommand(OGF_LE_CTL << 10 | 0x27, sizeof(addDevice), &addDevice); + sendCommand(OGF_LE_CTL << 10 | 0x27, sizeof(addDevice), &addDevice); leStartResolvingAddresses(); } @@ -509,7 +509,7 @@ int HCIClass::leReadPeerResolvableAddress(uint8_t peerAddressType, uint8_t* peer } request; request.addressType = peerAddressType; for(int i=0; i<6; i++) request.identityAddress[5-i] = peerIdentityAddress[i]; - + int res = sendCommand(OGF_LE_CTL << 10 | 0x2B, sizeof(request), &request); Serial.print("res: 0x"); @@ -604,7 +604,7 @@ int HCIClass::tryResolveAddress(uint8_t* BDAddr, uint8_t* address){ delete BADDRs; delete[] (*IRKs); delete IRKs; - + if(foundMatch){ return 1; } @@ -688,7 +688,6 @@ int HCIClass::sendCommand(uint16_t opcode, uint8_t plen, void* parameters) for(int i=0; i< sizeof(pktHdr) + plen;i++){ Serial.print(" 0x"); Serial.print(txBuffer[i],HEX); - } Serial.println(""); #endif @@ -758,7 +757,7 @@ void HCIClass::handleAclDataPkt(uint8_t /*plen*/, uint8_t pdata[]) } } else if (aclHdr->cid == SIGNALING_CID) { #ifdef _BLE_TRACE_ - Serial.println("Signalling"); + Serial.println("Signaling"); #endif L2CAPSignaling.handleData(aclHdr->handle & 0x0fff, aclHdr->len, &_recvBuffer[1 + sizeof(HCIACLHdr)]); } else if (aclHdr->cid == SECURITY_CID){ @@ -853,7 +852,7 @@ void HCIClass::handleEventPkt(uint8_t /*plen*/, uint8_t pdata[]) } // From page 1681 bluetooth standard - order matters if(ATT.localKeyDistribution.IdKey()){ - /// We shall distribute IRK and address using identity information + /// We shall distribute IRK and address using identity information { uint8_t response[17]; response[0] = CONNECTION_IDENTITY_INFORMATION; // Identity information. @@ -1002,7 +1001,7 @@ void HCIClass::handleEventPkt(uint8_t /*plen*/, uint8_t pdata[]) uint16_t supervisionTimeout; uint8_t masterClockAccuracy; } *leConnectionComplete = (EvtLeConnectionComplete*)&pdata[sizeof(HCIEventHdr) + sizeof(LeMetaEventHeader)]; - + if (leConnectionComplete->status == 0x00) { ATT.addConnection(leConnectionComplete->handle, leConnectionComplete->role, @@ -1051,7 +1050,7 @@ void HCIClass::handleEventPkt(uint8_t /*plen*/, uint8_t pdata[]) uint16_t supervisionTimeout; uint8_t masterClockAccuracy; } *leConnectionComplete = (EvtLeConnectionComplete*)&pdata[sizeof(HCIEventHdr) + sizeof(LeMetaEventHeader)]; - + if (leConnectionComplete->status == 0x00) { ATT.addConnection(leConnectionComplete->handle, leConnectionComplete->role, @@ -1127,7 +1126,7 @@ void HCIClass::handleEventPkt(uint8_t /*plen*/, uint8_t pdata[]) uint8_t resolvableAddr[6]; uint8_t foundLTK; ATT.getPeerAddrWithType(ltkRequest->connectionHandle, peerAddr); - + if((ATT.getPeerEncryption(ltkRequest->connectionHandle) & PEER_ENCRYPTION::PAIRING_REQUEST)>0){ // Pairing request - LTK is one in buffer already foundLTK = 1; @@ -1207,7 +1206,7 @@ void HCIClass::handleEventPkt(uint8_t /*plen*/, uint8_t pdata[]) Serial.print("Timeout : "); btct.printBytes((uint8_t*)&remoteConnParamReq->timeOut,2); #endif - + struct __attribute__ ((packed)) RemoteConnParamReqReply { uint16_t connectionHandle; uint16_t intervalMin; @@ -1253,13 +1252,13 @@ void HCIClass::handleEventPkt(uint8_t /*plen*/, uint8_t pdata[]) HCI.sendAclPkt(connectionHandle,SECURITY_CID,sizeof(PairingPublicKey),&pairingPublicKey); uint8_t encryption = ATT.getPeerEncryption(connectionHandle) | PEER_ENCRYPTION::SENT_PUBKEY; ATT.setPeerEncryption(connectionHandle, encryption); - + uint8_t Z = 0; - + HCI.leRand(Nb); HCI.leRand(&Nb[8]); - + #ifdef _BLE_TRACE_ Serial.print("nb: "); btct.printBytes(Nb, 16); @@ -1271,16 +1270,16 @@ void HCIClass::handleEventPkt(uint8_t /*plen*/, uint8_t pdata[]) uint8_t Z; } f4Params = {0,0,Z}; for(int i=0; i<32; i++){ - f4Params.U[31-i] = pairingPublicKey.publicKey[i]; + f4Params.U[31-i] = pairingPublicKey.publicKey[i]; f4Params.V[31-i] = HCI.remotePublicKeyBuffer[i]; } - + struct __attribute__ ((packed)) PairingConfirm { uint8_t code; uint8_t cb[16]; } pairingConfirm = {CONNECTION_PAIRING_CONFIRM,0}; - + btct.AES_CMAC(Nb,(unsigned char *)&f4Params,sizeof(f4Params),pairingConfirm.cb); #ifdef _BLE_TRACE_ @@ -1297,7 +1296,7 @@ void HCIClass::handleEventPkt(uint8_t /*plen*/, uint8_t pdata[]) // Send Pairing confirm response HCI.sendAclPkt(connectionHandle, SECURITY_CID, sizeof(pairingConfirm), &pairingConfirm); - + HCI.sendCommand( (OGF_LE_CTL << 10) | LE_COMMAND::GENERATE_DH_KEY_V1, sizeof(HCI.remotePublicKeyBuffer), HCI.remotePublicKeyBuffer); }else{ #ifdef _BLE_TRACE_ @@ -1329,8 +1328,8 @@ void HCIClass::handleEventPkt(uint8_t /*plen*/, uint8_t pdata[]) #endif break; } - - + + for(int i=0; i<32; i++) DHKey[31-i] = evtLeDHKeyComplete->DHKey[i]; #ifdef _BLE_TRACE_ @@ -1345,7 +1344,7 @@ void HCIClass::handleEventPkt(uint8_t /*plen*/, uint8_t pdata[]) Serial.println("Received DHKey check already so calculate f5, f6 now."); #endif L2CAPSignaling.smCalculateLTKandConfirm(connectionHandle, HCI.remoteDHKeyCheckBuffer); - + }else{ #ifdef _BLE_TRACE_ Serial.println("Waiting on other DHKey check before calculating."); @@ -1382,7 +1381,7 @@ int HCIClass::leEncrypt(uint8_t* key, uint8_t* plaintext, uint8_t* status, uint8 leEncryptCommand.key[15-i] = key[i]; leEncryptCommand.plaintext[15-i] = plaintext[i]; } - + int res = sendCommand(OGF_LE_CTL << 10 | LE_COMMAND::ENCRYPT, 32, &leEncryptCommand); if(res == 0){ #ifdef _BLE_TRACE_ From 9a6d4e0f5fec6a94bcf121e8c1be6f7e063789d8 Mon Sep 17 00:00:00 2001 From: FidelSch Date: Wed, 19 Feb 2025 17:28:07 -0300 Subject: [PATCH 05/32] fix: compilation error when using _BLE_TRACE Now correctly acceses the existing variables and uses an unsigned int for size comparison --- src/utility/L2CAPSignaling.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/utility/L2CAPSignaling.cpp b/src/utility/L2CAPSignaling.cpp index 7af170df..da2afea2 100644 --- a/src/utility/L2CAPSignaling.cpp +++ b/src/utility/L2CAPSignaling.cpp @@ -230,9 +230,9 @@ void L2CAPSignalingClass::handleSecurityData(uint16_t connectionHandle, uint8_t Serial.print("V : "); btct.printBytes(V,32); Serial.print("X : "); - btct.printBytes(X,16); + btct.printBytes(HCI.Na,16); Serial.print("Y : "); - btct.printBytes(Y,16); + btct.printBytes(HCI.Nb,16); Serial.print("g2res : "); btct.printBytes(g2Result,4); Serial.print("Result : "); @@ -413,7 +413,7 @@ void L2CAPSignalingClass::smCalculateLTKandConfirm(uint16_t handle, uint8_t expe // Send our confirmation value to complete authentication stage 2 uint8_t ret[17]; ret[0] = CONNECTION_PAIRING_DHKEY_CHECK; - for(int i=0; i Date: Thu, 3 Oct 2024 14:52:10 +0200 Subject: [PATCH 06/32] fix crashes on M0 board when assigning the BLE handle from the received data buffer --- src/utility/ATT.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/utility/ATT.cpp b/src/utility/ATT.cpp index b1796c90..9367cfbf 100644 --- a/src/utility/ATT.cpp +++ b/src/utility/ATT.cpp @@ -993,8 +993,8 @@ void ATTClass::readOrReadBlobReq(uint16_t connectionHandle, uint16_t mtu, uint8_ } /// if auth error, hold the response in a buffer. bool holdResponse = false; - - uint16_t handle = *(uint16_t*)data; + uint16_t handle; + memcpy(&handle, data, sizeof(handle)); uint16_t offset = (opcode == ATT_OP_READ_REQ) ? 0 : *(uint16_t*)&data[sizeof(handle)]; if ((uint16_t)(handle - 1) > GATT.attributeCount()) { @@ -1248,7 +1248,8 @@ void ATTClass::writeReqOrCmd(uint16_t connectionHandle, uint16_t mtu, uint8_t op return; } - uint16_t handle = *(uint16_t*)data; + uint16_t handle; + memcpy(&handle, data, sizeof(handle)); if ((uint16_t)(handle - 1) > GATT.attributeCount()) { if (withResponse) { From 2975d9fbf5bf6c8a78c81f7668bde1cad3d01056 Mon Sep 17 00:00:00 2001 From: Frederic Pillon Date: Thu, 20 Mar 2025 10:35:12 +0100 Subject: [PATCH 07/32] fix(HCI): missing LE_Event_Mask Linked to: https://github.com/arduino-libraries/ArduinoBLE/issues/310 Signed-off-by: Frederic Pillon --- src/utility/HCI.cpp | 3 ++- src/utility/HCI.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/utility/HCI.cpp b/src/utility/HCI.cpp index fb30b3ca..8e2b5904 100644 --- a/src/utility/HCI.cpp +++ b/src/utility/HCI.cpp @@ -82,6 +82,7 @@ String metaEventToString(LE_META_EVENT event) case LONG_TERM_KEY_REQUEST: return F("LE_LONG_TERM_KEY_REQUEST"); case READ_LOCAL_P256_COMPLETE: return F("READ_LOCAL_P256_COMPLETE"); case GENERATE_DH_KEY_COMPLETE: return F("GENERATE_DH_KEY_COMPLETE"); + case ENHANCED_CONN_COMPLETE: return F("ENHANCED_CONN_COMPLETE"); default: return "event unknown"; } } @@ -987,7 +988,7 @@ void HCIClass::handleEventPkt(uint8_t /*plen*/, uint8_t pdata[]) Serial.println(leMetaHeader->subevent,HEX); #endif switch((LE_META_EVENT)leMetaHeader->subevent){ - case 0x0A:{ + case ENHANCED_CONN_COMPLETE:{ struct __attribute__ ((packed)) EvtLeConnectionComplete { uint8_t status; uint16_t handle; diff --git a/src/utility/HCI.h b/src/utility/HCI.h index 0a530ceb..a6fa66e8 100644 --- a/src/utility/HCI.h +++ b/src/utility/HCI.h @@ -46,7 +46,8 @@ enum LE_META_EVENT { LONG_TERM_KEY_REQUEST = 0x05, REMOTE_CONN_PARAM_REQ = 0x06, READ_LOCAL_P256_COMPLETE = 0x08, - GENERATE_DH_KEY_COMPLETE = 0x09 + GENERATE_DH_KEY_COMPLETE = 0x09, + ENHANCED_CONN_COMPLETE = 0x0A, }; String metaEventToString(LE_META_EVENT event); String commandToString(LE_COMMAND command); From bf62cd55b8dcdc131679a3bebd78311069260e93 Mon Sep 17 00:00:00 2001 From: Frederic Pillon Date: Wed, 5 Mar 2025 18:53:08 +0100 Subject: [PATCH 08/32] fix: signed and init field warnings Signed-off-by: Frederic Pillon --- src/utility/HCI.cpp | 14 +++++++++----- src/utility/L2CAPSignaling.cpp | 6 ++++-- src/utility/btct.cpp | 6 +++--- 3 files changed, 16 insertions(+), 10 deletions(-) diff --git a/src/utility/HCI.cpp b/src/utility/HCI.cpp index fb30b3ca..7ae4607f 100644 --- a/src/utility/HCI.cpp +++ b/src/utility/HCI.cpp @@ -138,7 +138,7 @@ void HCIClass::poll(unsigned long timeout) while (HCITransport.available()) { byte b = HCITransport.read(); - if (_recvIndex >= sizeof(_recvBuffer)) { + if (_recvIndex >= (int)sizeof(_recvBuffer)) { _recvIndex = 0; if (_debug) { _debug->println("_recvBuffer overflow"); @@ -461,6 +461,8 @@ int HCIClass::leConnUpdate(uint16_t handle, uint16_t minInterval, uint16_t maxIn return sendCommand(OGF_LE_CTL << 10 | OCF_LE_CONN_UPDATE, sizeof(leConnUpdateData), &leConnUpdateData); } void HCIClass::saveNewAddress(uint8_t addressType, uint8_t* address, uint8_t* peerIrk, uint8_t* localIrk){ + (void)addressType; + (void)localIrk; if(_storeIRK!=0){ _storeIRK(address, peerIrk); } @@ -503,6 +505,7 @@ int HCIClass::leStartResolvingAddresses(){ return HCI.sendCommand(OGF_LE_CTL << 10 | 0x2D, 1,&enable); // Disable address resolution } int HCIClass::leReadPeerResolvableAddress(uint8_t peerAddressType, uint8_t* peerIdentityAddress, uint8_t* peerResolvableAddress){ + (void)peerResolvableAddress; struct __attribute__ ((packed)) Request { uint8_t addressType; uint8_t identityAddress[6]; @@ -546,7 +549,7 @@ int HCIClass::readStoredLK(uint8_t BD_ADDR[], uint8_t read_all ){ struct __attribute__ ((packed)) Request { uint8_t BD_ADDR[6]; uint8_t read_a; - } request = {0,0}; + } request = {{0},0}; for(int i=0; i<6; i++) request.BD_ADDR[5-i] = BD_ADDR[i]; request.read_a = read_all; return sendCommand(OGF_HOST_CTL << 10 | 0xD, sizeof(request), &request); @@ -1268,7 +1271,7 @@ void HCIClass::handleEventPkt(uint8_t /*plen*/, uint8_t pdata[]) uint8_t U[32]; uint8_t V[32]; uint8_t Z; - } f4Params = {0,0,Z}; + } f4Params = {{0},{0},Z}; for(int i=0; i<32; i++){ f4Params.U[31-i] = pairingPublicKey.publicKey[i]; f4Params.V[31-i] = HCI.remotePublicKeyBuffer[i]; @@ -1288,7 +1291,7 @@ void HCIClass::handleEventPkt(uint8_t /*plen*/, uint8_t pdata[]) #endif uint8_t cb_temp[sizeof(pairingConfirm.cb)]; - for(int i=0; icode; @@ -310,8 +312,8 @@ void L2CAPSignalingClass::handleSecurityData(uint16_t connectionHandle, uint8_t uint8_t x[32]; uint8_t y[32]; } generateDHKeyCommand = { - 0x00, - 0x00, + {0x00}, + {0x00}, }; memcpy(generateDHKeyCommand.x,connectionPairingPublicKey->x,32); memcpy(generateDHKeyCommand.y,connectionPairingPublicKey->y,32); diff --git a/src/utility/btct.cpp b/src/utility/btct.cpp index 6829494c..55a51dbe 100644 --- a/src/utility/btct.cpp +++ b/src/utility/btct.cpp @@ -71,7 +71,7 @@ int BluetoothCryptoToolbox::f5(uint8_t DHKey[],uint8_t N_master[], uint8_t N_sla uint8_t A1[7]; uint8_t A2[7]; uint8_t length[2]; - } cmacInput = {0,0,0,0,0,0,0}; + } cmacInput = {0,{0},{0},{0},{0},{0},{0}}; cmacInput.counter = 0; memcpy(cmacInput.keyID, keyID, 4); memcpy(cmacInput.N1,N_master,16); @@ -97,7 +97,7 @@ int BluetoothCryptoToolbox::f6(uint8_t W[], uint8_t N1[],uint8_t N2[],uint8_t R[ uint8_t IOCap[3]; uint8_t A1[7]; uint8_t A2[7]; - } f6Input = {0,0,0,0,0,0}; + } f6Input = {{0},{0},{0},{0},{0},{0}}; memcpy(f6Input.N1, N1, 16); memcpy(f6Input.N2, N2, 16); @@ -145,7 +145,7 @@ int BluetoothCryptoToolbox::g2(uint8_t U[], uint8_t V[], uint8_t X[], uint8_t Y[ uint8_t U[32]; uint8_t V[32]; uint8_t Y[16]; - } cmacInput= {0,0,0}; + } cmacInput= {{0},{0},{0}}; memcpy(cmacInput.U,U,32); memcpy(cmacInput.V,V,32); memcpy(cmacInput.Y,Y,16); From d52e25aa464ae3b557ce01fe6c26d3c2b2de66ab Mon Sep 17 00:00:00 2001 From: FidelSch Date: Mon, 24 Mar 2025 19:54:29 -0300 Subject: [PATCH 09/32] Update src/utility/L2CAPSignaling.cpp Unsigned integer type consistency Co-authored-by: Frederic Pillon --- src/utility/L2CAPSignaling.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/utility/L2CAPSignaling.cpp b/src/utility/L2CAPSignaling.cpp index da2afea2..c2c46a23 100644 --- a/src/utility/L2CAPSignaling.cpp +++ b/src/utility/L2CAPSignaling.cpp @@ -413,7 +413,7 @@ void L2CAPSignalingClass::smCalculateLTKandConfirm(uint16_t handle, uint8_t expe // Send our confirmation value to complete authentication stage 2 uint8_t ret[17]; ret[0] = CONNECTION_PAIRING_DHKEY_CHECK; - for(uint i=0; i Date: Mon, 2 Nov 2020 16:59:23 +0100 Subject: [PATCH 10/32] [WIP] Add unit test workflow based on https://github.com/arduino/cpp-test-action/pull/2 --- .github/workflows/unit-tests.yml | 45 ++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) create mode 100644 .github/workflows/unit-tests.yml diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml new file mode 100644 index 00000000..b889c771 --- /dev/null +++ b/.github/workflows/unit-tests.yml @@ -0,0 +1,45 @@ +name: Unit Tests + +on: + pull_request: + paths: + - ".github/workflows/unit-tests.yml" + - 'extras/test/**' + - 'src/**' + + push: + paths: + - ".github/workflows/unit-tests.yml" + - 'extras/test/**' + - 'src/**' + +jobs: + test: + name: Run unit tests + runs-on: ubuntu-latest + + env: + COVERAGE_DATA_PATH: extras/coverage-data/coverage.info + + steps: + - name: Checkout + uses: actions/checkout@v2 + + - uses: arduino/cpp-test-action@main + with: + runtime-paths: | + - extras/test/build/bin/TEST_TARGET_UUID + - extras/test/build/bin/TEST_TARGET_DISC_DEVICE + - extras/test/build/bin/TEST_TARGET_ADVERTISING_DATA + coverage-exclude-paths: | + - '*/extras/test/*' + - '/usr/*' + coverage-data-path: ${{ env.COVERAGE_DATA_PATH }} + + - name: Upload coverage report to Codecov + uses: codecov/codecov-action@v1 + with: + file: "${{ env.COVERAGE_DATA_PATH }}" + fail_ci_if_error: true + + From 1340d09238cc5d08c6f7aa33aa93720f8bc77e76 Mon Sep 17 00:00:00 2001 From: Paolo Calao Date: Tue, 3 Nov 2020 11:35:54 +0100 Subject: [PATCH 11/32] [CI] Fix uninitialized checked variable --- extras/test/src/test_advertising_data/test_advertising_data.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extras/test/src/test_advertising_data/test_advertising_data.cpp b/extras/test/src/test_advertising_data/test_advertising_data.cpp index 67fa1d25..005ab51d 100644 --- a/extras/test/src/test_advertising_data/test_advertising_data.cpp +++ b/extras/test/src/test_advertising_data/test_advertising_data.cpp @@ -142,7 +142,7 @@ TEST_CASE("BLE test raw data", "[ArduinoBLE::BLEAdvertisingData]") uint8_t data[] = {1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32 }; - advData.setRawData(data, sizeof(data)); + retVal = advData.setRawData(data, sizeof(data)); REQUIRE(!retVal); advData.clear(); } From 8035af8ad3ae2ef27e051bf42effd17f6280e527 Mon Sep 17 00:00:00 2001 From: Paolo Calao Date: Wed, 11 Nov 2020 15:47:13 +0100 Subject: [PATCH 12/32] [CI] Improve unit tests - improve test failures readability - add const qualifiers to golden data for improving safety --- .../test_advertising_data.cpp | 58 ++++++++----- .../test_advertising_data/test_local_name.cpp | 43 ++++++---- .../test_manufacturer.cpp | 81 ++++++++++++------- .../test_advertising_data/test_service.cpp | 55 ++++++++----- extras/test/src/test_uuid/test_uuid.cpp | 2 +- 5 files changed, 157 insertions(+), 82 deletions(-) diff --git a/extras/test/src/test_advertising_data/test_advertising_data.cpp b/extras/test/src/test_advertising_data/test_advertising_data.cpp index 005ab51d..5c4902d8 100644 --- a/extras/test/src/test_advertising_data/test_advertising_data.cpp +++ b/extras/test/src/test_advertising_data/test_advertising_data.cpp @@ -30,8 +30,8 @@ TEST_CASE("Test flags override", "[ArduinoBLE::BLEAdvertisingData]") // Mocking advertisement packet BLEAdvertisingData advData; // Expected results - uint8_t defaultData[] = {0x02, BLEFieldFlags, 0x06}; - uint8_t goldenFlags[] = {0x02, 0x01, BLEFlagsBREDRNotSupported}; + const uint8_t defaultData[] = {0x02, BLEFieldFlags, 0x06}; + const uint8_t goldenFlags[] = {0x02, 0x01, BLEFlagsBREDRNotSupported}; WHEN("Default options for flags") { @@ -74,9 +74,9 @@ TEST_CASE("Set default flags in an already full advertising data packet", "[Ardu const uint8_t manufacturerData[24] = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23}; - uint8_t defaultFlags[3] = {0x02, 0x01, 0x06}; + const uint8_t defaultFlags[3] = {0x02, 0x01, 0x06}; - uint8_t goldenData[31] = { + const uint8_t goldenData[31] = { (sizeof(manufacturerData) + 1), BLEFieldManufacturerData, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, ((uint8_t)(strlen(name) + 1)), BLEFieldCompleteLocalName, 't', 'e', 's' @@ -109,22 +109,36 @@ TEST_CASE("BLE overwrite a full internal advertising data with an external built BLE.setLocalName("test"); BLE.setAdvertisedServiceUuid("1818"); BLE.advertise(); - //WARN("data length: " << BLE.getAdvertisingData().dataLength()); - verify = (BLE.getAdvertisingData().dataLength() == (3 + (2+2))); - REQUIRE(verify); - verify = (BLE.getScanResponseData().dataLength() == (4+2)); - REQUIRE(verify); + THEN("Check that BLE advertising data has been set") + { + verify = (BLE.getAdvertisingData().dataLength() == (3 + (2+2))); + REQUIRE(verify); + } + + THEN("Check that BLE scan response data has been set") + { + verify = (BLE.getScanResponseData().dataLength() == (4+2)); + REQUIRE(verify); + } + + // Copy external empty adv data into advertising data BLE.setAdvertisingData(advData); BLE.advertise(); - //WARN(BLE.getAdvertisingData().dataLength()); - verify = (BLE.getAdvertisingData().dataLength() == 3); - REQUIRE(verify); + THEN("BLE advertising data should be erased") + { + verify = (BLE.getAdvertisingData().dataLength() == 3); + REQUIRE(verify); + } + // Copy external empty adv data into scan response data BLE.setScanResponseData(advData); BLE.advertise(); - verify = (BLE.getScanResponseData().dataLength() == 0); - REQUIRE(verify); + THEN("BLE scan response data should be erased") + { + verify = (BLE.getScanResponseData().dataLength() == 0); + REQUIRE(verify); + } } // Clear BLE advertising data @@ -139,21 +153,27 @@ TEST_CASE("BLE test raw data", "[ArduinoBLE::BLEAdvertisingData]") WHEN("Set too large raw data") { - uint8_t data[] = {1, 2, 3, 4, 5, 6, 7, 8, 9, 10, + const uint8_t data[] = {1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32 }; retVal = advData.setRawData(data, sizeof(data)); - REQUIRE(!retVal); + THEN("Set raw data should return false. The parameter should not be set") + { + REQUIRE(!retVal); + } advData.clear(); } WHEN("Set correct raw data") { - uint8_t data[] = {1, 2, 3, 4, 5, 6, 7, 8, 9, 10, + const uint8_t data[] = {1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31}; retVal = advData.setRawData(data, sizeof(data)); - REQUIRE(retVal); + THEN("Set raw data should return true. The parameter should be correctly set") + { + REQUIRE(retVal); + } advData.updateData(); REQUIRE( 0 == memcmp(data, advData.data(), sizeof(data)) ); advData.clear(); @@ -161,7 +181,7 @@ TEST_CASE("BLE test raw data", "[ArduinoBLE::BLEAdvertisingData]") WHEN("Hide other parameters by setting raw data") { - uint8_t data[] = {1, 2, 3, 4, 5, 6, 7, 8, 9, 10}; + const uint8_t data[] = {1, 2, 3, 4, 5, 6, 7, 8, 9, 10}; advData.setLocalName("test"); advData.setRawData(data, sizeof(data)); diff --git a/extras/test/src/test_advertising_data/test_local_name.cpp b/extras/test/src/test_advertising_data/test_local_name.cpp index 947224cc..a0b4e19d 100644 --- a/extras/test/src/test_advertising_data/test_local_name.cpp +++ b/extras/test/src/test_advertising_data/test_local_name.cpp @@ -35,8 +35,15 @@ TEST_CASE("Test local name setting", "[ArduinoBLE::BLEAdvertisingData]") { const char* name = "test"; retVal = advData.setLocalName(name); - REQUIRE(retVal); - REQUIRE( (strlen(name) + 2) == (oldRemainingLength - advData.remainingLength()) ); + THEN("Set local name should return true. The name parameter should be correctly set") + { + REQUIRE(retVal); + } + + THEN("Check the exact number of bytes occupied by the name just set") + { + REQUIRE( (strlen(name) + 2) == (oldRemainingLength - advData.remainingLength()) ); + } oldRemainingLength = advData.remainingLength(); advData.updateData(); @@ -47,30 +54,36 @@ TEST_CASE("Test local name setting", "[ArduinoBLE::BLEAdvertisingData]") { const char* name = "way too long local name (len 32)"; retVal = advData.setLocalName(name); - REQUIRE(!retVal); - REQUIRE( oldRemainingLength == advData.remainingLength() ); - advData.updateData(); - REQUIRE( advData.dataLength() == (MAX_AD_DATA_LENGTH - oldRemainingLength) ); + THEN("Set local name should return false. The name parameter should not be set") + { + REQUIRE(!retVal); + REQUIRE( oldRemainingLength == advData.remainingLength() ); + advData.updateData(); + REQUIRE( advData.dataLength() == (MAX_AD_DATA_LENGTH - oldRemainingLength) ); + } } WHEN("Overwrite local name with a name as long as max data length") { const char* name = "local name with full length "; retVal = advData.setLocalName(name); - REQUIRE(retVal); - REQUIRE( (strlen(name) + 2) == (oldRemainingLength - advData.remainingLength()) ); - oldRemainingLength = advData.remainingLength(); + THEN("The name parameter should be correctly overwritten. The remaining length should be 0") + { + REQUIRE(retVal); + REQUIRE( (strlen(name) + 2) == (oldRemainingLength - advData.remainingLength()) ); + oldRemainingLength = advData.remainingLength(); - advData.updateData(); - REQUIRE(advData.dataLength() == (strlen(name) + 2)); - // advData should be full now - REQUIRE( 0 == advData.remainingLength() ); - REQUIRE( 0 == advData.availableForWrite() ); + advData.updateData(); + REQUIRE(advData.dataLength() == (strlen(name) + 2)); + // advData should be full now + REQUIRE( 0 == advData.remainingLength() ); + REQUIRE( 0 == advData.availableForWrite() ); + } } WHEN("Check consistency when setting the external advertising data") { - auto goldenData = advData.data(); + const auto goldenData = advData.data(); BLE.setAdvertisingData(advData); BLE.advertise(); REQUIRE( 0 == memcmp(goldenData, BLE.getAdvertisingData().data(), advData.dataLength()) ); diff --git a/extras/test/src/test_advertising_data/test_manufacturer.cpp b/extras/test/src/test_advertising_data/test_manufacturer.cpp index 39f7e955..7c23d26c 100644 --- a/extras/test/src/test_advertising_data/test_manufacturer.cpp +++ b/extras/test/src/test_advertising_data/test_manufacturer.cpp @@ -29,7 +29,7 @@ TEST_CASE("Test manufacturer data setting", "[ArduinoBLE::BLEAdvertisingData]") { BLEAdvertisingData advData; int oldRemainingLength = advData.remainingLength(); - uint16_t companyId = 0x1100; + const uint16_t companyId = 0x1100; bool retVal; WHEN("Set correct manufacturer data without id") @@ -38,8 +38,11 @@ TEST_CASE("Test manufacturer data setting", "[ArduinoBLE::BLEAdvertisingData]") const uint8_t goldenData[] = {(sizeof(data) + 1), BLEFieldManufacturerData, 0x00, 0x11, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9}; retVal = advData.setManufacturerData(data, sizeof(data)); - REQUIRE(retVal); - REQUIRE( (sizeof(data) + 2) == (oldRemainingLength - advData.remainingLength()) ); + THEN("Check that the manufacturer data has been correctly set") + { + REQUIRE(retVal); + REQUIRE( (sizeof(data) + 2) == (oldRemainingLength - advData.remainingLength()) ); + } oldRemainingLength = advData.remainingLength(); advData.updateData(); @@ -53,8 +56,11 @@ TEST_CASE("Test manufacturer data setting", "[ArduinoBLE::BLEAdvertisingData]") const uint8_t goldenData[] = {(sizeof(data) + sizeof(companyId) + 1), BLEFieldManufacturerData, 0x00, 0x11, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9}; retVal = advData.setManufacturerData(companyId, data, sizeof(data)); - REQUIRE(retVal); - REQUIRE( (sizeof(data) + sizeof(companyId) + 2) == (oldRemainingLength - advData.remainingLength()) ); + THEN("Check that the manufacturer data has been correctly set") + { + REQUIRE(retVal); + REQUIRE( (sizeof(data) + sizeof(companyId) + 2) == (oldRemainingLength - advData.remainingLength()) ); + } oldRemainingLength = advData.remainingLength(); advData.updateData(); @@ -68,8 +74,11 @@ TEST_CASE("Test manufacturer data setting", "[ArduinoBLE::BLEAdvertisingData]") const uint8_t data[] = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27}; retVal = advData.setManufacturerData(companyId, data, sizeof(data)); - REQUIRE(!retVal); - REQUIRE( oldRemainingLength == advData.remainingLength() ); + THEN("Manufacturer data was too long, check that it has not been set") + { + REQUIRE(!retVal); + REQUIRE( oldRemainingLength == advData.remainingLength() ); + } advData.updateData(); REQUIRE( advData.dataLength() == (MAX_AD_DATA_LENGTH - oldRemainingLength) ); } @@ -80,8 +89,11 @@ TEST_CASE("Test manufacturer data setting", "[ArduinoBLE::BLEAdvertisingData]") const uint8_t data[] = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29}; retVal = advData.setManufacturerData(data, sizeof(data)); - REQUIRE(!retVal); - REQUIRE( oldRemainingLength == advData.remainingLength() ); + THEN("Manufacturer data was too long, check that it has not been set") + { + REQUIRE(!retVal); + REQUIRE( oldRemainingLength == advData.remainingLength() ); + } advData.updateData(); REQUIRE( advData.dataLength() == (MAX_AD_DATA_LENGTH - oldRemainingLength) ); } @@ -93,13 +105,19 @@ TEST_CASE("Test manufacturer data setting", "[ArduinoBLE::BLEAdvertisingData]") 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26}; const uint8_t data[] = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28}; - retVal = advData.setManufacturerData(companyId, dataGivenId, sizeof(dataGivenId)); - REQUIRE(retVal); - retVal = advData.setManufacturerData(data, sizeof(data)); - REQUIRE(retVal); - REQUIRE( 0 == advData.remainingLength() ); - advData.updateData(); - REQUIRE( advData.dataLength() == (MAX_AD_DATA_LENGTH) ); + THEN("Check that first insertion of manufacturer data given id is correctly done") + { + retVal = advData.setManufacturerData(companyId, dataGivenId, sizeof(dataGivenId)); + REQUIRE(retVal); + } + THEN("Check that the insertion of manufacturer data without after one with id is correctly done") + { + retVal = advData.setManufacturerData(data, sizeof(data)); + REQUIRE(retVal); + REQUIRE( 0 == advData.remainingLength() ); + advData.updateData(); + REQUIRE( advData.dataLength() == (MAX_AD_DATA_LENGTH) ); + } } WHEN("Set manufacturer data given id after setting manufacturer data without id") @@ -110,10 +128,16 @@ TEST_CASE("Test manufacturer data setting", "[ArduinoBLE::BLEAdvertisingData]") 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27}; const uint8_t data[] = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28}; - retVal = advData.setManufacturerData(data, sizeof(data)); - REQUIRE(retVal); - retVal = advData.setManufacturerData(companyId, dataGivenId, sizeof(dataGivenId)); - REQUIRE(!retVal); + THEN("Check that first insertion of manufacturer data WITHOUT id is correctly done") + { + retVal = advData.setManufacturerData(data, sizeof(data)); + REQUIRE(retVal); + } + THEN("Check that the insertion of manufacturer data given id after one without id is correctly done") + { + retVal = advData.setManufacturerData(companyId, dataGivenId, sizeof(dataGivenId)); + REQUIRE(!retVal); + } } WHEN("Overwrite manufacturer data with one as long as max data length") @@ -124,17 +148,20 @@ TEST_CASE("Test manufacturer data setting", "[ArduinoBLE::BLEAdvertisingData]") 0x00, 0x11, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26}; retVal = advData.setManufacturerData(companyId, data, sizeof(data)); - REQUIRE(retVal); - - advData.updateData(); - REQUIRE( 0 == advData.remainingLength() ); - REQUIRE( 0 == advData.availableForWrite() ); - REQUIRE( 0 == memcmp(goldenData, advData.data(), sizeof(goldenData)) ); + THEN("Manufacturer data should be set correctly") + { + REQUIRE(retVal); + + advData.updateData(); + REQUIRE( 0 == advData.remainingLength() ); + REQUIRE( 0 == advData.availableForWrite() ); + REQUIRE( 0 == memcmp(goldenData, advData.data(), sizeof(goldenData)) ); + } } WHEN("Check consistency when setting the external advertising data") { - auto goldenData = advData.data(); + const auto goldenData = advData.data(); BLE.setAdvertisingData(advData); BLE.advertise(); REQUIRE( 0 == memcmp(goldenData, BLE.getAdvertisingData().data(), advData.dataLength()) ); diff --git a/extras/test/src/test_advertising_data/test_service.cpp b/extras/test/src/test_advertising_data/test_service.cpp index 5c212c1f..66b1689f 100644 --- a/extras/test/src/test_advertising_data/test_service.cpp +++ b/extras/test/src/test_advertising_data/test_service.cpp @@ -50,12 +50,13 @@ TEST_CASE("Test advertised service id setting", "[ArduinoBLE::BLEAdvertisingData const char* service = "00112233445566770011223344556677"; advData.setLocalName(name); oldRemainingLength = advData.remainingLength(); - retVal = advData.setAdvertisedServiceUuid(service); - REQUIRE(!retVal); - - REQUIRE( oldRemainingLength == advData.remainingLength() ); - advData.updateData(); - REQUIRE( advData.dataLength() == (MAX_AD_DATA_LENGTH - oldRemainingLength) ); + THEN("Check that the too long parameter has not been set") + { + REQUIRE(!advData.setAdvertisedServiceUuid(service)); + REQUIRE( oldRemainingLength == advData.remainingLength() ); + advData.updateData(); + REQUIRE( advData.dataLength() == (MAX_AD_DATA_LENGTH - oldRemainingLength) ); + } } WHEN("Fill to maximum an advertising packet with a service id") @@ -64,8 +65,7 @@ TEST_CASE("Test advertised service id setting", "[ArduinoBLE::BLEAdvertisingData const char* name = "11 char str"; const char* service = "00112233445566770011223344556677"; advData.setLocalName(name); - retVal = advData.setAdvertisedServiceUuid(service); - REQUIRE(retVal); + REQUIRE(advData.setAdvertisedServiceUuid(service)); advData.updateData(); REQUIRE(advData.dataLength() == (MAX_AD_DATA_LENGTH)); @@ -76,7 +76,7 @@ TEST_CASE("Test advertised service id setting", "[ArduinoBLE::BLEAdvertisingData WHEN("Check consistency when setting the external advertising data") { - auto goldenData = advData.data(); + const auto goldenData = advData.data(); BLE.setAdvertisingData(advData); BLE.advertise(); REQUIRE( 0 == memcmp(goldenData, BLE.getAdvertisingData().data(), advData.dataLength()) ); @@ -91,7 +91,7 @@ TEST_CASE("Test service data setting", "[ArduinoBLE::BLEAdvertisingData]") { BLEAdvertisingData advData; int oldRemainingLength = advData.remainingLength(); - uint16_t uuid = 0x1100; + const uint16_t uuid = 0x1100; bool retVal; WHEN("Set correct service data") @@ -100,14 +100,20 @@ TEST_CASE("Test service data setting", "[ArduinoBLE::BLEAdvertisingData]") const uint8_t goldenData[] = {(sizeof(data) + sizeof(uuid) + 1), BLEFieldServiceData, 0x00, 0x11, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9}; retVal = advData.setAdvertisedServiceData(uuid, data, sizeof(data)); - REQUIRE(retVal); - REQUIRE( (sizeof(data) + 2 + sizeof(uuid)) == (oldRemainingLength - advData.remainingLength()) ); + THEN("Correctly set parameter") + { + REQUIRE(retVal); + REQUIRE( (sizeof(data) + 2 + sizeof(uuid)) == (oldRemainingLength - advData.remainingLength()) ); + } oldRemainingLength = advData.remainingLength(); advData.updateData(); - REQUIRE(advData.dataLength() == (sizeof(data) + 2 + sizeof(uuid))); - REQUIRE(advData.dataLength() == sizeof(goldenData)); - REQUIRE( 0 == memcmp(goldenData, advData.data(), sizeof(goldenData)) ); + THEN("Check parameter analyzing advertising raw data") + { + REQUIRE(advData.dataLength() == (sizeof(data) + 2 + sizeof(uuid))); + REQUIRE(advData.dataLength() == sizeof(goldenData)); + REQUIRE( 0 == memcmp(goldenData, advData.data(), sizeof(goldenData)) ); + } } WHEN("Set too long service data") @@ -116,7 +122,10 @@ TEST_CASE("Test service data setting", "[ArduinoBLE::BLEAdvertisingData]") const uint8_t data[] = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27}; retVal = advData.setAdvertisedServiceData(uuid, data, sizeof(data)); - REQUIRE(!retVal); + THEN("Check that the too long parameter has not been set") + { + REQUIRE(!retVal); + } REQUIRE( oldRemainingLength == advData.remainingLength() ); advData.updateData(); REQUIRE( advData.dataLength() == (MAX_AD_DATA_LENGTH - oldRemainingLength) ); @@ -127,17 +136,23 @@ TEST_CASE("Test service data setting", "[ArduinoBLE::BLEAdvertisingData]") const uint8_t data[] = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26}; retVal = advData.setAdvertisedServiceData(uuid, data, sizeof(data)); - REQUIRE(retVal); + THEN("Check correctly set parameter") + { + REQUIRE(retVal); + } advData.updateData(); // advData should be full now - REQUIRE( 0 == advData.remainingLength() ); - REQUIRE( 0 == advData.availableForWrite() ); + THEN("advData should be full now") + { + REQUIRE( 0 == advData.remainingLength() ); + REQUIRE( 0 == advData.availableForWrite() ); + } } WHEN("Check consistency when setting the external advertising data") { - auto goldenData = advData.data(); + const auto goldenData = advData.data(); BLE.setAdvertisingData(advData); BLE.advertise(); REQUIRE( 0 == memcmp(goldenData, BLE.getAdvertisingData().data(), advData.dataLength()) ); diff --git a/extras/test/src/test_uuid/test_uuid.cpp b/extras/test/src/test_uuid/test_uuid.cpp index 13b655e6..1832c741 100644 --- a/extras/test/src/test_uuid/test_uuid.cpp +++ b/extras/test/src/test_uuid/test_uuid.cpp @@ -47,6 +47,6 @@ TEST_CASE("BLE uuid test", "[ArduinoBLE::BLEUuid]") REQUIRE(verify); // print the uuid - WARN("test: " << testUuid << ", golden: " << goldenUuid); + //WARN("test: " << testUuid << ", golden: " << goldenUuid); } } \ No newline at end of file From 6fa01914ae14237c3afb1498140791e8be961e2a Mon Sep 17 00:00:00 2001 From: pennam Date: Tue, 8 Apr 2025 09:04:47 +0200 Subject: [PATCH 13/32] [CI] use codecov token --- .github/workflows/unit-tests.yml | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index b889c771..2a96b8a5 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -23,7 +23,7 @@ jobs: steps: - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v4 - uses: arduino/cpp-test-action@main with: @@ -36,10 +36,23 @@ jobs: - '/usr/*' coverage-data-path: ${{ env.COVERAGE_DATA_PATH }} + # A token is used to avoid intermittent spurious job failures caused by rate limiting. + - name: Set up Codecov upload token + run: | + if [[ "${{ github.repository }}" == "arduino-libraries/ArduinoBLE" ]]; then + # In order to avoid uploads of data from forks, only use the token for runs in the parent repo. + # Token is intentionally exposed. + # See: https://community.codecov.com/t/upload-issues-unable-to-locate-build-via-github-actions-api/3954 + CODECOV_TOKEN="8118de48-b2af-48b4-a66a-26026847bfc5" + else + # codecov/codecov-action does unauthenticated upload if empty string is passed via the `token` input. + CODECOV_TOKEN="" + fi + echo "CODECOV_TOKEN=$CODECOV_TOKEN" >> "$GITHUB_ENV" + - name: Upload coverage report to Codecov - uses: codecov/codecov-action@v1 + uses: codecov/codecov-action@v3 with: file: "${{ env.COVERAGE_DATA_PATH }}" fail_ci_if_error: true - - + token: ${{ env.CODECOV_TOKEN }} From c5bed5560455486c92f2ded02e18e8c6e72dbed4 Mon Sep 17 00:00:00 2001 From: pennam Date: Tue, 8 Apr 2025 11:36:21 +0200 Subject: [PATCH 14/32] [CI] modernize cmake build --- extras/test/.gitignore | 18 +- extras/test/CMakeLists.txt | 20 +- .../external/catch/v2.12.1/include/catch.hpp | 17698 ---------------- .../test_advertising_data.cpp | 2 +- .../test_advertising_data/test_local_name.cpp | 2 +- .../test_manufacturer.cpp | 2 +- .../test_advertising_data/test_service.cpp | 2 +- .../test_discovered_device.cpp | 2 +- extras/test/src/test_main.cpp | 2 +- extras/test/src/test_uuid/test_uuid.cpp | 2 +- 10 files changed, 42 insertions(+), 17708 deletions(-) delete mode 100644 extras/test/external/catch/v2.12.1/include/catch.hpp diff --git a/extras/test/.gitignore b/extras/test/.gitignore index c795b054..7e9215ee 100644 --- a/extras/test/.gitignore +++ b/extras/test/.gitignore @@ -1 +1,17 @@ -build \ No newline at end of file +build +### CMake ### +CMakeLists.txt.user +CMakeCache.txt +CMakeFiles +CMakeScripts +Testing +Makefile +cmake_install.cmake +install_manifest.txt +compile_commands.json +CTestTestfile.cmake +_deps + +### CMake Patch ### +# External projects +*-prefix/ \ No newline at end of file diff --git a/extras/test/CMakeLists.txt b/extras/test/CMakeLists.txt index bbba16ca..84603cd3 100644 --- a/extras/test/CMakeLists.txt +++ b/extras/test/CMakeLists.txt @@ -1,12 +1,22 @@ ########################################################################## set(CMAKE_VERBOSE_MAKEFILE ON) -cmake_minimum_required(VERSION 2.8) +cmake_minimum_required(VERSION 3.5) ########################################################################## project(testArduinoBLE) +Include(FetchContent) + +FetchContent_Declare( + Catch2 + GIT_REPOSITORY https://github.com/catchorg/Catch2.git + GIT_TAG v3.4.0 +) + +FetchContent_MakeAvailable(Catch2) + ########################################################################## set(CMAKE_CXX_STANDARD 11) @@ -35,6 +45,9 @@ set(DUT_SRCS ../../src/utility/HCI.cpp ../../src/utility/GATT.cpp ../../src/utility/L2CAPSignaling.cpp + ../../src/utility/keyDistribution.cpp + ../../src/utility/bitDescriptions.cpp + ../../src/utility/btct.cpp ../../src/local/BLELocalAttribute.cpp ../../src/local/BLELocalCharacteristic.cpp ../../src/local/BLELocalDescriptor.cpp @@ -102,7 +115,6 @@ include_directories(../../src) include_directories(../../src/local) include_directories(../../src/remote) include_directories(../../src/utility) -include_directories(external/catch/v2.12.1/include) target_include_directories(TEST_TARGET_DISC_DEVICE PUBLIC include/test_discovered_device) target_include_directories(TEST_TARGET_ADVERTISING_DATA PUBLIC include/test_advertising_data) @@ -124,3 +136,7 @@ add_custom_command(TARGET TEST_TARGET_DISC_DEVICE POST_BUILD add_custom_command(TARGET TEST_TARGET_ADVERTISING_DATA POST_BUILD COMMAND ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/TEST_TARGET_ADVERTISING_DATA ) + +target_link_libraries( TEST_TARGET_UUID Catch2WithMain ) +target_link_libraries( TEST_TARGET_DISC_DEVICE Catch2WithMain ) +target_link_libraries( TEST_TARGET_ADVERTISING_DATA Catch2WithMain ) diff --git a/extras/test/external/catch/v2.12.1/include/catch.hpp b/extras/test/external/catch/v2.12.1/include/catch.hpp deleted file mode 100644 index 1d2c9bb6..00000000 --- a/extras/test/external/catch/v2.12.1/include/catch.hpp +++ /dev/null @@ -1,17698 +0,0 @@ -/* - * Catch v2.12.1 - * Generated: 2020-04-21 19:29:20.964532 - * ---------------------------------------------------------- - * This file has been merged from multiple headers. Please don't edit it directly - * Copyright (c) 2020 Two Blue Cubes Ltd. All rights reserved. - * - * Distributed under the Boost Software License, Version 1.0. (See accompanying - * file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt) - */ -#ifndef TWOBLUECUBES_SINGLE_INCLUDE_CATCH_HPP_INCLUDED -#define TWOBLUECUBES_SINGLE_INCLUDE_CATCH_HPP_INCLUDED -// start catch.hpp - - -#define CATCH_VERSION_MAJOR 2 -#define CATCH_VERSION_MINOR 12 -#define CATCH_VERSION_PATCH 1 - -#ifdef __clang__ -# pragma clang system_header -#elif defined __GNUC__ -# pragma GCC system_header -#endif - -// start catch_suppress_warnings.h - -#ifdef __clang__ -# ifdef __ICC // icpc defines the __clang__ macro -# pragma warning(push) -# pragma warning(disable: 161 1682) -# else // __ICC -# pragma clang diagnostic push -# pragma clang diagnostic ignored "-Wpadded" -# pragma clang diagnostic ignored "-Wswitch-enum" -# pragma clang diagnostic ignored "-Wcovered-switch-default" -# endif -#elif defined __GNUC__ - // Because REQUIREs trigger GCC's -Wparentheses, and because still - // supported version of g++ have only buggy support for _Pragmas, - // Wparentheses have to be suppressed globally. -# pragma GCC diagnostic ignored "-Wparentheses" // See #674 for details - -# pragma GCC diagnostic push -# pragma GCC diagnostic ignored "-Wunused-variable" -# pragma GCC diagnostic ignored "-Wpadded" -#endif -// end catch_suppress_warnings.h -#if defined(CATCH_CONFIG_MAIN) || defined(CATCH_CONFIG_RUNNER) -# define CATCH_IMPL -# define CATCH_CONFIG_ALL_PARTS -#endif - -// In the impl file, we want to have access to all parts of the headers -// Can also be used to sanely support PCHs -#if defined(CATCH_CONFIG_ALL_PARTS) -# define CATCH_CONFIG_EXTERNAL_INTERFACES -# if defined(CATCH_CONFIG_DISABLE_MATCHERS) -# undef CATCH_CONFIG_DISABLE_MATCHERS -# endif -# if !defined(CATCH_CONFIG_ENABLE_CHRONO_STRINGMAKER) -# define CATCH_CONFIG_ENABLE_CHRONO_STRINGMAKER -# endif -#endif - -#if !defined(CATCH_CONFIG_IMPL_ONLY) -// start catch_platform.h - -#ifdef __APPLE__ -# include -# if TARGET_OS_OSX == 1 -# define CATCH_PLATFORM_MAC -# elif TARGET_OS_IPHONE == 1 -# define CATCH_PLATFORM_IPHONE -# endif - -#elif defined(linux) || defined(__linux) || defined(__linux__) -# define CATCH_PLATFORM_LINUX - -#elif defined(WIN32) || defined(__WIN32__) || defined(_WIN32) || defined(_MSC_VER) || defined(__MINGW32__) -# define CATCH_PLATFORM_WINDOWS -#endif - -// end catch_platform.h - -#ifdef CATCH_IMPL -# ifndef CLARA_CONFIG_MAIN -# define CLARA_CONFIG_MAIN_NOT_DEFINED -# define CLARA_CONFIG_MAIN -# endif -#endif - -// start catch_user_interfaces.h - -namespace Catch { - unsigned int rngSeed(); -} - -// end catch_user_interfaces.h -// start catch_tag_alias_autoregistrar.h - -// start catch_common.h - -// start catch_compiler_capabilities.h - -// Detect a number of compiler features - by compiler -// The following features are defined: -// -// CATCH_CONFIG_COUNTER : is the __COUNTER__ macro supported? -// CATCH_CONFIG_WINDOWS_SEH : is Windows SEH supported? -// CATCH_CONFIG_POSIX_SIGNALS : are POSIX signals supported? -// CATCH_CONFIG_DISABLE_EXCEPTIONS : Are exceptions enabled? -// **************** -// Note to maintainers: if new toggles are added please document them -// in configuration.md, too -// **************** - -// In general each macro has a _NO_ form -// (e.g. CATCH_CONFIG_NO_POSIX_SIGNALS) which disables the feature. -// Many features, at point of detection, define an _INTERNAL_ macro, so they -// can be combined, en-mass, with the _NO_ forms later. - -#ifdef __cplusplus - -# if (__cplusplus >= 201402L) || (defined(_MSVC_LANG) && _MSVC_LANG >= 201402L) -# define CATCH_CPP14_OR_GREATER -# endif - -# if (__cplusplus >= 201703L) || (defined(_MSVC_LANG) && _MSVC_LANG >= 201703L) -# define CATCH_CPP17_OR_GREATER -# endif - -#endif - -#if defined(__cpp_lib_uncaught_exceptions) -# define CATCH_INTERNAL_CONFIG_CPP17_UNCAUGHT_EXCEPTIONS -#endif - -// We have to avoid both ICC and Clang, because they try to mask themselves -// as gcc, and we want only GCC in this block -#if defined(__GNUC__) && !defined(__clang__) && !defined(__ICC) -# define CATCH_INTERNAL_START_WARNINGS_SUPPRESSION _Pragma( "GCC diagnostic push" ) -# define CATCH_INTERNAL_STOP_WARNINGS_SUPPRESSION _Pragma( "GCC diagnostic pop" ) - -# define CATCH_INTERNAL_IGNORE_BUT_WARN(...) (void)__builtin_constant_p(__VA_ARGS__) - -#endif - -#if defined(__clang__) - -# define CATCH_INTERNAL_START_WARNINGS_SUPPRESSION _Pragma( "clang diagnostic push" ) -# define CATCH_INTERNAL_STOP_WARNINGS_SUPPRESSION _Pragma( "clang diagnostic pop" ) - -// As of this writing, IBM XL's implementation of __builtin_constant_p has a bug -// which results in calls to destructors being emitted for each temporary, -// without a matching initialization. In practice, this can result in something -// like `std::string::~string` being called on an uninitialized value. -// -// For example, this code will likely segfault under IBM XL: -// ``` -// REQUIRE(std::string("12") + "34" == "1234") -// ``` -// -// Therefore, `CATCH_INTERNAL_IGNORE_BUT_WARN` is not implemented. -# if !defined(__ibmxl__) -# define CATCH_INTERNAL_IGNORE_BUT_WARN(...) (void)__builtin_constant_p(__VA_ARGS__) /* NOLINT(cppcoreguidelines-pro-type-vararg) */ -# endif - -# define CATCH_INTERNAL_SUPPRESS_GLOBALS_WARNINGS \ - _Pragma( "clang diagnostic ignored \"-Wexit-time-destructors\"" ) \ - _Pragma( "clang diagnostic ignored \"-Wglobal-constructors\"") - -# define CATCH_INTERNAL_SUPPRESS_PARENTHESES_WARNINGS \ - _Pragma( "clang diagnostic ignored \"-Wparentheses\"" ) - -# define CATCH_INTERNAL_SUPPRESS_UNUSED_WARNINGS \ - _Pragma( "clang diagnostic ignored \"-Wunused-variable\"" ) - -# define CATCH_INTERNAL_SUPPRESS_ZERO_VARIADIC_WARNINGS \ - _Pragma( "clang diagnostic ignored \"-Wgnu-zero-variadic-macro-arguments\"" ) - -# define CATCH_INTERNAL_SUPPRESS_UNUSED_TEMPLATE_WARNINGS \ - _Pragma( "clang diagnostic ignored \"-Wunused-template\"" ) - -#endif // __clang__ - -//////////////////////////////////////////////////////////////////////////////// -// Assume that non-Windows platforms support posix signals by default -#if !defined(CATCH_PLATFORM_WINDOWS) - #define CATCH_INTERNAL_CONFIG_POSIX_SIGNALS -#endif - -//////////////////////////////////////////////////////////////////////////////// -// We know some environments not to support full POSIX signals -#if defined(__CYGWIN__) || defined(__QNX__) || defined(__EMSCRIPTEN__) || defined(__DJGPP__) - #define CATCH_INTERNAL_CONFIG_NO_POSIX_SIGNALS -#endif - -#ifdef __OS400__ -# define CATCH_INTERNAL_CONFIG_NO_POSIX_SIGNALS -# define CATCH_CONFIG_COLOUR_NONE -#endif - -//////////////////////////////////////////////////////////////////////////////// -// Android somehow still does not support std::to_string -#if defined(__ANDROID__) -# define CATCH_INTERNAL_CONFIG_NO_CPP11_TO_STRING -# define CATCH_INTERNAL_CONFIG_ANDROID_LOGWRITE -#endif - -//////////////////////////////////////////////////////////////////////////////// -// Not all Windows environments support SEH properly -#if defined(__MINGW32__) -# define CATCH_INTERNAL_CONFIG_NO_WINDOWS_SEH -#endif - -//////////////////////////////////////////////////////////////////////////////// -// PS4 -#if defined(__ORBIS__) -# define CATCH_INTERNAL_CONFIG_NO_NEW_CAPTURE -#endif - -//////////////////////////////////////////////////////////////////////////////// -// Cygwin -#ifdef __CYGWIN__ - -// Required for some versions of Cygwin to declare gettimeofday -// see: http://stackoverflow.com/questions/36901803/gettimeofday-not-declared-in-this-scope-cygwin -# define _BSD_SOURCE -// some versions of cygwin (most) do not support std::to_string. Use the libstd check. -// https://gcc.gnu.org/onlinedocs/gcc-4.8.2/libstdc++/api/a01053_source.html line 2812-2813 -# if !((__cplusplus >= 201103L) && defined(_GLIBCXX_USE_C99) \ - && !defined(_GLIBCXX_HAVE_BROKEN_VSWPRINTF)) - -# define CATCH_INTERNAL_CONFIG_NO_CPP11_TO_STRING - -# endif -#endif // __CYGWIN__ - -//////////////////////////////////////////////////////////////////////////////// -// Visual C++ -#if defined(_MSC_VER) - -# define CATCH_INTERNAL_START_WARNINGS_SUPPRESSION __pragma( warning(push) ) -# define CATCH_INTERNAL_STOP_WARNINGS_SUPPRESSION __pragma( warning(pop) ) - -# if _MSC_VER >= 1900 // Visual Studio 2015 or newer -# define CATCH_INTERNAL_CONFIG_CPP17_UNCAUGHT_EXCEPTIONS -# endif - -// Universal Windows platform does not support SEH -// Or console colours (or console at all...) -# if defined(WINAPI_FAMILY) && (WINAPI_FAMILY == WINAPI_FAMILY_APP) -# define CATCH_CONFIG_COLOUR_NONE -# else -# define CATCH_INTERNAL_CONFIG_WINDOWS_SEH -# endif - -// MSVC traditional preprocessor needs some workaround for __VA_ARGS__ -// _MSVC_TRADITIONAL == 0 means new conformant preprocessor -// _MSVC_TRADITIONAL == 1 means old traditional non-conformant preprocessor -# if !defined(__clang__) // Handle Clang masquerading for msvc -# if !defined(_MSVC_TRADITIONAL) || (defined(_MSVC_TRADITIONAL) && _MSVC_TRADITIONAL) -# define CATCH_INTERNAL_CONFIG_TRADITIONAL_MSVC_PREPROCESSOR -# endif // MSVC_TRADITIONAL -# endif // __clang__ - -#endif // _MSC_VER - -#if defined(_REENTRANT) || defined(_MSC_VER) -// Enable async processing, as -pthread is specified or no additional linking is required -# define CATCH_INTERNAL_CONFIG_USE_ASYNC -#endif // _MSC_VER - -//////////////////////////////////////////////////////////////////////////////// -// Check if we are compiled with -fno-exceptions or equivalent -#if defined(__EXCEPTIONS) || defined(__cpp_exceptions) || defined(_CPPUNWIND) -# define CATCH_INTERNAL_CONFIG_EXCEPTIONS_ENABLED -#endif - -//////////////////////////////////////////////////////////////////////////////// -// DJGPP -#ifdef __DJGPP__ -# define CATCH_INTERNAL_CONFIG_NO_WCHAR -#endif // __DJGPP__ - -//////////////////////////////////////////////////////////////////////////////// -// Embarcadero C++Build -#if defined(__BORLANDC__) - #define CATCH_INTERNAL_CONFIG_POLYFILL_ISNAN -#endif - -//////////////////////////////////////////////////////////////////////////////// - -// Use of __COUNTER__ is suppressed during code analysis in -// CLion/AppCode 2017.2.x and former, because __COUNTER__ is not properly -// handled by it. -// Otherwise all supported compilers support COUNTER macro, -// but user still might want to turn it off -#if ( !defined(__JETBRAINS_IDE__) || __JETBRAINS_IDE__ >= 20170300L ) - #define CATCH_INTERNAL_CONFIG_COUNTER -#endif - -//////////////////////////////////////////////////////////////////////////////// - -// RTX is a special version of Windows that is real time. -// This means that it is detected as Windows, but does not provide -// the same set of capabilities as real Windows does. -#if defined(UNDER_RTSS) || defined(RTX64_BUILD) - #define CATCH_INTERNAL_CONFIG_NO_WINDOWS_SEH - #define CATCH_INTERNAL_CONFIG_NO_ASYNC - #define CATCH_CONFIG_COLOUR_NONE -#endif - -#if !defined(_GLIBCXX_USE_C99_MATH_TR1) -#define CATCH_INTERNAL_CONFIG_GLOBAL_NEXTAFTER -#endif - -// Various stdlib support checks that require __has_include -#if defined(__has_include) - // Check if string_view is available and usable - #if __has_include() && defined(CATCH_CPP17_OR_GREATER) - # define CATCH_INTERNAL_CONFIG_CPP17_STRING_VIEW - #endif - - // Check if optional is available and usable - # if __has_include() && defined(CATCH_CPP17_OR_GREATER) - # define CATCH_INTERNAL_CONFIG_CPP17_OPTIONAL - # endif // __has_include() && defined(CATCH_CPP17_OR_GREATER) - - // Check if byte is available and usable - # if __has_include() && defined(CATCH_CPP17_OR_GREATER) - # define CATCH_INTERNAL_CONFIG_CPP17_BYTE - # endif // __has_include() && defined(CATCH_CPP17_OR_GREATER) - - // Check if variant is available and usable - # if __has_include() && defined(CATCH_CPP17_OR_GREATER) - # if defined(__clang__) && (__clang_major__ < 8) - // work around clang bug with libstdc++ https://bugs.llvm.org/show_bug.cgi?id=31852 - // fix should be in clang 8, workaround in libstdc++ 8.2 - # include - # if defined(__GLIBCXX__) && defined(_GLIBCXX_RELEASE) && (_GLIBCXX_RELEASE < 9) - # define CATCH_CONFIG_NO_CPP17_VARIANT - # else - # define CATCH_INTERNAL_CONFIG_CPP17_VARIANT - # endif // defined(__GLIBCXX__) && defined(_GLIBCXX_RELEASE) && (_GLIBCXX_RELEASE < 9) - # else - # define CATCH_INTERNAL_CONFIG_CPP17_VARIANT - # endif // defined(__clang__) && (__clang_major__ < 8) - # endif // __has_include() && defined(CATCH_CPP17_OR_GREATER) -#endif // defined(__has_include) - -#if defined(CATCH_INTERNAL_CONFIG_COUNTER) && !defined(CATCH_CONFIG_NO_COUNTER) && !defined(CATCH_CONFIG_COUNTER) -# define CATCH_CONFIG_COUNTER -#endif -#if defined(CATCH_INTERNAL_CONFIG_WINDOWS_SEH) && !defined(CATCH_CONFIG_NO_WINDOWS_SEH) && !defined(CATCH_CONFIG_WINDOWS_SEH) && !defined(CATCH_INTERNAL_CONFIG_NO_WINDOWS_SEH) -# define CATCH_CONFIG_WINDOWS_SEH -#endif -// This is set by default, because we assume that unix compilers are posix-signal-compatible by default. -#if defined(CATCH_INTERNAL_CONFIG_POSIX_SIGNALS) && !defined(CATCH_INTERNAL_CONFIG_NO_POSIX_SIGNALS) && !defined(CATCH_CONFIG_NO_POSIX_SIGNALS) && !defined(CATCH_CONFIG_POSIX_SIGNALS) -# define CATCH_CONFIG_POSIX_SIGNALS -#endif -// This is set by default, because we assume that compilers with no wchar_t support are just rare exceptions. -#if !defined(CATCH_INTERNAL_CONFIG_NO_WCHAR) && !defined(CATCH_CONFIG_NO_WCHAR) && !defined(CATCH_CONFIG_WCHAR) -# define CATCH_CONFIG_WCHAR -#endif - -#if !defined(CATCH_INTERNAL_CONFIG_NO_CPP11_TO_STRING) && !defined(CATCH_CONFIG_NO_CPP11_TO_STRING) && !defined(CATCH_CONFIG_CPP11_TO_STRING) -# define CATCH_CONFIG_CPP11_TO_STRING -#endif - -#if defined(CATCH_INTERNAL_CONFIG_CPP17_OPTIONAL) && !defined(CATCH_CONFIG_NO_CPP17_OPTIONAL) && !defined(CATCH_CONFIG_CPP17_OPTIONAL) -# define CATCH_CONFIG_CPP17_OPTIONAL -#endif - -#if defined(CATCH_INTERNAL_CONFIG_CPP17_UNCAUGHT_EXCEPTIONS) && !defined(CATCH_CONFIG_NO_CPP17_UNCAUGHT_EXCEPTIONS) && !defined(CATCH_CONFIG_CPP17_UNCAUGHT_EXCEPTIONS) -# define CATCH_CONFIG_CPP17_UNCAUGHT_EXCEPTIONS -#endif - -#if defined(CATCH_INTERNAL_CONFIG_CPP17_STRING_VIEW) && !defined(CATCH_CONFIG_NO_CPP17_STRING_VIEW) && !defined(CATCH_CONFIG_CPP17_STRING_VIEW) -# define CATCH_CONFIG_CPP17_STRING_VIEW -#endif - -#if defined(CATCH_INTERNAL_CONFIG_CPP17_VARIANT) && !defined(CATCH_CONFIG_NO_CPP17_VARIANT) && !defined(CATCH_CONFIG_CPP17_VARIANT) -# define CATCH_CONFIG_CPP17_VARIANT -#endif - -#if defined(CATCH_INTERNAL_CONFIG_CPP17_BYTE) && !defined(CATCH_CONFIG_NO_CPP17_BYTE) && !defined(CATCH_CONFIG_CPP17_BYTE) -# define CATCH_CONFIG_CPP17_BYTE -#endif - -#if defined(CATCH_CONFIG_EXPERIMENTAL_REDIRECT) -# define CATCH_INTERNAL_CONFIG_NEW_CAPTURE -#endif - -#if defined(CATCH_INTERNAL_CONFIG_NEW_CAPTURE) && !defined(CATCH_INTERNAL_CONFIG_NO_NEW_CAPTURE) && !defined(CATCH_CONFIG_NO_NEW_CAPTURE) && !defined(CATCH_CONFIG_NEW_CAPTURE) -# define CATCH_CONFIG_NEW_CAPTURE -#endif - -#if !defined(CATCH_INTERNAL_CONFIG_EXCEPTIONS_ENABLED) && !defined(CATCH_CONFIG_DISABLE_EXCEPTIONS) -# define CATCH_CONFIG_DISABLE_EXCEPTIONS -#endif - -#if defined(CATCH_INTERNAL_CONFIG_POLYFILL_ISNAN) && !defined(CATCH_CONFIG_NO_POLYFILL_ISNAN) && !defined(CATCH_CONFIG_POLYFILL_ISNAN) -# define CATCH_CONFIG_POLYFILL_ISNAN -#endif - -#if defined(CATCH_INTERNAL_CONFIG_USE_ASYNC) && !defined(CATCH_INTERNAL_CONFIG_NO_ASYNC) && !defined(CATCH_CONFIG_NO_USE_ASYNC) && !defined(CATCH_CONFIG_USE_ASYNC) -# define CATCH_CONFIG_USE_ASYNC -#endif - -#if defined(CATCH_INTERNAL_CONFIG_ANDROID_LOGWRITE) && !defined(CATCH_CONFIG_NO_ANDROID_LOGWRITE) && !defined(CATCH_CONFIG_ANDROID_LOGWRITE) -# define CATCH_CONFIG_ANDROID_LOGWRITE -#endif - -#if defined(CATCH_INTERNAL_CONFIG_GLOBAL_NEXTAFTER) && !defined(CATCH_CONFIG_NO_GLOBAL_NEXTAFTER) && !defined(CATCH_CONFIG_GLOBAL_NEXTAFTER) -# define CATCH_CONFIG_GLOBAL_NEXTAFTER -#endif - -// Even if we do not think the compiler has that warning, we still have -// to provide a macro that can be used by the code. -#if !defined(CATCH_INTERNAL_START_WARNINGS_SUPPRESSION) -# define CATCH_INTERNAL_START_WARNINGS_SUPPRESSION -#endif -#if !defined(CATCH_INTERNAL_STOP_WARNINGS_SUPPRESSION) -# define CATCH_INTERNAL_STOP_WARNINGS_SUPPRESSION -#endif -#if !defined(CATCH_INTERNAL_SUPPRESS_PARENTHESES_WARNINGS) -# define CATCH_INTERNAL_SUPPRESS_PARENTHESES_WARNINGS -#endif -#if !defined(CATCH_INTERNAL_SUPPRESS_GLOBALS_WARNINGS) -# define CATCH_INTERNAL_SUPPRESS_GLOBALS_WARNINGS -#endif -#if !defined(CATCH_INTERNAL_SUPPRESS_UNUSED_WARNINGS) -# define CATCH_INTERNAL_SUPPRESS_UNUSED_WARNINGS -#endif -#if !defined(CATCH_INTERNAL_SUPPRESS_ZERO_VARIADIC_WARNINGS) -# define CATCH_INTERNAL_SUPPRESS_ZERO_VARIADIC_WARNINGS -#endif - -// The goal of this macro is to avoid evaluation of the arguments, but -// still have the compiler warn on problems inside... -#if !defined(CATCH_INTERNAL_IGNORE_BUT_WARN) -# define CATCH_INTERNAL_IGNORE_BUT_WARN(...) -#endif - -#if defined(__APPLE__) && defined(__apple_build_version__) && (__clang_major__ < 10) -# undef CATCH_INTERNAL_SUPPRESS_UNUSED_TEMPLATE_WARNINGS -#elif defined(__clang__) && (__clang_major__ < 5) -# undef CATCH_INTERNAL_SUPPRESS_UNUSED_TEMPLATE_WARNINGS -#endif - -#if !defined(CATCH_INTERNAL_SUPPRESS_UNUSED_TEMPLATE_WARNINGS) -# define CATCH_INTERNAL_SUPPRESS_UNUSED_TEMPLATE_WARNINGS -#endif - -#if defined(CATCH_CONFIG_DISABLE_EXCEPTIONS) -#define CATCH_TRY if ((true)) -#define CATCH_CATCH_ALL if ((false)) -#define CATCH_CATCH_ANON(type) if ((false)) -#else -#define CATCH_TRY try -#define CATCH_CATCH_ALL catch (...) -#define CATCH_CATCH_ANON(type) catch (type) -#endif - -#if defined(CATCH_INTERNAL_CONFIG_TRADITIONAL_MSVC_PREPROCESSOR) && !defined(CATCH_CONFIG_NO_TRADITIONAL_MSVC_PREPROCESSOR) && !defined(CATCH_CONFIG_TRADITIONAL_MSVC_PREPROCESSOR) -#define CATCH_CONFIG_TRADITIONAL_MSVC_PREPROCESSOR -#endif - -// end catch_compiler_capabilities.h -#define INTERNAL_CATCH_UNIQUE_NAME_LINE2( name, line ) name##line -#define INTERNAL_CATCH_UNIQUE_NAME_LINE( name, line ) INTERNAL_CATCH_UNIQUE_NAME_LINE2( name, line ) -#ifdef CATCH_CONFIG_COUNTER -# define INTERNAL_CATCH_UNIQUE_NAME( name ) INTERNAL_CATCH_UNIQUE_NAME_LINE( name, __COUNTER__ ) -#else -# define INTERNAL_CATCH_UNIQUE_NAME( name ) INTERNAL_CATCH_UNIQUE_NAME_LINE( name, __LINE__ ) -#endif - -#include -#include -#include - -// We need a dummy global operator<< so we can bring it into Catch namespace later -struct Catch_global_namespace_dummy {}; -std::ostream& operator<<(std::ostream&, Catch_global_namespace_dummy); - -namespace Catch { - - struct CaseSensitive { enum Choice { - Yes, - No - }; }; - - class NonCopyable { - NonCopyable( NonCopyable const& ) = delete; - NonCopyable( NonCopyable && ) = delete; - NonCopyable& operator = ( NonCopyable const& ) = delete; - NonCopyable& operator = ( NonCopyable && ) = delete; - - protected: - NonCopyable(); - virtual ~NonCopyable(); - }; - - struct SourceLineInfo { - - SourceLineInfo() = delete; - SourceLineInfo( char const* _file, std::size_t _line ) noexcept - : file( _file ), - line( _line ) - {} - - SourceLineInfo( SourceLineInfo const& other ) = default; - SourceLineInfo& operator = ( SourceLineInfo const& ) = default; - SourceLineInfo( SourceLineInfo&& ) noexcept = default; - SourceLineInfo& operator = ( SourceLineInfo&& ) noexcept = default; - - bool empty() const noexcept { return file[0] == '\0'; } - bool operator == ( SourceLineInfo const& other ) const noexcept; - bool operator < ( SourceLineInfo const& other ) const noexcept; - - char const* file; - std::size_t line; - }; - - std::ostream& operator << ( std::ostream& os, SourceLineInfo const& info ); - - // Bring in operator<< from global namespace into Catch namespace - // This is necessary because the overload of operator<< above makes - // lookup stop at namespace Catch - using ::operator<<; - - // Use this in variadic streaming macros to allow - // >> +StreamEndStop - // as well as - // >> stuff +StreamEndStop - struct StreamEndStop { - std::string operator+() const; - }; - template - T const& operator + ( T const& value, StreamEndStop ) { - return value; - } -} - -#define CATCH_INTERNAL_LINEINFO \ - ::Catch::SourceLineInfo( __FILE__, static_cast( __LINE__ ) ) - -// end catch_common.h -namespace Catch { - - struct RegistrarForTagAliases { - RegistrarForTagAliases( char const* alias, char const* tag, SourceLineInfo const& lineInfo ); - }; - -} // end namespace Catch - -#define CATCH_REGISTER_TAG_ALIAS( alias, spec ) \ - CATCH_INTERNAL_START_WARNINGS_SUPPRESSION \ - CATCH_INTERNAL_SUPPRESS_GLOBALS_WARNINGS \ - namespace{ Catch::RegistrarForTagAliases INTERNAL_CATCH_UNIQUE_NAME( AutoRegisterTagAlias )( alias, spec, CATCH_INTERNAL_LINEINFO ); } \ - CATCH_INTERNAL_STOP_WARNINGS_SUPPRESSION - -// end catch_tag_alias_autoregistrar.h -// start catch_test_registry.h - -// start catch_interfaces_testcase.h - -#include - -namespace Catch { - - class TestSpec; - - struct ITestInvoker { - virtual void invoke () const = 0; - virtual ~ITestInvoker(); - }; - - class TestCase; - struct IConfig; - - struct ITestCaseRegistry { - virtual ~ITestCaseRegistry(); - virtual std::vector const& getAllTests() const = 0; - virtual std::vector const& getAllTestsSorted( IConfig const& config ) const = 0; - }; - - bool isThrowSafe( TestCase const& testCase, IConfig const& config ); - bool matchTest( TestCase const& testCase, TestSpec const& testSpec, IConfig const& config ); - std::vector filterTests( std::vector const& testCases, TestSpec const& testSpec, IConfig const& config ); - std::vector const& getAllTestCasesSorted( IConfig const& config ); - -} - -// end catch_interfaces_testcase.h -// start catch_stringref.h - -#include -#include -#include -#include - -namespace Catch { - - /// A non-owning string class (similar to the forthcoming std::string_view) - /// Note that, because a StringRef may be a substring of another string, - /// it may not be null terminated. - class StringRef { - public: - using size_type = std::size_t; - using const_iterator = const char*; - - private: - static constexpr char const* const s_empty = ""; - - char const* m_start = s_empty; - size_type m_size = 0; - - public: // construction - constexpr StringRef() noexcept = default; - - StringRef( char const* rawChars ) noexcept; - - constexpr StringRef( char const* rawChars, size_type size ) noexcept - : m_start( rawChars ), - m_size( size ) - {} - - StringRef( std::string const& stdString ) noexcept - : m_start( stdString.c_str() ), - m_size( stdString.size() ) - {} - - explicit operator std::string() const { - return std::string(m_start, m_size); - } - - public: // operators - auto operator == ( StringRef const& other ) const noexcept -> bool; - auto operator != (StringRef const& other) const noexcept -> bool { - return !(*this == other); - } - - auto operator[] ( size_type index ) const noexcept -> char { - assert(index < m_size); - return m_start[index]; - } - - public: // named queries - constexpr auto empty() const noexcept -> bool { - return m_size == 0; - } - constexpr auto size() const noexcept -> size_type { - return m_size; - } - - // Returns the current start pointer. If the StringRef is not - // null-terminated, throws std::domain_exception - auto c_str() const -> char const*; - - public: // substrings and searches - // Returns a substring of [start, start + length). - // If start + length > size(), then the substring is [start, size()). - // If start > size(), then the substring is empty. - auto substr( size_type start, size_type length ) const noexcept -> StringRef; - - // Returns the current start pointer. May not be null-terminated. - auto data() const noexcept -> char const*; - - constexpr auto isNullTerminated() const noexcept -> bool { - return m_start[m_size] == '\0'; - } - - public: // iterators - constexpr const_iterator begin() const { return m_start; } - constexpr const_iterator end() const { return m_start + m_size; } - }; - - auto operator += ( std::string& lhs, StringRef const& sr ) -> std::string&; - auto operator << ( std::ostream& os, StringRef const& sr ) -> std::ostream&; - - constexpr auto operator "" _sr( char const* rawChars, std::size_t size ) noexcept -> StringRef { - return StringRef( rawChars, size ); - } -} // namespace Catch - -constexpr auto operator "" _catch_sr( char const* rawChars, std::size_t size ) noexcept -> Catch::StringRef { - return Catch::StringRef( rawChars, size ); -} - -// end catch_stringref.h -// start catch_preprocessor.hpp - - -#define CATCH_RECURSION_LEVEL0(...) __VA_ARGS__ -#define CATCH_RECURSION_LEVEL1(...) CATCH_RECURSION_LEVEL0(CATCH_RECURSION_LEVEL0(CATCH_RECURSION_LEVEL0(__VA_ARGS__))) -#define CATCH_RECURSION_LEVEL2(...) CATCH_RECURSION_LEVEL1(CATCH_RECURSION_LEVEL1(CATCH_RECURSION_LEVEL1(__VA_ARGS__))) -#define CATCH_RECURSION_LEVEL3(...) CATCH_RECURSION_LEVEL2(CATCH_RECURSION_LEVEL2(CATCH_RECURSION_LEVEL2(__VA_ARGS__))) -#define CATCH_RECURSION_LEVEL4(...) CATCH_RECURSION_LEVEL3(CATCH_RECURSION_LEVEL3(CATCH_RECURSION_LEVEL3(__VA_ARGS__))) -#define CATCH_RECURSION_LEVEL5(...) CATCH_RECURSION_LEVEL4(CATCH_RECURSION_LEVEL4(CATCH_RECURSION_LEVEL4(__VA_ARGS__))) - -#ifdef CATCH_CONFIG_TRADITIONAL_MSVC_PREPROCESSOR -#define INTERNAL_CATCH_EXPAND_VARGS(...) __VA_ARGS__ -// MSVC needs more evaluations -#define CATCH_RECURSION_LEVEL6(...) CATCH_RECURSION_LEVEL5(CATCH_RECURSION_LEVEL5(CATCH_RECURSION_LEVEL5(__VA_ARGS__))) -#define CATCH_RECURSE(...) CATCH_RECURSION_LEVEL6(CATCH_RECURSION_LEVEL6(__VA_ARGS__)) -#else -#define CATCH_RECURSE(...) CATCH_RECURSION_LEVEL5(__VA_ARGS__) -#endif - -#define CATCH_REC_END(...) -#define CATCH_REC_OUT - -#define CATCH_EMPTY() -#define CATCH_DEFER(id) id CATCH_EMPTY() - -#define CATCH_REC_GET_END2() 0, CATCH_REC_END -#define CATCH_REC_GET_END1(...) CATCH_REC_GET_END2 -#define CATCH_REC_GET_END(...) CATCH_REC_GET_END1 -#define CATCH_REC_NEXT0(test, next, ...) next CATCH_REC_OUT -#define CATCH_REC_NEXT1(test, next) CATCH_DEFER ( CATCH_REC_NEXT0 ) ( test, next, 0) -#define CATCH_REC_NEXT(test, next) CATCH_REC_NEXT1(CATCH_REC_GET_END test, next) - -#define CATCH_REC_LIST0(f, x, peek, ...) , f(x) CATCH_DEFER ( CATCH_REC_NEXT(peek, CATCH_REC_LIST1) ) ( f, peek, __VA_ARGS__ ) -#define CATCH_REC_LIST1(f, x, peek, ...) , f(x) CATCH_DEFER ( CATCH_REC_NEXT(peek, CATCH_REC_LIST0) ) ( f, peek, __VA_ARGS__ ) -#define CATCH_REC_LIST2(f, x, peek, ...) f(x) CATCH_DEFER ( CATCH_REC_NEXT(peek, CATCH_REC_LIST1) ) ( f, peek, __VA_ARGS__ ) - -#define CATCH_REC_LIST0_UD(f, userdata, x, peek, ...) , f(userdata, x) CATCH_DEFER ( CATCH_REC_NEXT(peek, CATCH_REC_LIST1_UD) ) ( f, userdata, peek, __VA_ARGS__ ) -#define CATCH_REC_LIST1_UD(f, userdata, x, peek, ...) , f(userdata, x) CATCH_DEFER ( CATCH_REC_NEXT(peek, CATCH_REC_LIST0_UD) ) ( f, userdata, peek, __VA_ARGS__ ) -#define CATCH_REC_LIST2_UD(f, userdata, x, peek, ...) f(userdata, x) CATCH_DEFER ( CATCH_REC_NEXT(peek, CATCH_REC_LIST1_UD) ) ( f, userdata, peek, __VA_ARGS__ ) - -// Applies the function macro `f` to each of the remaining parameters, inserts commas between the results, -// and passes userdata as the first parameter to each invocation, -// e.g. CATCH_REC_LIST_UD(f, x, a, b, c) evaluates to f(x, a), f(x, b), f(x, c) -#define CATCH_REC_LIST_UD(f, userdata, ...) CATCH_RECURSE(CATCH_REC_LIST2_UD(f, userdata, __VA_ARGS__, ()()(), ()()(), ()()(), 0)) - -#define CATCH_REC_LIST(f, ...) CATCH_RECURSE(CATCH_REC_LIST2(f, __VA_ARGS__, ()()(), ()()(), ()()(), 0)) - -#define INTERNAL_CATCH_EXPAND1(param) INTERNAL_CATCH_EXPAND2(param) -#define INTERNAL_CATCH_EXPAND2(...) INTERNAL_CATCH_NO## __VA_ARGS__ -#define INTERNAL_CATCH_DEF(...) INTERNAL_CATCH_DEF __VA_ARGS__ -#define INTERNAL_CATCH_NOINTERNAL_CATCH_DEF -#define INTERNAL_CATCH_STRINGIZE(...) INTERNAL_CATCH_STRINGIZE2(__VA_ARGS__) -#ifndef CATCH_CONFIG_TRADITIONAL_MSVC_PREPROCESSOR -#define INTERNAL_CATCH_STRINGIZE2(...) #__VA_ARGS__ -#define INTERNAL_CATCH_STRINGIZE_WITHOUT_PARENS(param) INTERNAL_CATCH_STRINGIZE(INTERNAL_CATCH_REMOVE_PARENS(param)) -#else -// MSVC is adding extra space and needs another indirection to expand INTERNAL_CATCH_NOINTERNAL_CATCH_DEF -#define INTERNAL_CATCH_STRINGIZE2(...) INTERNAL_CATCH_STRINGIZE3(__VA_ARGS__) -#define INTERNAL_CATCH_STRINGIZE3(...) #__VA_ARGS__ -#define INTERNAL_CATCH_STRINGIZE_WITHOUT_PARENS(param) (INTERNAL_CATCH_STRINGIZE(INTERNAL_CATCH_REMOVE_PARENS(param)) + 1) -#endif - -#define INTERNAL_CATCH_MAKE_NAMESPACE2(...) ns_##__VA_ARGS__ -#define INTERNAL_CATCH_MAKE_NAMESPACE(name) INTERNAL_CATCH_MAKE_NAMESPACE2(name) - -#define INTERNAL_CATCH_REMOVE_PARENS(...) INTERNAL_CATCH_EXPAND1(INTERNAL_CATCH_DEF __VA_ARGS__) - -#ifndef CATCH_CONFIG_TRADITIONAL_MSVC_PREPROCESSOR -#define INTERNAL_CATCH_MAKE_TYPE_LIST2(...) decltype(get_wrapper()) -#define INTERNAL_CATCH_MAKE_TYPE_LIST(...) INTERNAL_CATCH_MAKE_TYPE_LIST2(INTERNAL_CATCH_REMOVE_PARENS(__VA_ARGS__)) -#else -#define INTERNAL_CATCH_MAKE_TYPE_LIST2(...) INTERNAL_CATCH_EXPAND_VARGS(decltype(get_wrapper())) -#define INTERNAL_CATCH_MAKE_TYPE_LIST(...) INTERNAL_CATCH_EXPAND_VARGS(INTERNAL_CATCH_MAKE_TYPE_LIST2(INTERNAL_CATCH_REMOVE_PARENS(__VA_ARGS__))) -#endif - -#define INTERNAL_CATCH_MAKE_TYPE_LISTS_FROM_TYPES(...)\ - CATCH_REC_LIST(INTERNAL_CATCH_MAKE_TYPE_LIST,__VA_ARGS__) - -#define INTERNAL_CATCH_REMOVE_PARENS_1_ARG(_0) INTERNAL_CATCH_REMOVE_PARENS(_0) -#define INTERNAL_CATCH_REMOVE_PARENS_2_ARG(_0, _1) INTERNAL_CATCH_REMOVE_PARENS(_0), INTERNAL_CATCH_REMOVE_PARENS_1_ARG(_1) -#define INTERNAL_CATCH_REMOVE_PARENS_3_ARG(_0, _1, _2) INTERNAL_CATCH_REMOVE_PARENS(_0), INTERNAL_CATCH_REMOVE_PARENS_2_ARG(_1, _2) -#define INTERNAL_CATCH_REMOVE_PARENS_4_ARG(_0, _1, _2, _3) INTERNAL_CATCH_REMOVE_PARENS(_0), INTERNAL_CATCH_REMOVE_PARENS_3_ARG(_1, _2, _3) -#define INTERNAL_CATCH_REMOVE_PARENS_5_ARG(_0, _1, _2, _3, _4) INTERNAL_CATCH_REMOVE_PARENS(_0), INTERNAL_CATCH_REMOVE_PARENS_4_ARG(_1, _2, _3, _4) -#define INTERNAL_CATCH_REMOVE_PARENS_6_ARG(_0, _1, _2, _3, _4, _5) INTERNAL_CATCH_REMOVE_PARENS(_0), INTERNAL_CATCH_REMOVE_PARENS_5_ARG(_1, _2, _3, _4, _5) -#define INTERNAL_CATCH_REMOVE_PARENS_7_ARG(_0, _1, _2, _3, _4, _5, _6) INTERNAL_CATCH_REMOVE_PARENS(_0), INTERNAL_CATCH_REMOVE_PARENS_6_ARG(_1, _2, _4, _5, _6) -#define INTERNAL_CATCH_REMOVE_PARENS_8_ARG(_0, _1, _2, _3, _4, _5, _6, _7) INTERNAL_CATCH_REMOVE_PARENS(_0), INTERNAL_CATCH_REMOVE_PARENS_7_ARG(_1, _2, _3, _4, _5, _6, _7) -#define INTERNAL_CATCH_REMOVE_PARENS_9_ARG(_0, _1, _2, _3, _4, _5, _6, _7, _8) INTERNAL_CATCH_REMOVE_PARENS(_0), INTERNAL_CATCH_REMOVE_PARENS_8_ARG(_1, _2, _3, _4, _5, _6, _7, _8) -#define INTERNAL_CATCH_REMOVE_PARENS_10_ARG(_0, _1, _2, _3, _4, _5, _6, _7, _8, _9) INTERNAL_CATCH_REMOVE_PARENS(_0), INTERNAL_CATCH_REMOVE_PARENS_9_ARG(_1, _2, _3, _4, _5, _6, _7, _8, _9) -#define INTERNAL_CATCH_REMOVE_PARENS_11_ARG(_0, _1, _2, _3, _4, _5, _6, _7, _8, _9, _10) INTERNAL_CATCH_REMOVE_PARENS(_0), INTERNAL_CATCH_REMOVE_PARENS_10_ARG(_1, _2, _3, _4, _5, _6, _7, _8, _9, _10) - -#define INTERNAL_CATCH_VA_NARGS_IMPL(_0, _1, _2, _3, _4, _5, _6, _7, _8, _9, _10, N, ...) N - -#define INTERNAL_CATCH_TYPE_GEN\ - template struct TypeList {};\ - template\ - constexpr auto get_wrapper() noexcept -> TypeList { return {}; }\ - template class...> struct TemplateTypeList{};\ - template class...Cs>\ - constexpr auto get_wrapper() noexcept -> TemplateTypeList { return {}; }\ - template\ - struct append;\ - template\ - struct rewrap;\ - template class, typename...>\ - struct create;\ - template class, typename>\ - struct convert;\ - \ - template \ - struct append { using type = T; };\ - template< template class L1, typename...E1, template class L2, typename...E2, typename...Rest>\ - struct append, L2, Rest...> { using type = typename append, Rest...>::type; };\ - template< template class L1, typename...E1, typename...Rest>\ - struct append, TypeList, Rest...> { using type = L1; };\ - \ - template< template class Container, template class List, typename...elems>\ - struct rewrap, List> { using type = TypeList>; };\ - template< template class Container, template class List, class...Elems, typename...Elements>\ - struct rewrap, List, Elements...> { using type = typename append>, typename rewrap, Elements...>::type>::type; };\ - \ - template