Skip to content

Ensure that begin() is not called multiple times. #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2023
Merged

Ensure that begin() is not called multiple times. #28

merged 1 commit into from
Mar 7, 2023

Conversation

iabdalkader
Copy link
Collaborator

No description provided.

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Memory usage change @ ffaa7a1

Board flash % RAM for global variables %
arduino:mbed_giga:giga 🔺 0 - +64 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Advanced/ADC_Multi
flash		 % examples/Advanced/ADC_Multi
RAM for global variables		 % examples/Advanced/ADC_Multi_Channel
flash		 % examples/Advanced/ADC_Multi_Channel
RAM for global variables		 % examples/Advanced/ADC_Multi_To_DAC
flash		 % examples/Advanced/ADC_Multi_To_DAC
RAM for global variables		 % examples/Advanced/ADC_Serial_Plotter
flash		 % examples/Advanced/ADC_Serial_Plotter
RAM for global variables		 % examples/Advanced/ADC_To_DAC
flash		 % examples/Advanced/ADC_To_DAC
RAM for global variables		 % examples/Advanced/DAC_One_Channel
flash		 % examples/Advanced/DAC_One_Channel
RAM for global variables		 % examples/Advanced/DAC_Sine_wave
flash		 % examples/Advanced/DAC_Sine_wave
RAM for global variables		 % examples/Advanced/DAC_Two_Channels
flash		 % examples/Advanced/DAC_Two_Channels
RAM for global variables		 % examples/Beginner/Audio_Playback
flash		 % examples/Beginner/Audio_Playback
RAM for global variables		 % examples/Beginner/Waveform_Generator
flash		 % examples/Beginner/Waveform_Generator
RAM for global variables		 %
arduino:mbed_giga:giga 0 0.0 0 0.0 64 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 64 0.0 0 0.0
Click for full report CSV 
Board,examples/Advanced/ADC_Multi<br>flash,%,examples/Advanced/ADC_Multi<br>RAM for global variables,%,examples/Advanced/ADC_Multi_Channel<br>flash,%,examples/Advanced/ADC_Multi_Channel<br>RAM for global variables,%,examples/Advanced/ADC_Multi_To_DAC<br>flash,%,examples/Advanced/ADC_Multi_To_DAC<br>RAM for global variables,%,examples/Advanced/ADC_Serial_Plotter<br>flash,%,examples/Advanced/ADC_Serial_Plotter<br>RAM for global variables,%,examples/Advanced/ADC_To_DAC<br>flash,%,examples/Advanced/ADC_To_DAC<br>RAM for global variables,%,examples/Advanced/DAC_One_Channel<br>flash,%,examples/Advanced/DAC_One_Channel<br>RAM for global variables,%,examples/Advanced/DAC_Sine_wave<br>flash,%,examples/Advanced/DAC_Sine_wave<br>RAM for global variables,%,examples/Advanced/DAC_Two_Channels<br>flash,%,examples/Advanced/DAC_Two_Channels<br>RAM for global variables,%,examples/Beginner/Audio_Playback<br>flash,%,examples/Beginner/Audio_Playback<br>RAM for global variables,%,examples/Beginner/Waveform_Generator<br>flash,%,examples/Beginner/Waveform_Generator<br>RAM for global variables,%
arduino:mbed_giga:giga,0,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,64,0.0,0,0.0

@per1234 per1234 added the topic: code Related to content of the project itself label Mar 6, 2023
aentinger
aentinger suggested changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please encapsulate descr && descr->pool within a function to check initialisation status and then this PR can be merged 👍 .

@aentinger aentinger self-requested a review March 6, 2023 09:40
@iabdalkader iabdalkader merged commit 972a386 into main Mar 7, 2023
@iabdalkader iabdalkader deleted the begin_stop_fix branch March 7, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aentinger aentinger aentinger approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iabdalkader @CLAassistant @aentinger @per1234