Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add basic support for git tag path prefixes #20948

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: Add basic support for git tag path prefixes #20948

wants to merge 3 commits into from
+162 −4

Conversation

chzar
Copy link

@chzar chzar commented Nov 25, 2024 •
edited
Loading

TL;DR This PR changes the resolveSemverRevision() function to tolerate a path prefix before the semantic version.

# example
targetRevision: '>=foo/bar/v0.0.0-rc0'

This change is useful for teams that:

  • want to use hierarchical tags - useful for monorepos (app1/v0.0.0, app2/v1.0.0)
  • want to use a hierarchical namespace to route argo deployments using generators (app1/cluster1/prod/v0.0.0, app1/cluster2/dev/v0.0.0)
  • use git flow or other tag based workflows with path prefixes

Closes #20949

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Nov 25, 2024 •
edited
Loading

❗ Preview Environment stop on Bunnyshell failed

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop again the environment
  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to remove the environment

@chzar chzar changed the title feat: Add basic support for tag path prefixes feat: Add basic support for git tag path prefixes Nov 25, 2024
@chzar

This comment has been minimized.

Sign in to view
@chzar chzar mentioned this pull request Nov 25, 2024
Open
@chzar chzar marked this pull request as ready for review November 25, 2024 21:29
@chzar chzar requested a review from a team as a code owner November 25, 2024 21:29
@chzar
Copy link
Author

chzar commented Nov 26, 2024

I want to improve this PR to move the constraints to the left side of the targetRevision string and support multiple constraints. Standby...

@andrii-korotkov-verkada
Copy link
Contributor

Please, sign off your commits.

@chzar chzar requested a review from a team as a code owner November 26, 2024 15:56
@chzar
Copy link
Author

chzar commented Nov 26, 2024

I signed my commits and added a mention of this functionality in the docs under tracking strategies: use cases.

@codecov Codecov
Copy link

codecov bot commented Nov 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.99%. Comparing base (02d6866) to head (8f454fb).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #20948      +/-   ##
==========================================
- Coverage   55.03%   54.99%   -0.05%     
==========================================
  Files         324      324              
  Lines       55466    55477      +11     
==========================================
- Hits        30526    30508      -18     
- Misses      22330    22352      +22     
- Partials     2610     2617       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chzar chzar force-pushed the feat/tag-path-prefix branch 2 times, most recently from 2c899c4 to bd9059a Compare November 28, 2024 18:29
@chzar
feat: Add basic support for tag path prefixes
2852751 
Signed-off-by: Cameron Harrell <cameron.harrell@laerdal.com>
@chzar
update docs
911f5d8 
Signed-off-by: Cameron Harrell <cameron.harrell@laerdal.com>
@chzar
update docs
8f454fb 
Signed-off-by: Cameron Harrell <cameron.harrell@laerdal.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrii-korotkov-verkada andrii-korotkov-verkada andrii-korotkov-verkada approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ready-for-review
Projects
Argo CD Review
Status: Ready for final review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow the use of hierarchical tags in semver target revisions
2 participants
@chzar @andrii-korotkov-verkada