Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add images to resources in sync result #20954

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Aaron-9900
Copy link

@Aaron-9900 Aaron-9900 commented Nov 26, 2024

Closes issue #20896

Signed-off-by: Aaron Hoffman <31711338+Aaron-9900@users.noreply.github.com>
Copy link

bunnyshell bot commented Nov 26, 2024

❗ Preview Environment deployment failed on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@Aaron-9900 Aaron-9900 changed the title feat: Add images to sync result feat: Add images to resources in sync result Nov 26, 2024
@andrii-korotkov-verkada
Copy link
Contributor

The error is

#41 86.71 controller/sync.go:450:19: res.Images undefined (type "github.com/argoproj/gitops-engine/pkg/sync/common".ResourceSyncResult has no field or method Images)

@andrii-korotkov-verkada
Copy link
Contributor

You have to add replace in go.mod for gitops-engine pointing to your fork and branch and then run go mod tidy.

@Aaron-9900
Copy link
Author

You have to add replace in go.mod for gitops-engine pointing to your fork and branch and then run go mod tidy.

Yeah for testing locally that works, but I'd rather not commit that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants