Skip to content

Cautionary notes about default random engine handle management #2947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2020
Merged

Cautionary notes about default random engine handle management #2947

merged 1 commit into from
Jun 26, 2020

Conversation

9prady9
Copy link
Member

@9prady9 9prady9 commented Jun 26, 2020 •
edited
Loading

Description

Adds some cautionary notes on how to manage the handle returned by af_get_default_random_engine.
Fixes: #2940

Changes to Users

Documentation of Default Random Engine Functions is changed.

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • Functions added to unified API
  • Functions documented

@9prady9 9prady9 added this to the 3.7.2 milestone Jun 26, 2020
@9prady9 9prady9 requested a review from umar456 June 26, 2020 14:21
@9prady9 9prady9 merged commit 71e1a25 into arrayfire:master Jun 26, 2020
@9prady9 9prady9 deleted the issue2940 branch June 26, 2020 17:48
@umar456 umar456 mentioned this pull request Jun 27, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umar456 umar456 umar456 approved these changes

Assignees
No one assigned
Labels
Documentation fix
Projects
None yet
Milestone
3.7.2
Development

Successfully merging this pull request may close these issues.

Potential dangling pointer with af_get_default_random_engine()
2 participants
@9prady9 @umar456