Add a lookahead for DELETE to avoid mistaking HTTP strings for SQL

illright · illright · commit 3f8fa33ce8f5 · 2019-12-29T19:34:50.000+05:00
diff --git a/grammars/python.cson b/grammars/python.cson
@@ -1643,7 +1643,7 @@
         'name': 'string.quoted.double.block.python'
         'patterns': [
           {
-             'begin': '(?=\\s*(SELECT|INSERT|UPDATE|DELETE|CREATE|REPLACE|ALTER|WITH))'
+             'begin': '(?=\\s*(SELECT|INSERT|UPDATE|DELETE(?! \/)|CREATE|REPLACE|ALTER|WITH))'
              'name': 'meta.embedded.sql'
              'end': '(?=\\s*""")'
              'patterns': [
@@ -1655,7 +1655,7 @@
         ]
       }
       {
-        'begin': '(")(?=\\s*(SELECT|INSERT|UPDATE|DELETE|CREATE|REPLACE|ALTER|WITH))'
+        'begin': '(")(?=\\s*(SELECT|INSERT|UPDATE|DELETE(?! \/)|CREATE|REPLACE|ALTER|WITH))'
         'beginCaptures':
           '1':
             'name': 'punctuation.definition.string.begin.python'
@@ -2214,7 +2214,7 @@
         'name': 'string.quoted.single.block.python'
         'patterns': [
           {
-             'begin': '(?=\\s*(SELECT|INSERT|UPDATE|DELETE|CREATE|REPLACE|ALTER|WITH))'
+             'begin': '(?=\\s*(SELECT|INSERT|UPDATE|DELETE(?! \/)|CREATE|REPLACE|ALTER|WITH))'
              'end': '(?=\\s*\'\'\')'
              'name': 'meta.embedded.sql'
              'patterns': [
@@ -2226,7 +2226,7 @@
         ]
       }
       {
-        'begin': '(\')(?=\\s*(SELECT|INSERT|UPDATE|DELETE|CREATE|REPLACE|ALTER|WITH))'
+        'begin': '(\')(?=\\s*(SELECT|INSERT|UPDATE|DELETE(?! \/)|CREATE|REPLACE|ALTER|WITH))'
         'beginCaptures':
           '1':
             'name': 'punctuation.definition.string.begin.python'

Original file line number	Diff line number	Diff line change
`@@ -1643,7 +1643,7 @@`
`1643`	`1643`	`'name': 'string.quoted.double.block.python'`
`1644`	`1644`	`'patterns': [`
`1645`	`1645`	`{`
`1646`		`- 'begin': '(?=\\s*(SELECT\|INSERT\|UPDATE\|DELETE\|CREATE\|REPLACE\|ALTER\|WITH))'`
	`1646`	`+ 'begin': '(?=\\s*(SELECT\|INSERT\|UPDATE\|DELETE(?! \/)\|CREATE\|REPLACE\|ALTER\|WITH))'`
`1647`	`1647`	`'name': 'meta.embedded.sql'`
`1648`	`1648`	`'end': '(?=\\s*""")'`
`1649`	`1649`	`'patterns': [`
`@@ -1655,7 +1655,7 @@`
`1655`	`1655`	`]`
`1656`	`1656`	`}`
`1657`	`1657`	`{`
`1658`		`- 'begin': '(")(?=\\s*(SELECT\|INSERT\|UPDATE\|DELETE\|CREATE\|REPLACE\|ALTER\|WITH))'`
	`1658`	`+ 'begin': '(")(?=\\s*(SELECT\|INSERT\|UPDATE\|DELETE(?! \/)\|CREATE\|REPLACE\|ALTER\|WITH))'`
`1659`	`1659`	`'beginCaptures':`
`1660`	`1660`	`'1':`
`1661`	`1661`	`'name': 'punctuation.definition.string.begin.python'`
`@@ -2214,7 +2214,7 @@`
`2214`	`2214`	`'name': 'string.quoted.single.block.python'`
`2215`	`2215`	`'patterns': [`
`2216`	`2216`	`{`
`2217`		`- 'begin': '(?=\\s*(SELECT\|INSERT\|UPDATE\|DELETE\|CREATE\|REPLACE\|ALTER\|WITH))'`
	`2217`	`+ 'begin': '(?=\\s*(SELECT\|INSERT\|UPDATE\|DELETE(?! \/)\|CREATE\|REPLACE\|ALTER\|WITH))'`
`2218`	`2218`	`'end': '(?=\\s*\'\'\')'`
`2219`	`2219`	`'name': 'meta.embedded.sql'`
`2220`	`2220`	`'patterns': [`
`@@ -2226,7 +2226,7 @@`
`2226`	`2226`	`]`
`2227`	`2227`	`}`
`2228`	`2228`	`{`
`2229`		`- 'begin': '(\')(?=\\s*(SELECT\|INSERT\|UPDATE\|DELETE\|CREATE\|REPLACE\|ALTER\|WITH))'`
	`2229`	`+ 'begin': '(\')(?=\\s*(SELECT\|INSERT\|UPDATE\|DELETE(?! \/)\|CREATE\|REPLACE\|ALTER\|WITH))'`
`2230`	`2230`	`'beginCaptures':`
`2231`	`2231`	`'1':`
`2232`	`2232`	`'name': 'punctuation.definition.string.begin.python'`