return rowCount on insert

jakobrun · jakobrun · commit 2398e992a8e6 · 2018-01-01T18:43:18.000Z
diff --git a/index.js b/index.js
@@ -89,7 +89,8 @@ Cursor.prototype._sendRows = function () {
   })
 }
 
-Cursor.prototype.handleCommandComplete = function () {
+Cursor.prototype.handleCommandComplete = function (msg) {
+  this._result.addCommandComplete(msg)
   this.connection.sync()
 }
 
diff --git a/test/index.js b/test/index.js
@@ -160,4 +160,18 @@ describe('cursor', function () {
       done()
     })
   })
+
+  it('returns rowCount on insert', function (done) {
+    var pgCursor = this.pgCursor
+    this.client.query('CREATE TEMPORARY TABLE pg_cursor_test (foo VARCHAR(1), bar VARCHAR(1))')
+      .then(function () {
+        var cursor = pgCursor('insert into pg_cursor_test values($1, $2)', ['a', 'b'])
+        cursor.read(1, function (err, rows, result) {
+          assert.ifError(err)
+          assert.equal(rows.length, 0)
+          assert.equal(result.rowCount, 1)
+          done()
+        })
+      }).catch(done)
+  })
 })

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,8 @@ Cursor.prototype._sendRows = function () {`
`89`	`89`	`})`
`90`	`90`	`}`
`91`	`91`
`92`		`-Cursor.prototype.handleCommandComplete = function () {`
	`92`	`+Cursor.prototype.handleCommandComplete = function (msg) {`
	`93`	`+ this._result.addCommandComplete(msg)`
`93`	`94`	`this.connection.sync()`
`94`	`95`	`}`
`95`	`96`