Fix closing a finished cursor without supplying a callback

Hetul Patel · Hetul Patel · commit 24e485e81e12 · 2017-10-03T18:13:40.000-07:00
diff --git a/index.js b/index.js
@@ -149,7 +149,11 @@ Cursor.prototype.end = function (cb) {
 
 Cursor.prototype.close = function (cb) {
   if (this.state === 'done') {
-    return setImmediate(cb)
+    if (cb) {
+      return setImmediate(cb)
+    } else {
+      return
+    }
   }
   this.connection.close({type: 'P'})
   this.connection.sync()
diff --git a/test/close.js b/test/close.js
@@ -10,6 +10,16 @@ describe('close', function () {
     client.on('drain', client.end.bind(client))
   })
 
+  it('can close a finished cursor without a callback', function (done) {
+    var cursor = new Cursor(text)
+    this.client.query(cursor)
+    this.client.query('SELECT NOW()', done)
+    cursor.read(100, function (err, res) {
+      assert.ifError(err)
+      cursor.close()
+    })
+  })
+
   it('closes cursor early', function (done) {
     var cursor = new Cursor(text)
     this.client.query(cursor)
