Skip to content

Commit 74b6891

Browse files
committed
handle empty query
1 parent a01a555 commit 74b6891

File tree

6 files changed

+22
-5
lines changed

6 files changed

+22
-5
lines changed

index.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,12 @@ Cursor.prototype.handleReadyForQuery = function() {
8989
this.state = 'done'
9090
}
9191

92+
Cursor.prototype.handleEmptyQuery = function(con) {
93+
if (con.sync) {
94+
con.sync()
95+
}
96+
};
97+
9298
Cursor.prototype.handleError = function(msg) {
9399
this.state = 'error'
94100
this._error = msg

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"author": "Brian M. Carlson",
1313
"license": "MIT",
1414
"devDependencies": {
15-
"pg.js": "~3.4.4",
15+
"pg": "~6.0.0",
1616
"mocha": "~1.17.1"
1717
},
1818
"dependencies": {}

test/close.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
var assert = require('assert')
22
var Cursor = require('../')
3-
var pg = require('pg.js')
3+
var pg = require('pg')
44

55
var text = 'SELECT generate_series as num FROM generate_series(0, 50)'
66
describe('close', function() {

test/error-handling.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
var assert = require('assert')
22
var Cursor = require('../')
3-
var pg = require('pg.js')
3+
var pg = require('pg')
44

55
var text = 'SELECT generate_series as num FROM generate_series(0, 4)'
66

test/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
var assert = require('assert')
22
var Cursor = require('../')
3-
var pg = require('pg.js')
3+
var pg = require('pg')
44

55
var text = 'SELECT generate_series as num FROM generate_series(0, 5)'
66

test/no-data-handling.js

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
var assert = require('assert')
2-
var pg = require('pg.js');
2+
var pg = require('pg');
33
var Cursor = require('../');
44

55
describe('queries with no data', function () {
@@ -22,4 +22,15 @@ describe('queries with no data', function () {
2222
done()
2323
})
2424
});
25+
26+
it('handles empty query', function (done) {
27+
var cursor = new Cursor('-- this is a comment')
28+
cursor = this.client.query(cursor)
29+
cursor.read(100, function (err, rows) {
30+
assert.ifError(err)
31+
assert.equal(rows.length, 0)
32+
done()
33+
})
34+
})
35+
2536
});

0 commit comments

Comments
 (0)