Move cloneNode into individual node classes

jgraham · jgraham · commit 617226858581 · 2009-12-24T13:42:37.000+01:00
diff --git a/src/html5lib/treebuilders/simpletree.py b/src/html5lib/treebuilders/simpletree.py
@@ -62,14 +62,7 @@ def removeChild(self, node):
         node.parent = None
 
     def cloneNode(self):
-        newNode = type(self)(self.name)
-        if hasattr(self, 'namespace'):
-            newNode.namespace = self.namespace
-        if hasattr(self, 'attributes'):
-            for attr, value in self.attributes.iteritems():
-                newNode.attributes[attr] = value
-        newNode.value = self.value
-        return newNode
+        raise NotImplementedError
 
     def hasContent(self):
         """Return true if the node has children or text"""
@@ -112,11 +105,17 @@ def printTree(self):
             tree += child.printTree(2)
         return tree
 
+    def cloneNode(self):
+        return Document()
+
 class DocumentFragment(Document):
     type = 2
     def __unicode__(self):
         return "#document-fragment"
 
+    def cloneNode(self):
+        return DocumentFragment()
+
 class DocumentType(Node):
     type = 3
     def __init__(self, name, publicId, systemId):
@@ -140,6 +139,9 @@ def __unicode__(self):
     def hilite(self):
         return '<code class="markup doctype">&lt;!DOCTYPE %s></code>' % self.name
 
+    def cloneNode(self):
+        return DocumentType(self.name, self.publicId, self.systemId)
+
 class TextNode(Node):
     type = 4
     def __init__(self, value):
@@ -154,6 +156,9 @@ def toxml(self):
     
     hilite = toxml
 
+    def cloneNode(self):
+        return TextNode(self.value)
+
 class Element(Node):
     type = 5
     def __init__(self, name, namespace=None):
@@ -206,6 +211,12 @@ def printTree(self, indent):
             tree += child.printTree(indent)
         return tree
 
+    def cloneNode(self):
+        newNode = Element(self.name)
+        for attr, value in self.attributes.iteritems():
+            newNode.attributes[attr] = value
+        return newNode
+
 class CommentNode(Node):
     type = 6
     def __init__(self, data):
@@ -221,6 +232,9 @@ def toxml(self):
     def hilite(self):
         return '<code class="markup comment">&lt;!--%s--></code>' % escape(self.data)
 
+    def cloneNode(self):
+        return CommentNode(self.data)
+
 class TreeBuilder(_base.TreeBuilder):
     documentClass = Document
     doctypeClass = DocumentType
