Skip to content

Remove pgo builds when pgo+lto builds exist #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zanieb opened this issue Dec 18, 2024 · 3 comments · Fixed by #444
Closed

Remove pgo builds when pgo+lto builds exist #442

zanieb opened this issue Dec 18, 2024 · 3 comments · Fixed by #444

Comments

@zanieb
Copy link
Member

zanieb commented Dec 18, 2024

In the style of #223 — is there a downside to this?

It'd be nice to reduce the matrix if these aren't providing value.

@indygreg
Copy link
Collaborator

Historically I kept the non-LTO variants for PyOxidizer support for... reasons.

You have my permission to remove PGO when PGO+LTO exists.

@zanieb
Copy link
Member Author

zanieb commented Dec 18, 2024

for... reasons.

👀

Thanks for confirming!

@ntamas
Copy link
Contributor

ntamas commented Dec 22, 2024

@indygreg @zanieb Will the PGO+LTO builds work with PyOxidizer as-is?

(Background: I have been trying to keep PyOxidizer alive for the last few months in my fork (see https://github.com/ntamas/PyOxidizer) because I need it for my own projects and I've mostly gotten it to work (apart from the musl libc builds) with recent versions of PyO3 and everything. I'm currently in the process of updating the corresponding Python distributions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants