Removing usage of reproject in RGB documentation #5760
Conversation
…SS images from the astropy data server
|
@pllim - could you please add milestone 1.3.1, too? |
|
@larrybradley or @astrofrog - Could you have a look at this? |
docs/visualization/lupton_rgb.rst
Outdated
| `reproject package`_, installable via the astropy conda channel, or via pip), | ||
| and compare it with Figure 1 of Lupton et al. (2004): | ||
| For a more in-depth example, download the ``g``, ``r``, ``i`` SDSS frames | ||
| (the will serve as the blue, green and red channels respectively) of |
|
rendered version: http://people.bolyai.elte.hu/~sic/astropy/visualization/lupton_rgb.html |
|
I'm probably nitpicking here -- The image from this doc has larger FOV and different orientation than Lupton et al. 2004 Fig. 1, and does not match the SDSS link at all (i.e., I can't tell which one is the galaxy from your example in the latter). From the viewpoint of someone who is assessing whether this is the function I want to use or not, I would like to see:
But you can ignore if package maintainers disagree. |
|
@pllim - Sounds sensible, however my only aim within this PR was to remove the usage of reproject and get the same result as it was before in the astropy docs: http://docs.astropy.org/en/latest/visualization/lupton_rgb.html Double checking it I realize that the orientation is upside down, I'm not sure whether that is an issue with the implementation or the with the code that produces the figure in the docs. |
|
@bsipocz Please update the SDSS link to something in the field, e.g.: The link currently in master is wrong. |
|
@bsipocz The image is flipped because of a bug in |
|
@bsipocz My last comment refers to the jpg output. To fix the flip in the docs simply add |
|
@larrybradley - Done |
|
Thanks, @bsipocz! |
Removing usage of reproject in RGB documentation
This PR partly addresses #5570 (the first 3 points, writing a tutorial is clearly beyond the scope of this PR).
Needs astropy/astropy-data#24 to be merged first.