Add test coverage of retry errors

megawac · megawac · commit ade570d379f7 · 2015-07-20T00:02:24.000-04:00
diff --git a/lib/async.js b/lib/async.js
@@ -593,7 +593,7 @@
                 acc.times = parseInt(t.times, 10) || DEFAULT_TIMES;
                 acc.interval = parseInt(t.interval, 10) || DEFAULT_INTERVAL;
             } else {
-                throw new Error('Unsupported argument type for \'times\': ' + typeof(t));
+                throw new Error('Unsupported argument type for \'times\': ' + typeof t);
             }
         }
 
diff --git a/test/test-async.js b/test/test-async.js
@@ -728,6 +728,19 @@ exports['retry when all attempts succeeds'] = function(test) {
     });
 };
 
+exports['retry fails with invalid arguments'] = function(test) {
+    test.throws(function() {
+        async.retry("");
+    });
+    test.throws(function() {
+        async.retry();
+    });
+    test.throws(function() {
+        async.retry(function() {}, 2, function() {});
+    });
+    test.done();
+};
+
 exports['retry with interval when all attempts succeeds'] = function(test) {
     var times = 3;
     var interval = 500;

Original file line number	Diff line number	Diff line change
`@@ -593,7 +593,7 @@`
`593`	`593`	`acc.times = parseInt(t.times, 10) \|\| DEFAULT_TIMES;`
`594`	`594`	`acc.interval = parseInt(t.interval, 10) \|\| DEFAULT_INTERVAL;`
`595`	`595`	`} else {`
`596`		`- throw new Error('Unsupported argument type for \'times\': ' + typeof(t));`
	`596`	`+ throw new Error('Unsupported argument type for \'times\': ' + typeof t);`
`597`	`597`	`}`
`598`	`598`	`}`
`599`	`599`