Add test for notify_all

tmccombs · tmccombs · commit 80aece0371df · 2019-10-28T01:29:08.000-06:00
diff --git a/src/sync/condvar.rs b/src/sync/condvar.rs
@@ -352,7 +352,6 @@ impl<'a, 'b, T> Drop for AwaitNotify<'a, 'b, T> {
                 // we are dropping it before it can finished.
                 // This may result in a spurious wake-up, but that's ok.
                 notify(blocked, false);
-
             }
         }
     }
diff --git a/tests/condvar.rs b/tests/condvar.rs
@@ -2,7 +2,7 @@ use std::sync::Arc;
 use std::time::Duration;
 
 use async_std::sync::{Condvar, Mutex};
-use async_std::task;
+use async_std::task::{self, JoinHandle};
 
 #[test]
 fn wait_timeout() {
@@ -25,3 +25,38 @@ fn wait_timeout() {
     })
 }
 
+#[test]
+fn notify_all() {
+    task::block_on(async {
+        let mut tasks: Vec<JoinHandle<()>> = Vec::new();
+        let pair = Arc::new((Mutex::new(0u32), Condvar::new()));
+
+        for i in 0..10 {
+            let pair = pair.clone();
+            tasks.push(task::spawn(async move {
+                let (m, c) = &*pair;
+                let mut count = m.lock().await;
+                while *count == 0 {
+                    count = c.wait(count).await;
+                }
+                *count += 1;
+            }));
+        }
+
+        // Give some time for tasks to start up
+        task::sleep(Duration::from_millis(5)).await;
+
+        let (m, c) = &*pair;
+        {
+            let mut count = m.lock().await;
+            *count += 1;
+            c.notify_all();
+        }
+
+        for t in tasks {
+            t.await;
+        }
+        let count = m.lock().await;
+        assert!(*count == 11);
+    })
+}

Original file line number	Diff line number	Diff line change
`@@ -352,7 +352,6 @@ impl<'a, 'b, T> Drop for AwaitNotify<'a, 'b, T> {`
`352`	`352`	`// we are dropping it before it can finished.`
`353`	`353`	`// This may result in a spurious wake-up, but that's ok.`
`354`	`354`	`notify(blocked, false);`
`355`		`-`
`356`	`355`	`}`
`357`	`356`	`}`
`358`	`357`	`}`