Skip to content

FromStream impl for Option<T> + Revised impl for Vec<T> #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 1, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
FromStream for Option<T>
  • Loading branch information
sunjay committed Sep 30, 2019
commit 76b10c4784fc109e1574fa7874975e2a9ed80888
1 change: 1 addition & 0 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ cfg_if! {

mod vec;
mod result;
mod option;
}
}

Expand Down
49 changes: 49 additions & 0 deletions src/option/from_stream.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
use std::pin::Pin;

use crate::prelude::*;
use crate::stream::{FromStream, IntoStream};

impl<T, V> FromStream<Option<T>> for Option<V>
where
V: FromStream<T>,
{
/// Takes each element in the stream: if it is `None`, no further
/// elements are taken, and `None` is returned. Should no `None`
/// occur, a container with the values of each `Option` is returned.
#[inline]
fn from_stream<'a, S: IntoStream<Item = Option<T>>>(
stream: S,
) -> Pin<Box<dyn core::future::Future<Output = Self> + 'a>>
where
<S as IntoStream>::IntoStream: 'a,
{
let stream = stream.into_stream();

Pin::from(Box::new(async move {
pin_utils::pin_mut!(stream);

// Using `scan` here because it is able to stop the stream early
// if a failure occurs
let mut found_error = false;
let out: V = stream
.scan((), |_, elem| {
match elem {
Some(elem) => Some(elem),
None => {
found_error = true;
// Stop processing the stream on error
None
}
}
})
.collect()
.await;

if found_error {
None
} else {
Some(out)
}
}))
}
}
9 changes: 9 additions & 0 deletions src/option/mod.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
//! The Rust core optional value type
//!
//! This module provides the `Option<T>` type for returning and
//! propagating optional values.

mod from_stream;

#[doc(inline)]
pub use std::option::Option;