Allow the developer to set the Content-Disposition header in Response::download()

Jason Funk · Jason Funk · commit 96e44d908cd2 · 2013-05-07T09:16:13.000-05:00
diff --git a/laravel/response.php b/laravel/response.php
@@ -202,9 +202,14 @@ public static function download($path, $name = null, $headers = array())
 		// off to the HttpFoundation and let it create the header text.
 		$response = new static(File::get($path), 200, $headers);
 
-		$d = $response->disposition($name);
+		// If the Content-Disposition header has already been set by the
+		// merge above, then do not override it with out generated one.
+		if (!isset($headers['Content-Disposition'])) {
+			$d = $response->disposition($name);
+			$response = $response->header('Content-Disposition', $d);
+		}
 
-		return $response->header('Content-Disposition', $d);
+		return $response;
 	}
 
 	/**
