Merge pull request cscheid#27 from att/unsigned-right-shift

cscheid · cscheid · commit 49933fd24abc · 2015-02-05T21:13:31.000-07:00
use the JavaScript unsigned right-shift operator &gt;&gt;&gt;
diff --git a/src/parse.js b/src/parse.js
@@ -212,7 +212,7 @@ function parse(msg)
 {
     var result = {};
     var header = new Int32Array(msg, 0, 4);
-    var resp = header[0] & 16777215, status_code = header[0] >> 24;
+    var resp = header[0] & 16777215, status_code = header[0] >>> 24;
     var msg_id = header[2];
     result.header = [resp, status_code, msg_id];
 
diff --git a/src/rserve.js b/src/rserve.js
@@ -90,7 +90,7 @@ Rserve.create = function(opts) {
             // can't left shift value here because value will have bit 32 set and become signed..
             view.data_view().setInt32(0, Rserve.Rsrv.DT_SEXP + ((sz & 16777215) * Math.pow(2, 8)) + Rserve.Rsrv.DT_LARGE);
             // but *can* right shift because we assume sz is less than 2^31 or so to begin with
-            view.data_view().setInt32(4, sz >> 24);
+            view.data_view().setInt32(4, sz >>> 24);
             Rserve.write_into_view(value, view.skip(8), forced_type, convert_to_hash);
             return buffer;
         } else {
diff --git a/src/rsrv.js b/src/rsrv.js
@@ -3,11 +3,11 @@
 
 Rserve.Rsrv = {
     PAR_TYPE: function(x) { return x & 255; },
-    PAR_LEN: function(x) { return x >> 8; },
-    PAR_LENGTH: function(x) { return x >> 8; },
+    PAR_LEN: function(x) { return x >>> 8; },
+    PAR_LENGTH: function(x) { return x >>> 8; },
     par_parse: function(x) { return [Rserve.Rsrv.PAR_TYPE(x), Rserve.Rsrv.PAR_LEN(x)]; },
     SET_PAR: function(ty, len) { return ((len & 0xffffff) << 8 | (ty & 255)); },
-    CMD_STAT: function(x) { return (x >> 24) & 127; },
+    CMD_STAT: function(x) { return (x >>> 24) & 127; },
     SET_STAT: function(x, s) { return x | ((s & 127) << 24); },
 
     IS_OOB_SEND: function(x) { return (x & 0xffff000) === Rserve.Rsrv.OOB_SEND; },
diff --git a/src/write.js b/src/write.js
@@ -133,7 +133,7 @@ Rserve.write_into_view = function(value, array_buffer_view, forced_type, convert
     if (is_large) {
         payload_start = 8;
         write_view.setInt32(0, t + ((size - 8) << 8));
-        write_view.setInt32(4, (size - 8) >> 24);
+        write_view.setInt32(4, (size - 8) >>> 24);
     } else { 
         payload_start = 4;
         write_view.setInt32(0, t + ((size - 4) << 8));

Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,7 @@ function parse(msg)`
`212`	`212`	`{`
`213`	`213`	`var result = {};`
`214`	`214`	`var header = new Int32Array(msg, 0, 4);`
`215`		`- var resp = header[0] & 16777215, status_code = header[0] >> 24;`
	`215`	`+ var resp = header[0] & 16777215, status_code = header[0] >>> 24;`
`216`	`216`	`var msg_id = header[2];`
`217`	`217`	`result.header = [resp, status_code, msg_id];`
`218`	`218`