StreamProperties: fixed access of AVCodecContext properties if several analysis are launched

Clement Champetier · Clement Champetier · commit 090ff3b52fb4 · 2016-07-11T21:07:39.000+02:00
* According to the documentation, the avcodec_open2 function does not
allocate anything and a call to avcodec_close is not needed.
* avcodec_close sets codec attribute of AVCodecContext to NULL, and this
is a problem when we would like to transcode after a file analysis.
diff --git a/src/AvTranscoder/properties/StreamProperties.cpp b/src/AvTranscoder/properties/StreamProperties.cpp
@@ -41,7 +41,6 @@ StreamProperties::StreamProperties(const FileProperties& fileProperties, const s
             if(avcodec_open2(_codecContext, _codec, NULL) == 0)
             {
                 loadOptions(_options, _codecContext);
-                avcodec_close(_codecContext);
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,6 @@ StreamProperties::StreamProperties(const FileProperties& fileProperties, const s`
`41`	`41`	`if(avcodec_open2(_codecContext, _codec, NULL) == 0)`
`42`	`42`	`{`
`43`	`43`	`loadOptions(_options, _codecContext);`
`44`		`- avcodec_close(_codecContext);`
`45`	`44`	`}`
`46`	`45`	`}`
`47`	`46`	`}`