AudioDecoder: improved exception message when decodeNextFrame and the specified channel does not exist

Clement Champetier · Clement Champetier · commit 0f415e730f6a · 2015-12-01T14:33:04.000+01:00
diff --git a/src/AvTranscoder/decoder/AudioDecoder.cpp b/src/AvTranscoder/decoder/AudioDecoder.cpp
@@ -13,6 +13,7 @@ extern "C" {
 }
 
 #include <stdexcept>
+#include <sstream>
 
 namespace avtranscoder
 {
@@ -142,7 +143,13 @@ bool AudioDecoder::decodeNextFrame( Frame& frameBuffer, const size_t channelInde
 
 	if( channelIndex > srcNbChannels - 1 )
 	{
-		throw std::runtime_error( "The subStream doesn't exist");
+		std::stringstream msg;
+		msg << "The channel at index ";
+		msg << channelIndex;
+		msg << " doesn't exist (srcNbChannels = ";
+		msg << srcNbChannels;
+		msg << ").";
+		throw std::runtime_error( msg.str() );
 	}
 
 	AudioFrame& audioBuffer = static_cast<AudioFrame&>( frameBuffer );

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@ extern "C" {`
`13`	`13`	`}`
`14`	`14`
`15`	`15`	`#include <stdexcept>`
	`16`	`+#include <sstream>`
`16`	`17`
`17`	`18`	`namespace avtranscoder`
`18`	`19`	`{`
`@@ -142,7 +143,13 @@ bool AudioDecoder::decodeNextFrame( Frame& frameBuffer, const size_t channelInde`
`142`	`143`
`143`	`144`	`if( channelIndex > srcNbChannels - 1 )`
`144`	`145`	`{`
`145`		`- throw std::runtime_error( "The subStream doesn't exist");`
	`146`	`+ std::stringstream msg;`
	`147`	`+ msg << "The channel at index ";`
	`148`	`+ msg << channelIndex;`
	`149`	`+ msg << " doesn't exist (srcNbChannels = ";`
	`150`	`+ msg << srcNbChannels;`
	`151`	`+ msg << ").";`
	`152`	`+ throw std::runtime_error( msg.str() );`
`146`	`153`	`}`
`147`	`154`
`148`	`155`	`AudioFrame& audioBuffer = static_cast<AudioFrame&>( frameBuffer );`