Set OutputFile addAudioStream and addVideoStream methods return value to void

Valentin Noel · Valentin Noel · commit 2bbef17f3766 · 2014-06-24T18:38:00.000+02:00
diff --git a/src/AvTranscoder/File/OutputFile.cpp b/src/AvTranscoder/File/OutputFile.cpp
@@ -59,7 +59,7 @@ bool OutputFile::setup()
 	return _formatContext != NULL;
 }
 
-AvOutputStream& OutputFile::addVideoStream( const VideoDesc& videoDesc )
+void OutputFile::addVideoStream( const VideoDesc& videoDesc )
 {
 	assert( _formatContext != NULL );
 
@@ -87,11 +87,9 @@ AvOutputStream& OutputFile::addVideoStream( const VideoDesc& videoDesc )
 	_stream->time_base = _stream->codec->time_base;
 	
 	_outputStreams.push_back( AvOutputStream( *this, _formatContext->nb_streams ) );
-
-	return _outputStreams.back();
 }
 
-AvOutputStream& OutputFile::addAudioStream( const AudioDesc& audioDesc )
+void OutputFile::addAudioStream( const AudioDesc& audioDesc )
 {
 	assert( _formatContext != NULL );
 
@@ -105,8 +103,6 @@ AvOutputStream& OutputFile::addAudioStream( const AudioDesc& audioDesc )
 	_stream->codec->sample_fmt = audioDesc.getCodecContext()->sample_fmt;
 
 	_outputStreams.push_back( AvOutputStream( *this, _formatContext->nb_streams ) );
-
-	return _outputStreams.back();
 }
 
 AvOutputStream& OutputFile::getStream( const size_t streamId )
diff --git a/src/AvTranscoder/File/OutputFile.hpp b/src/AvTranscoder/File/OutputFile.hpp
@@ -47,14 +47,14 @@ class AvExport OutputFile
 	 * @note call setup() before adding any stream
 	 * @param videoDesc description of output stream
 	**/
-	virtual AvOutputStream& addVideoStream( const VideoDesc& videoDesc );
+	virtual void addVideoStream( const VideoDesc& videoDesc );
 
 	/**
 	 * @brief Add an audio output stream using the description.
 	 * @note call setup() before adding any stream
 	 * @param audioDesc description of output stream
 	**/
-	virtual AvOutputStream& addAudioStream( const AudioDesc& audioDesc );
+	virtual void addAudioStream( const AudioDesc& audioDesc );
 
 	/**
 	 * @brief get the output stream description.

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ bool OutputFile::setup()`
`59`	`59`	`return _formatContext != NULL;`
`60`	`60`	`}`
`61`	`61`
`62`		`-AvOutputStream& OutputFile::addVideoStream( const VideoDesc& videoDesc )`
	`62`	`+void OutputFile::addVideoStream( const VideoDesc& videoDesc )`
`63`	`63`	`{`
`64`	`64`	`assert( _formatContext != NULL );`
`65`	`65`
`@@ -87,11 +87,9 @@ AvOutputStream& OutputFile::addVideoStream( const VideoDesc& videoDesc )`
`87`	`87`	`_stream->time_base = _stream->codec->time_base;`
`88`	`88`
`89`	`89`	`_outputStreams.push_back( AvOutputStream( *this, _formatContext->nb_streams ) );`
`90`		`-`
`91`		`- return _outputStreams.back();`
`92`	`90`	`}`
`93`	`91`
`94`		`-AvOutputStream& OutputFile::addAudioStream( const AudioDesc& audioDesc )`
	`92`	`+void OutputFile::addAudioStream( const AudioDesc& audioDesc )`
`95`	`93`	`{`
`96`	`94`	`assert( _formatContext != NULL );`
`97`	`95`
`@@ -105,8 +103,6 @@ AvOutputStream& OutputFile::addAudioStream( const AudioDesc& audioDesc )`
`105`	`103`	`_stream->codec->sample_fmt = audioDesc.getCodecContext()->sample_fmt;`
`106`	`104`
`107`	`105`	`_outputStreams.push_back( AvOutputStream( *this, _formatContext->nb_streams ) );`
`108`		`-`
`109`		`- return _outputStreams.back();`
`110`	`106`	`}`
`111`	`107`
`112`	`108`	`AvOutputStream& OutputFile::getStream( const size_t streamId )`