AvOutputVideo/Audio: print warning when can't set an option in setProfile

Clement Champetier · Clement Champetier · commit 37687f06bc80 · 2015-01-12T17:54:19.000+01:00
Remove _verbose attribute of AvOutputVideo/Audio.
diff --git a/src/AvTranscoder/essenceStream/AvOutputAudio.cpp b/src/AvTranscoder/essenceStream/AvOutputAudio.cpp
@@ -14,7 +14,6 @@ namespace avtranscoder
 
 AvOutputAudio::AvOutputAudio( const std::string& audioCodecName )
 	: _codec( eCodecTypeEncoder, audioCodecName )
-	, _verbose( false )
 {
 }
 
@@ -208,8 +207,7 @@ void AvOutputAudio::setProfile( const ProfileLoader::Profile& profile, const Aud
 		}
 		catch( std::exception& e )
 		{
-			if( _verbose )
-				std::cout << "[OutputAudio] warning - can't set option " << (*it).first << " to " << (*it).second << ": " << e.what() << std::endl;
+			std::cout << "[OutputAudio] warning - can't set option " << (*it).first << " to " << (*it).second << ": " << e.what() << std::endl;
 		}
 	}
 }
diff --git a/src/AvTranscoder/essenceStream/AvOutputAudio.hpp b/src/AvTranscoder/essenceStream/AvOutputAudio.hpp
@@ -22,12 +22,9 @@ class AvExport AvOutputAudio : public IOutputEssence
 	AudioCodec& getAudioCodec() { return _codec; }
 
 	void setProfile( const ProfileLoader::Profile& profile, const AudioFrameDesc& frameDesc );
-	void setVerbose( bool verbose = true ) { _verbose = verbose; }
 
 private:
 	AudioCodec _codec;
-
-	bool _verbose;
 };
 
 }
diff --git a/src/AvTranscoder/essenceStream/AvOutputVideo.cpp b/src/AvTranscoder/essenceStream/AvOutputVideo.cpp
@@ -15,7 +15,6 @@ namespace avtranscoder
 
 AvOutputVideo::AvOutputVideo( const std::string& videoCodecName )
 	: _codec( eCodecTypeEncoder, videoCodecName )
-	, _verbose( false )
 {
 }
 
@@ -198,8 +197,7 @@ void AvOutputVideo::setProfile( const ProfileLoader::Profile& profile, const avt
 		}
 		catch( std::exception& e )
 		{
-			if( _verbose )
-				std::cout << "[OutputVideo] warning - can't set option " << (*it).first << " to " << (*it).second << ": " << e.what() << std::endl;
+			std::cout << "[OutputVideo] warning - can't set option " << (*it).first << " to " << (*it).second << ": " << e.what() << std::endl;
 		}
 	}
 }
diff --git a/src/AvTranscoder/essenceStream/AvOutputVideo.hpp b/src/AvTranscoder/essenceStream/AvOutputVideo.hpp
@@ -22,12 +22,9 @@ class AvExport AvOutputVideo : public IOutputEssence
 	VideoCodec& getVideoCodec() { return _codec; }
 
 	void setProfile( const ProfileLoader::Profile& profile, const avtranscoder::VideoFrameDesc& frameDesc );
-	void setVerbose( bool verbose = true ) { _verbose = verbose; }
 
 private:
 	VideoCodec _codec;
-
-	bool _verbose;
 };
 
 }

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,6 @@ namespace avtranscoder`
`14`	`14`
`15`	`15`	`AvOutputAudio::AvOutputAudio( const std::string& audioCodecName )`
`16`	`16`	`: _codec( eCodecTypeEncoder, audioCodecName )`
`17`		`- , _verbose( false )`
`18`	`17`	`{`
`19`	`18`	`}`
`20`	`19`
`@@ -208,8 +207,7 @@ void AvOutputAudio::setProfile( const ProfileLoader::Profile& profile, const Aud`
`208`	`207`	`}`
`209`	`208`	`catch( std::exception& e )`
`210`	`209`	`{`
`211`		`- if( _verbose )`
`212`		`- std::cout << "[OutputAudio] warning - can't set option " << (it).first << " to " << (it).second << ": " << e.what() << std::endl;`
	`210`	`+ std::cout << "[OutputAudio] warning - can't set option " << (it).first << " to " << (it).second << ": " << e.what() << std::endl;`
`213`	`211`	`}`
`214`	`212`	`}`
`215`	`213`	`}`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@ namespace avtranscoder`
`15`	`15`
`16`	`16`	`AvOutputVideo::AvOutputVideo( const std::string& videoCodecName )`
`17`	`17`	`: _codec( eCodecTypeEncoder, videoCodecName )`
`18`		`- , _verbose( false )`
`19`	`18`	`{`
`20`	`19`	`}`
`21`	`20`
`@@ -198,8 +197,7 @@ void AvOutputVideo::setProfile( const ProfileLoader::Profile& profile, const avt`
`198`	`197`	`}`
`199`	`198`	`catch( std::exception& e )`
`200`	`199`	`{`
`201`		`- if( _verbose )`
`202`		`- std::cout << "[OutputVideo] warning - can't set option " << (it).first << " to " << (it).second << ": " << e.what() << std::endl;`
	`200`	`+ std::cout << "[OutputVideo] warning - can't set option " << (it).first << " to " << (it).second << ": " << e.what() << std::endl;`
`203`	`201`	`}`
`204`	`202`	`}`
`205`	`203`	`}`