StreamTranscoder: clean constructor in case of generator essence

Clement Champetier · Clement Champetier · commit 37f4189c7930 · 2014-10-23T15:08:55.000+02:00
* Cast only one time (for video or audio cases).
* Use reference when cast (it was not the case for video).
diff --git a/src/AvTranscoder/transcoder/StreamTranscoder.cpp b/src/AvTranscoder/transcoder/StreamTranscoder.cpp
@@ -191,11 +191,12 @@ StreamTranscoder::StreamTranscoder(
 	{
 		// Create input essence based on a given input VideoCodec
 		GeneratorVideo* generatorVideo = new GeneratorVideo();
-		generatorVideo->setVideoCodec( static_cast<VideoCodec>( inputCodec ) );
+		const VideoCodec& inputVideoCodec = static_cast<const VideoCodec&>( inputCodec );
+		generatorVideo->setVideoCodec( inputVideoCodec );
 		_inputEssence = generatorVideo;
 
 		// Create inputFrame, and outputFrame which is based on a given profile
-		VideoFrameDesc inputFrameDesc = static_cast<VideoCodec>( inputCodec ).getVideoFrameDesc();
+		VideoFrameDesc inputFrameDesc = inputVideoCodec.getVideoFrameDesc();
 		VideoFrameDesc outputFrameDesc = inputFrameDesc;
 		outputFrameDesc.setParameters( profile );
 		_sourceBuffer = new VideoFrame( inputFrameDesc );
@@ -217,11 +218,12 @@ StreamTranscoder::StreamTranscoder(
 	{
 		// Create input essence based on a given input AudioCodec
 		GeneratorAudio* generatorAudio = new GeneratorAudio();
-		generatorAudio->setAudioCodec( static_cast<const AudioCodec&>( inputCodec ) );
+		const AudioCodec& inputAudioCodec = static_cast<const AudioCodec&>( inputCodec );
+		generatorAudio->setAudioCodec( inputAudioCodec );
 		_inputEssence = generatorAudio;
 
 		// Create inputFrame, and outputFrame which is based on a given profile
-		AudioFrameDesc inputFrameDesc = static_cast<const AudioCodec&>( inputCodec ).getFrameDesc();
+		AudioFrameDesc inputFrameDesc = inputAudioCodec.getFrameDesc();
 		AudioFrameDesc outputFrameDesc = inputFrameDesc;
 		outputFrameDesc.setParameters( profile );
 		_sourceBuffer = new AudioFrame( inputFrameDesc );
