using throw and not exit()

MarcAntoine-Arnaud · MarcAntoine-Arnaud · commit 3c895e2b668f · 2014-06-04T11:51:41.000+02:00
diff --git a/app/audioRewrapper/audioRewrapper.cpp b/app/audioRewrapper/audioRewrapper.cpp
@@ -74,8 +74,7 @@ void transcodeAudio( const char* inputfilename, const char* outputFilename )
 	
 	if( ! outputStreamAudio.setup( ) )
 	{
-		std::cout << "error during initialising audio output stream" << std::endl;
-		exit( -1 );
+		throw std::runtime_error( "error during initialising audio output stream" );
 	}
 	
 	// Transcoding
diff --git a/app/avTranscoder/avTranscoder.cpp b/app/avTranscoder/avTranscoder.cpp
@@ -70,8 +70,7 @@ void transcodeVideo( const char* inputfilename, const char* outputFilename )
 
 	if( !outputStreamVideo.setup( ) )
 	{
-		std::cout << "error during initialising video output stream" << std::endl;
-		exit( -1 );
+		throw std::runtime_error( "error during initialising video output stream" );
 	}
 
 	Image imageToEncode( sourceImage );
@@ -88,8 +87,7 @@ void transcodeVideo( const char* inputfilename, const char* outputFilename )
 
 	if( ! of.setup( ) )
 	{
-		std::cout << "error during setup output file" << std::endl;
-		exit( -1 );
+		throw std::runtime_error( "error during setup output file" );
 	}
 
 	of.addVideoStream( inputFile.getStream( 0 ).getVideoDesc() );
@@ -145,8 +143,16 @@ int main( int argc, char** argv )
 
 	std::cout << "start ..." << std::endl;
 
-	// example of video Transcoding
-	transcodeVideo( argv[1], "transcodedVideo.avi" );
+	try
+	{
+		// example of video Transcoding
+		transcodeVideo( argv[1], "transcodedVideo.avi" );
+	}
+	catch( std::exception &e )
+	{
+		std::cout << "[ERROR] " << e.what() << std::endl;
+	}
+
 
 	std::cout << "end ..." << std::endl;
 }

Original file line number	Diff line number	Diff line change
`@@ -74,8 +74,7 @@ void transcodeAudio( const char* inputfilename, const char* outputFilename )`
`74`	`74`
`75`	`75`	`if( ! outputStreamAudio.setup( ) )`
`76`	`76`	`{`
`77`		`- std::cout << "error during initialising audio output stream" << std::endl;`
`78`		`- exit( -1 );`
	`77`	`+ throw std::runtime_error( "error during initialising audio output stream" );`
`79`	`78`	`}`
`80`	`79`
`81`	`80`	`// Transcoding`