ProfileLoader: clean update

Clement Champetier · Clement Champetier · commit 3fe0cf4e2f1b · 2014-11-06T17:21:13.000+01:00
* Check if 'avProfileIdentificator' key exist in map.
* Do nothing if profile already exists.
diff --git a/src/AvTranscoder/ProfileLoader.cpp b/src/AvTranscoder/ProfileLoader.cpp
@@ -85,15 +85,17 @@ void ProfileLoader::loadProfiles( const std::string& avProfilesPath )
 
 void ProfileLoader::update( const Profile& profile )
 {
-	std::string profileId( profile.find( constants::avProfileIdentificator )->second );
+	Profile::const_iterator profileIt = profile.find( constants::avProfileIdentificator );
+	if( profileIt == profile.end() )
+		throw std::runtime_error( "Invalid profile: can't get identificator" );
+
+	std::string profileId( profileIt->second );
 	size_t profileIndex = 0;
 	for( Profiles::iterator it = _profiles.begin(); it != _profiles.end(); ++it )
 	{
+		// profile already exists
 		if( (*it).find( constants::avProfileIdentificator )->second == profileId )
-		{
-			_profiles.at( profileIndex ) = profile;
 			return;
-		}
 		++profileIndex;
 	}
 	// profile not found: add the new profile
