Transcoder: remove add( StreamTranscoder& stream )

Clement Champetier · Clement Champetier · commit 51b0eae4d3c5 · 2014-10-31T19:09:58.000+01:00
We delete all the 'StreamTranscoder' in destructor of 'Transcoder':
can't add a reference to a stream from outside like this.
diff --git a/src/AvTranscoder/transcoder/Transcoder.cpp b/src/AvTranscoder/transcoder/Transcoder.cpp
@@ -190,11 +190,6 @@ void Transcoder::add( const std::string& filename, const size_t streamIndex, con
 	addTranscodeStream( filename, streamIndex, subStreamIndex, profileDesc, offset );
 }
 
-void Transcoder::add( StreamTranscoder& stream )
-{
-	_streamTranscoders.push_back( &stream );
-}
-
 void Transcoder::init()
 {
 	for( size_t streamIndex = 0; streamIndex < _streamTranscoders.size(); ++streamIndex )
diff --git a/src/AvTranscoder/transcoder/Transcoder.hpp b/src/AvTranscoder/transcoder/Transcoder.hpp
@@ -94,12 +94,6 @@ class AvExport Transcoder
 	 */
 	void add( const std::string& filename, const size_t streamIndex, const int subStreamIndex, Profile::ProfileDesc& profileDesc, ICodec& codec, const size_t offset = 0  );
 
-	/**
-	 * @brief Add the stream
-	 * @note The stream will be deleted in Transcoder's destructor.
-	 */
-	void add( StreamTranscoder& stream );
-
 	/**
 	 * @brief Initialize all streams added, by ensure process necessary frames in case of latency.
 	 * @note This can be called several times with no side effects.

Original file line number	Diff line number	Diff line change
`@@ -190,11 +190,6 @@ void Transcoder::add( const std::string& filename, const size_t streamIndex, con`
`190`	`190`	`addTranscodeStream( filename, streamIndex, subStreamIndex, profileDesc, offset );`
`191`	`191`	`}`
`192`	`192`
`193`		`-void Transcoder::add( StreamTranscoder& stream )`
`194`		`-{`
`195`		`- _streamTranscoders.push_back( &stream );`
`196`		`-}`
`197`		`-`
`198`	`193`	`void Transcoder::init()`
`199`	`194`	`{`
`200`	`195`	`for( size_t streamIndex = 0; streamIndex < _streamTranscoders.size(); ++streamIndex )`