Audio profile: remove channel layout requirement

Clement Champetier · Clement Champetier · commit 5ad23f7895f5 · 2014-07-18T10:46:02.000+02:00
Fix: the channel layout is not required by FFMPEG when open audio codec context. So an audio profile has not to set this value.
diff --git a/src/AvTranscoder/EssenceStream/OutputAudio.cpp b/src/AvTranscoder/EssenceStream/OutputAudio.cpp
@@ -181,8 +181,7 @@ void OutputAudio::setProfile( Profile::ProfileDesc& desc, const AudioFrameDesc&
 	if( ! desc.count( Profile::avProfileCodec ) || 		
 		! desc.count( Profile::avProfileSampleFormat ) || 
 		! desc.count( Profile::avProfileSampleRate ) || 
-		! desc.count( Profile::avProfileChannel ) || 
-		! desc.count( Profile::avProfileChannelLayout ) )
+		! desc.count( Profile::avProfileChannel ) )
 	{
 		throw std::runtime_error( "The profile " + desc[ Profile::avProfileIdentificatorHuman ] + " is invalid." );
 	}
@@ -194,9 +193,6 @@ void OutputAudio::setProfile( Profile::ProfileDesc& desc, const AudioFrameDesc&
 	if( desc[ Profile::avProfileChannel ] == "0" )
 		throw std::runtime_error( "Profile " + desc[ Profile::avProfileIdentificatorHuman ] + ": bad audio channel." );
 	
-	if( desc[ Profile::avProfileChannelLayout ] == "0" )
-		throw std::runtime_error( "Profile " + desc[ Profile::avProfileIdentificatorHuman ] + ": bad audio channel layout." );
-	
 	_audioDesc.setAudioCodec( desc[ Profile::avProfileCodec ] );
 	size_t sample_rate = std::strtoul( desc[ Profile::avProfileSampleRate ].c_str(), NULL, 0 );
 	size_t channels = std::strtoul( desc[ Profile::avProfileChannel ].c_str(), NULL, 0 );
diff --git a/src/AvTranscoder/Profile.cpp b/src/AvTranscoder/Profile.cpp
@@ -25,7 +25,6 @@ const std::string Profile::avProfileSampleFormat( "sample_fmt" );
 const std::string Profile::avProfileFrameRate( "r" );
 const std::string Profile::avProfileSampleRate( "ar" );
 const std::string Profile::avProfileChannel( "ac" );
-const std::string Profile::avProfileChannelLayout( "channel_layout" );
 const std::string Profile::avProfileWidth( "width" );
 const std::string Profile::avProfileHeight( "height" );
 
diff --git a/src/AvTranscoder/Profile.hpp b/src/AvTranscoder/Profile.hpp
@@ -25,7 +25,6 @@ class Profile
 	static const std::string avProfileFrameRate;
 	static const std::string avProfileSampleRate;
 	static const std::string avProfileChannel;
-	static const std::string avProfileChannelLayout;
 	
 	static const std::string avProfileWidth;
 	static const std::string avProfileHeight;
diff --git a/src/AvTranscoder/Profiles/Wave.hpp b/src/AvTranscoder/Profiles/Wave.hpp
@@ -16,7 +16,6 @@ void loadWave( Profile::ProfilesDesc& profiles )
 	wave24b48kMono[ Profile::avProfileSampleFormat ] = "s32";
 	wave24b48kMono[ Profile::avProfileSampleRate ] = "48000";
 	wave24b48kMono[ Profile::avProfileChannel ] = "1";
-	wave24b48kMono[ Profile::avProfileChannelLayout ] = "1";
 
 	Profile::ProfileDesc wave16b48kMono;
 
@@ -28,7 +27,6 @@ void loadWave( Profile::ProfilesDesc& profiles )
 	wave16b48kMono[ Profile::avProfileSampleFormat ] = "s16";
 	wave16b48kMono[ Profile::avProfileSampleRate ] = "48000";
 	wave16b48kMono[ Profile::avProfileChannel ] = "1";
-	wave16b48kMono[ Profile::avProfileChannelLayout ] = "1";
 
 	profiles.push_back( wave24b48kMono );
 	profiles.push_back( wave16b48kMono );
