VideoProperties: fixed getDuration if cannot compute the bitrate

Clement Champetier · Clement Champetier · commit 75620c0954ae · 2016-06-20T18:33:51.000+02:00
Avoid 'Arithmetic exception'.
diff --git a/src/AvTranscoder/properties/VideoProperties.cpp b/src/AvTranscoder/properties/VideoProperties.cpp
@@ -473,8 +473,12 @@ float VideoProperties::getDuration() const
         LOG_WARN("The duration of the stream '" << _streamIndex << "' of file '" << _formatContext->filename << "' is unknown.")
         if(_fileProperties->isRawFormat())
         {
-            LOG_INFO("Get the file size to compute the duration.")
-            return _fileProperties->getFileSize() / getBitRate() * 8;
+            const size_t bitRate = getBitRate();
+            if(bitRate)
+            {
+                LOG_INFO("Get the file size to compute the duration.")
+                return _fileProperties->getFileSize() / bitRate * 8;
+            }
         }
         return 0;
     }
diff --git a/src/AvTranscoder/properties/VideoProperties.hpp b/src/AvTranscoder/properties/VideoProperties.hpp
@@ -40,7 +40,7 @@ class AvExport VideoProperties : public StreamProperties
     Rational getSar() const; // sample/pixel aspect ratio
     Rational getDar() const; // display aspect ratio
 
-    size_t getBitRate() const; ///< in bits/s
+    size_t getBitRate() const; ///< in bits/s, 0 if unknown
     size_t getMaxBitRate() const;
     size_t getMinBitRate() const;
     size_t getNbFrames() const; ///< 0 if unknown

Original file line number	Diff line number	Diff line change
`@@ -473,8 +473,12 @@ float VideoProperties::getDuration() const`
`473`	`473`	`LOG_WARN("The duration of the stream '" << _streamIndex << "' of file '" << _formatContext->filename << "' is unknown.")`
`474`	`474`	`if(_fileProperties->isRawFormat())`
`475`	`475`	`{`
`476`		`- LOG_INFO("Get the file size to compute the duration.")`
`477`		`- return _fileProperties->getFileSize() / getBitRate() * 8;`
	`476`	`+ const size_t bitRate = getBitRate();`
	`477`	`+ if(bitRate)`
	`478`	`+ {`
	`479`	`+ LOG_INFO("Get the file size to compute the duration.")`
	`480`	`+ return _fileProperties->getFileSize() / bitRate * 8;`
	`481`	`+ }`
`478`	`482`	`}`
`479`	`483`	`return 0;`
`480`	`484`	`}`