Skip to content

Commit 78eb624

Browse files
author
Clement Champetier
committed
StreamTranscoder: rename setInfinityStream to canSwitchToGenerator
1 parent 6a1d191 commit 78eb624

File tree

3 files changed

+18
-14
lines changed

3 files changed

+18
-14
lines changed

src/AvTranscoder/transcoder/StreamTranscoder.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@ StreamTranscoder::StreamTranscoder(
3737
, _frameProcessed( 0 )
3838
, _offset( 0 )
3939
, _takeFromGenerator( false )
40+
, _canSwitchToGenerator( false )
4041
, _verbose( false )
4142
, _offsetPassed( false )
42-
, _infinityStream( false )
4343
{
4444
// create a re-wrapping case
4545
switch( _inputStream->getStreamType() )
@@ -84,9 +84,9 @@ StreamTranscoder::StreamTranscoder(
8484
, _frameProcessed( 0 )
8585
, _offset( offset )
8686
, _takeFromGenerator( false )
87+
, _canSwitchToGenerator( false )
8788
, _verbose( false )
8889
, _offsetPassed( false )
89-
, _infinityStream( false )
9090
{
9191
// create a transcode case
9292
switch( _inputStream->getStreamType() )
@@ -184,9 +184,9 @@ StreamTranscoder::StreamTranscoder(
184184
, _frameProcessed( 0 )
185185
, _offset( 0 )
186186
, _takeFromGenerator( false )
187+
, _canSwitchToGenerator( false )
187188
, _verbose( false )
188189
, _offsetPassed( false )
189-
, _infinityStream( false )
190190
{
191191
if( profile.find( constants::avProfileType )->second == constants::avProfileTypeVideo )
192192
{
@@ -336,7 +336,7 @@ bool StreamTranscoder::processTranscode( const int subStreamIndex )
336336
if( _offset &&
337337
_frameProcessed > _offset &&
338338
! _offsetPassed &&
339-
_takeFromGenerator )
339+
_canSwitchToGenerator )
340340
{
341341
switchToInputDecoder();
342342
_offsetPassed = true;
@@ -364,7 +364,7 @@ bool StreamTranscoder::processTranscode( const int subStreamIndex )
364364
std::cout << "encode last frame(s)" << std::endl;
365365
if( ! _outputEncoder->encodeFrame( data ) )
366366
{
367-
if( _infinityStream )
367+
if( _canSwitchToGenerator )
368368
{
369369
switchToGeneratorDecoder();
370370
return processTranscode();

src/AvTranscoder/transcoder/StreamTranscoder.hpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,11 @@ class AvExport StreamTranscoder
7070

7171
void setVerbose( bool verbose = true ){ _verbose = verbose; }
7272

73-
void setInfinityStream( bool isInfinity ) { _infinityStream = isInfinity; }
73+
/**
74+
* @brief Returns if the stream can switch to a generator when ended
75+
* @note Not applicable for rewrap and generator cases
76+
*/
77+
void canSwitchToGenerator( bool canSwitch ) { _canSwitchToGenerator = canSwitch; }
7478

7579
void setOffset( bool offset = true ){ _offset = offset; }
7680

@@ -98,9 +102,9 @@ class AvExport StreamTranscoder
98102
size_t _offset; ///< Offset, in frame, at the beginning of the StreamTranscoder.
99103

100104
bool _takeFromGenerator; ///< Is the data processed are taken from a generator.
105+
bool _canSwitchToGenerator; ///< Automatically switch to a generator at the end of the stream
101106
bool _verbose;
102107
bool _offsetPassed; ///< Is the offset at the beginning of the stream is finished.
103-
bool _infinityStream; ///< Automatically switch to a generator at the end of the stream (not applicable when rewrap);
104108
};
105109

106110
}

src/AvTranscoder/transcoder/Transcoder.cpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -502,24 +502,24 @@ void Transcoder::manageInfinityStreamFromProcessMethod()
502502
{
503503
case eProcessMethodShortest :
504504
if( _streamTranscoders.at( i )->getDuration() == getMinTotalDuration() )
505-
_streamTranscoders.at( i )->setInfinityStream( false );
505+
_streamTranscoders.at( i )->canSwitchToGenerator( false );
506506
else
507-
_streamTranscoders.at( i )->setInfinityStream( true );
507+
_streamTranscoders.at( i )->canSwitchToGenerator( true );
508508
break;
509509
case eProcessMethodLongest :
510510
if( _streamTranscoders.at( i )->getDuration() == getMaxTotalDuration() )
511-
_streamTranscoders.at( i )->setInfinityStream( false );
511+
_streamTranscoders.at( i )->canSwitchToGenerator( false );
512512
else
513-
_streamTranscoders.at( i )->setInfinityStream( true );
513+
_streamTranscoders.at( i )->canSwitchToGenerator( true );
514514
break;
515515
case eProcessMethodBasedOnStream :
516516
if( i != _mainStreamIndex )
517-
_streamTranscoders.at( i )->setInfinityStream( true );
517+
_streamTranscoders.at( i )->canSwitchToGenerator( true );
518518
else
519-
_streamTranscoders.at( i )->setInfinityStream( false );
519+
_streamTranscoders.at( i )->canSwitchToGenerator( false );
520520
break;
521521
case eProcessMethodInfinity :
522-
_streamTranscoders.at( i )->setInfinityStream( true );
522+
_streamTranscoders.at( i )->canSwitchToGenerator( true );
523523
break;
524524
}
525525
}

0 commit comments

Comments
 (0)