Skip to content

Commit 7a4bf34

Browse files
committed
Merge pull request #266 from cchampet/cmake_checkFFmbc
CMake: clean after checked integration with ffmbc
2 parents b5330b0 + 39c3e18 commit 7a4bf34

File tree

3 files changed

+17
-17
lines changed

3 files changed

+17
-17
lines changed

cmake/AvTranscoderMacros.cmake

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,16 @@ file(GLOB_RECURSE AVTRANSCODER_SRC_FILES "AvTranscoder/*.cpp" "AvTranscoder/*.hp
1010
# AVTRANSCODER_VERSION
1111
file(STRINGS "${AVTRANSCODER_SRC_PATH}/AvTranscoder/common.hpp" _avtranscoder_VERSION_HPP_CONTENTS REGEX "#define AVTRANSCODER_VERSION_")
1212
foreach(v MAJOR MINOR MICRO)
13-
if("${_avtranscoder_VERSION_HPP_CONTENTS}" MATCHES "#define AVTRANSCODER_VERSION_${v} ([0-9]+)")
14-
set(AVTRANSCODER_VERSION_${v} "${CMAKE_MATCH_1}")
15-
else()
16-
set(AVTRANSCODER_RETRIEVE_VERSION_FAILED 1)
17-
endif()
13+
if("${_avtranscoder_VERSION_HPP_CONTENTS}" MATCHES "#define AVTRANSCODER_VERSION_${v} ([0-9]+)")
14+
set(AVTRANSCODER_VERSION_${v} "${CMAKE_MATCH_1}")
15+
else()
16+
set(AVTRANSCODER_RETRIEVE_VERSION_FAILED 1)
17+
endif()
1818
endforeach()
1919
unset(_avtranscoder_VERSION_HPP_CONTENTS)
2020

2121
set(AVTRANSCODER_VERSION "${AVTRANSCODER_VERSION_MAJOR}.${AVTRANSCODER_VERSION_MINOR}.${AVTRANSCODER_VERSION_MICRO}")
2222

2323
if(AVTRANSCODER_RETRIEVE_VERSION_FAILED)
24-
message(SEND_ERROR "Failed to retrieve AvTranscoder version: ${AVTRANSCODER_VERSION}")
24+
message(SEND_ERROR "Failed to retrieve AvTranscoder version: ${AVTRANSCODER_VERSION}")
2525
endif()

cmake/FindFFmpeg.cmake

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,9 @@ macro(manage_components)
100100
set(FFMPEG_INCLUDE_DIR ${${COMPONENT}_INCLUDE_DIR})
101101
set(FFMPEG_LIBRARIES ${FFMPEG_LIBRARIES} ${${COMPONENT}_LIBRARIES})
102102
set(FFMPEG_DEFINITIONS ${FFMPEG_DEFINITIONS} ${${COMPONENT}_DEFINITIONS})
103-
else()
104-
set(${COMPONENT}_FOUND FALSE)
103+
else()
104+
message(STATUS "Skip ${COMPONENT} component because it was found elsewhere ('${${COMPONENT}_INCLUDE_DIR}' instead of '${FFMPEG_INCLUDE_DIR}').")
105+
set(${COMPONENT}_FOUND FALSE)
105106
endif()
106107
else()
107108
if(FFmpeg_FIND_REQUIRED)
@@ -121,12 +122,12 @@ endmacro()
121122

122123
# Check FFmpeg version
123124
if(DEFINED FFmpeg_FIND_VERSION)
124-
check_ffmpeg_version()
125+
check_ffmpeg_version()
125126
endif()
126127

127128
# Get basic components if no one is indicated
128129
if(NOT FFmpeg_FIND_COMPONENTS)
129-
set(FFmpeg_FIND_COMPONENTS avcodec avformat avutil)
130+
set(FFmpeg_FIND_COMPONENTS avcodec avformat avutil)
130131
endif()
131132

132133
# Check each component

src/CMakeLists.txt

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@ message(STATUS "AvTranscoder version is ${AVTRANSCODER_VERSION}")
99
find_package(FFmpeg COMPONENTS avcodec avformat avutil swscale swresample avresample)
1010
if(swresample_FOUND)
1111
add_definitions(-DAVTRANSCODER_FFMPEG_DEPENDENCY)
12-
message(STATUS "Build avTranscoder with dependency to ffmpeg.")
12+
message(STATUS "Build avTranscoder with dependency to ffmpeg.")
1313
elseif(avresample_FOUND)
1414
add_definitions(-DAVTRANSCODER_LIBAV_DEPENDENCY)
1515
message(STATUS "Build avTranscoder with dependency to libav.")
1616
else()
17-
message(SEND_ERROR "Can't define if you depend on ffmpeg or libav.")
17+
message(SEND_ERROR "Can't define if you depend on ffmpeg or libav.")
1818
endif()
1919

2020
# Include AvTranscoder and FFmpeg
@@ -38,8 +38,7 @@ set_target_properties(avtranscoder-shared PROPERTIES SOVERSION ${AVTRANSCODER_VE
3838
set_target_properties(avtranscoder-shared PROPERTIES VERSION ${AVTRANSCODER_VERSION})
3939
set_target_properties(avtranscoder-shared PROPERTIES INSTALL_RPATH_USE_LINK_PATH 1)
4040
target_link_libraries(avtranscoder-shared ${FFMPEG_LIBRARIES})
41-
target_include_directories(avtranscoder-shared PUBLIC
42-
${AVTRANSCODER_SRC_PATH} ${FFMPEG_INCLUDE_DIR})
41+
target_include_directories(avtranscoder-shared PUBLIC ${AVTRANSCODER_SRC_PATH} ${FFMPEG_INCLUDE_DIR})
4342

4443

4544
### Install AvTranscoder libs and include
@@ -120,12 +119,12 @@ if(SWIG_FOUND)
120119
else()
121120
message("PYTHON not found, will not build python binding.")
122121
endif()
123-
endif()
122+
endif()
124123

125124
### JAVA BINDING
126-
if(AVTRANSCODER_DISABLE_JAVA_BINDING)
125+
if(AVTRANSCODER_DISABLE_JAVA_BINDING)
127126
message("JAVA binding disabled, will not build java binding.")
128-
else()
127+
else()
129128
find_package(Java)
130129
find_package(JNI)
131130
if(JAVA_FOUND AND JNI_FOUND)

0 commit comments

Comments
 (0)