IReader: refactore instructions if decoding failed

Clement Champetier · Clement Champetier · commit 7dd618a4a23d · 2016-03-30T18:49:25.000+02:00
Avoid 'if not'/'else': 'if'/'else' is easier.
diff --git a/src/AvTranscoder/reader/IReader.cpp b/src/AvTranscoder/reader/IReader.cpp
@@ -76,15 +76,15 @@ Frame* IReader::readFrameAt(const size_t frame)
     // if decoding failed
     if(!decodingStatus)
     {
-        // return an empty frame
-        if(!_continueWithGenerator)
+        // generate data (ie silence or black)
+        if(_continueWithGenerator)
         {
-            return &_emptyFrame;
+            _generator->decodeNextFrame(*_srcFrame);
         }
-        // or generate data (ie silence or black)
+        // or return an empty frame
         else
         {
-           _generator->decodeNextFrame(*_srcFrame);
+           return &_emptyFrame;
         }
     }
     // transform

Original file line number	Diff line number	Diff line change
`@@ -76,15 +76,15 @@ Frame* IReader::readFrameAt(const size_t frame)`
`76`	`76`	`// if decoding failed`
`77`	`77`	`if(!decodingStatus)`
`78`	`78`	`{`
`79`		`- // return an empty frame`
`80`		`- if(!_continueWithGenerator)`
	`79`	`+ // generate data (ie silence or black)`
	`80`	`+ if(_continueWithGenerator)`
`81`	`81`	`{`
`82`		`- return &_emptyFrame;`
	`82`	`+ _generator->decodeNextFrame(*_srcFrame);`
`83`	`83`	`}`
`84`		`- // or generate data (ie silence or black)`
	`84`	`+ // or return an empty frame`
`85`	`85`	`else`
`86`	`86`	`{`
`87`		`- _generator->decodeNextFrame(*_srcFrame);`
	`87`	`+ return &_emptyFrame;`
`88`	`88`	`}`
`89`	`89`	`}`
`90`	`90`	`// transform`