Skip to content

Commit 8c33526

Browse files
author
Clement Champetier
committed
mediaProperty: rename 'getPropertiesAsVector/Map/Json' methods to 'asVector/Map/Json'
1 parent f5ef5d1 commit 8c33526

14 files changed

+43
-43
lines changed

app/avMeta/avMeta.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ int main( int argc, char** argv )
5050

5151
// display file properties
5252
if( toJson )
53-
std::cout << input.getProperties().getPropertiesAsJson() << std::endl;
53+
std::cout << input.getProperties().asJson() << std::endl;
5454
else
5555
std::cout << input;
5656
}

src/AvTranscoder/mediaProperty/AudioProperties.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,12 +173,12 @@ size_t AudioProperties::getTicksPerFrame() const
173173
return _codecContext->ticks_per_frame;
174174
}
175175

176-
PropertyVector AudioProperties::getPropertiesAsVector() const
176+
PropertyVector AudioProperties::asVector() const
177177
{
178178
PropertyVector data;
179179

180180
// Add properties of base class
181-
PropertyVector basedProperty = StreamProperties::getPropertiesAsVector();
181+
PropertyVector basedProperty = StreamProperties::asVector();
182182
data.insert( data.begin(), basedProperty.begin(), basedProperty.end() );
183183

184184
addProperty( data, "codecId", &AudioProperties::getCodecId );

src/AvTranscoder/mediaProperty/AudioProperties.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class AvExport AudioProperties : public StreamProperties
3333
AVCodecContext& getAVCodecContext() { return *_codecContext; }
3434
#endif
3535

36-
PropertyVector getPropertiesAsVector() const;
36+
PropertyVector asVector() const;
3737

3838
private:
3939
#ifndef SWIG

src/AvTranscoder/mediaProperty/FileProperties.cpp

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ size_t FileProperties::getNbStreams() const
207207
return _avFormatContext->nb_streams;
208208
}
209209

210-
PropertyVector FileProperties::getPropertiesAsVector() const
210+
PropertyVector FileProperties::asVector() const
211211
{
212212
PropertyVector data;
213213

@@ -236,11 +236,11 @@ PropertyVector FileProperties::getPropertiesAsVector() const
236236
return data;
237237
}
238238

239-
PropertyMap FileProperties::getPropertiesAsMap() const
239+
PropertyMap FileProperties::asMap() const
240240
{
241241
PropertyMap dataMap;
242242

243-
PropertyVector dataVector( getPropertiesAsVector() );
243+
PropertyVector dataVector( asVector() );
244244
for( PropertyVector::const_iterator it = dataVector.begin();
245245
it != dataVector.end();
246246
++it )
@@ -251,13 +251,13 @@ PropertyMap FileProperties::getPropertiesAsMap() const
251251
return dataMap;
252252
}
253253

254-
std::string FileProperties::getPropertiesAsJson() const
254+
std::string FileProperties::asJson() const
255255
{
256256
json::JsonObjectStreamWriter writer;
257257
{
258258
// format
259259
json::JsonArrayStreamWriter array;
260-
PropertyMap properties = getPropertiesAsMap();
260+
PropertyMap properties = asMap();
261261
json::JsonObjectStreamWriter format;
262262
for(PropertyMap::iterator it = properties.begin(); it != properties.end(); ++it)
263263
format << std::make_pair(it->first.c_str(), it->second.c_str());
@@ -269,7 +269,7 @@ std::string FileProperties::getPropertiesAsJson() const
269269
json::JsonArrayStreamWriter video;
270270
for( std::vector< avtranscoder::VideoProperties >::const_iterator it = _videoStreams.begin(); it != _videoStreams.end(); ++it )
271271
{
272-
video << it->getPropertiesAsJson();
272+
video << it->asJson();
273273
}
274274
writer << std::make_pair("video", video.build());
275275
}
@@ -278,7 +278,7 @@ std::string FileProperties::getPropertiesAsJson() const
278278
json::JsonArrayStreamWriter audio;
279279
for( std::vector< avtranscoder::AudioProperties >::const_iterator it = _audioStreams.begin(); it != _audioStreams.end(); ++it )
280280
{
281-
audio << it->getPropertiesAsJson();
281+
audio << it->asJson();
282282
}
283283
writer << std::make_pair("audio", audio.build());
284284
}
@@ -287,7 +287,7 @@ std::string FileProperties::getPropertiesAsJson() const
287287
json::JsonArrayStreamWriter data;
288288
for( std::vector< avtranscoder::DataProperties >::const_iterator it = _dataStreams.begin(); it != _dataStreams.end(); ++it )
289289
{
290-
data << it->getPropertiesAsJson();
290+
data << it->asJson();
291291
}
292292
writer << std::make_pair("data", data.build());
293293
}
@@ -296,7 +296,7 @@ std::string FileProperties::getPropertiesAsJson() const
296296
json::JsonArrayStreamWriter subtitle;
297297
for( std::vector< avtranscoder::SubtitleProperties >::const_iterator it = _subtitleStreams.begin(); it != _subtitleStreams.end(); ++it )
298298
{
299-
subtitle << it->getPropertiesAsJson();
299+
subtitle << it->asJson();
300300
}
301301
writer << std::make_pair("subtitle", subtitle.build());
302302
}
@@ -305,7 +305,7 @@ std::string FileProperties::getPropertiesAsJson() const
305305
json::JsonArrayStreamWriter attachement;
306306
for( std::vector< avtranscoder::AttachementProperties >::const_iterator it = _attachementStreams.begin(); it != _attachementStreams.end(); ++it )
307307
{
308-
attachement << it->getPropertiesAsJson();
308+
attachement << it->asJson();
309309
}
310310
writer << std::make_pair("attachement", attachement.build());
311311
}
@@ -314,7 +314,7 @@ std::string FileProperties::getPropertiesAsJson() const
314314
json::JsonArrayStreamWriter unknown;
315315
for( std::vector< avtranscoder::UnknownProperties >::const_iterator it = _unknownStreams.begin(); it != _unknownStreams.end(); ++it )
316316
{
317-
unknown << it->getPropertiesAsJson();
317+
unknown << it->asJson();
318318
}
319319
writer << std::make_pair("unknown", unknown.build());
320320
}

src/AvTranscoder/mediaProperty/FileProperties.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,9 @@ class AvExport FileProperties
8181
const AVFormatContext& getAVFormatContext() { return *_avFormatContext; }
8282
#endif
8383

84-
std::string getPropertiesAsJson() const; ///< Return all properties as a json format.
85-
PropertyMap getPropertiesAsMap() const; ///< Return format properties as a map (name of property, value)
86-
PropertyVector getPropertiesAsVector() const; ///< Return format properties as a vector (name of property: value)
84+
std::string asJson() const; ///< Return all properties as a json format.
85+
PropertyMap asMap() const; ///< Return format properties as a map (name of property, value)
86+
PropertyVector asVector() const; ///< Return format properties as a vector (name of property: value)
8787

8888
private:
8989
#ifndef SWIG

src/AvTranscoder/mediaProperty/PixelProperties.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ std::vector<Channel> PixelProperties::getChannels() const
238238
return channels;
239239
}
240240

241-
PropertyVector PixelProperties::getPropertiesAsVector() const
241+
PropertyVector PixelProperties::asVector() const
242242
{
243243
PropertyVector data;
244244

src/AvTranscoder/mediaProperty/PixelProperties.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ class AvExport PixelProperties
8080
const AVPixFmtDescriptor* getAVPixFmtDescriptor() const { return _pixelDesc; }
8181
#endif
8282

83-
PropertyVector getPropertiesAsVector() const; ///< Return all pixel properties as a vector (name of property: value)
83+
PropertyVector asVector() const; ///< Return all pixel properties as a vector (name of property: value)
8484

8585
private:
8686
void init( const AVPixelFormat avPixelFormat );

src/AvTranscoder/mediaProperty/StreamProperties.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ AVMediaType StreamProperties::getStreamType() const
4747
return _formatContext->streams[_streamIndex]->codec->codec_type;
4848
}
4949

50-
PropertyVector StreamProperties::getPropertiesAsVector() const
50+
PropertyVector StreamProperties::asVector() const
5151
{
5252
PropertyVector data;
5353

@@ -64,11 +64,11 @@ PropertyVector StreamProperties::getPropertiesAsVector() const
6464
return data;
6565
}
6666

67-
PropertyMap StreamProperties::getPropertiesAsMap() const
67+
PropertyMap StreamProperties::asMap() const
6868
{
6969
PropertyMap dataMap;
7070

71-
PropertyVector dataVector( getPropertiesAsVector() );
71+
PropertyVector dataVector( asVector() );
7272
for( PropertyVector::const_iterator it = dataVector.begin();
7373
it != dataVector.end();
7474
++it )
@@ -79,10 +79,10 @@ PropertyMap StreamProperties::getPropertiesAsMap() const
7979
return dataMap;
8080
}
8181

82-
std::string StreamProperties::getPropertiesAsJson() const
82+
std::string StreamProperties::asJson() const
8383
{
8484
json::JsonObjectStreamWriter writer;
85-
PropertyMap properties = getPropertiesAsMap();
85+
PropertyMap properties = asMap();
8686
for(PropertyMap::iterator it = properties.begin(); it != properties.end(); ++it)
8787
writer << std::make_pair(it->first.c_str(), it->second.c_str());
8888
return writer.build();

src/AvTranscoder/mediaProperty/StreamProperties.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ class AvExport StreamProperties
2626
const AVFormatContext& getAVFormatContext() const { return *_formatContext; }
2727
#endif
2828

29-
std::string getPropertiesAsJson() const; ///< Return all properties as a json format.
30-
PropertyMap getPropertiesAsMap() const; ///< Return all properties as a map (name of property, value)
31-
virtual PropertyVector getPropertiesAsVector() const; ///< Same data with a specific order
29+
std::string asJson() const; ///< Return all properties as a json format.
30+
PropertyMap asMap() const; ///< Return all properties as a map (name of property, value)
31+
virtual PropertyVector asVector() const; ///< Same data with a specific order
3232

3333
private:
3434
#ifndef SWIG

src/AvTranscoder/mediaProperty/VideoProperties.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -598,12 +598,12 @@ void VideoProperties::analyseGopStructure( IProgress& progress )
598598
}
599599
}
600600

601-
PropertyVector VideoProperties::getPropertiesAsVector() const
601+
PropertyVector VideoProperties::asVector() const
602602
{
603603
PropertyVector data;
604604

605605
// Add properties of base class
606-
PropertyVector basedProperty = StreamProperties::getPropertiesAsVector();
606+
PropertyVector basedProperty = StreamProperties::asVector();
607607
data.insert( data.begin(), basedProperty.begin(), basedProperty.end() );
608608

609609
addProperty( data, "codecId", &VideoProperties::getCodecId );
@@ -647,7 +647,7 @@ PropertyVector VideoProperties::getPropertiesAsVector() const
647647
addProperty( data, "referencesFrames", &VideoProperties::getReferencesFrames );
648648

649649
// Add properties of the pixel
650-
PropertyVector pixelProperties = _pixelProperties.getPropertiesAsVector();
650+
PropertyVector pixelProperties = _pixelProperties.asVector();
651651
data.insert( data.end(), pixelProperties.begin(), pixelProperties.end() );
652652

653653
return data;

src/AvTranscoder/mediaProperty/VideoProperties.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ class AvExport VideoProperties : public StreamProperties
8181
const PixelProperties& getPixelProperties() const { return _pixelProperties; }
8282
#endif
8383

84-
PropertyVector getPropertiesAsVector() const;
84+
PropertyVector asVector() const;
8585

8686
private:
8787
/**

src/AvTranscoder/mediaProperty/print.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ std::ostream& operator<<( std::ostream& flux, const FileProperties& fileProperti
1515
flux << std::left;
1616
flux << separator << " Wrapper " << separator << std::endl;
1717

18-
PropertyVector properties = fileProperties.getPropertiesAsVector();
18+
PropertyVector properties = fileProperties.asVector();
1919
for( PropertyVector::iterator it = properties.begin(); it != properties.end(); ++it )
2020
{
2121
flux << std::setw( keyWidth ) << it->first << ": " << it->second << std::endl;
@@ -29,7 +29,7 @@ std::ostream& operator<<( std::ostream& flux, const StreamProperties& streamProp
2929
flux << std::left;
3030
flux << separator << " Stream " << separator << std::endl;
3131

32-
PropertyVector properties = streamProperties.getPropertiesAsVector();
32+
PropertyVector properties = streamProperties.asVector();
3333
for( PropertyVector::iterator it = properties.begin(); it != properties.end(); ++it )
3434
{
3535
flux << std::setw( keyWidth ) << it->first << ": " << it->second << std::endl;
@@ -43,7 +43,7 @@ std::ostream& operator<<( std::ostream& flux, const VideoProperties& videoProper
4343
flux << std::left;
4444
flux << separator << " Video stream " << separator << std::endl;
4545

46-
PropertyVector properties = videoProperties.getPropertiesAsVector();
46+
PropertyVector properties = videoProperties.asVector();
4747
for( PropertyVector::iterator it = properties.begin(); it != properties.end(); ++it )
4848
{
4949
flux << std::setw( keyWidth ) << it->first << ": " << it->second << std::endl;
@@ -57,7 +57,7 @@ std::ostream& operator<<( std::ostream& flux, const AudioProperties& audioProper
5757
flux << std::left;
5858
flux << separator << " Audio stream " << separator << std::endl;
5959

60-
PropertyVector properties = audioProperties.getPropertiesAsVector();
60+
PropertyVector properties = audioProperties.asVector();
6161
for( PropertyVector::iterator it = properties.begin(); it != properties.end(); ++it )
6262
{
6363
flux << std::setw( keyWidth ) << it->first << ": " << it->second << std::endl;
@@ -70,7 +70,7 @@ std::ostream& operator<<( std::ostream& flux, const DataProperties& dataProperti
7070
{
7171
flux << separator << " Data stream " << separator << std::endl;
7272

73-
PropertyVector properties = dataProperties.getPropertiesAsVector();
73+
PropertyVector properties = dataProperties.asVector();
7474
for( PropertyVector::iterator it = properties.begin(); it != properties.end(); ++it )
7575
{
7676
flux << std::setw( keyWidth ) << it->first << ": " << it->second << std::endl;
@@ -83,7 +83,7 @@ std::ostream& operator<<( std::ostream& flux, const SubtitleProperties& subtitle
8383
{
8484
flux << separator << " Subtitle stream " << separator << std::endl;
8585

86-
PropertyVector properties = subtitleProperties.getPropertiesAsVector();
86+
PropertyVector properties = subtitleProperties.asVector();
8787
for( PropertyVector::iterator it = properties.begin(); it != properties.end(); ++it )
8888
{
8989
flux << std::setw( keyWidth ) << it->first << ": " << it->second << std::endl;
@@ -96,7 +96,7 @@ std::ostream& operator<<( std::ostream& flux, const AttachementProperties& attac
9696
{
9797
flux << separator << " Attachement stream " << separator << std::endl;
9898

99-
PropertyVector properties = attachementProperties.getPropertiesAsVector();
99+
PropertyVector properties = attachementProperties.asVector();
100100
for( PropertyVector::iterator it = properties.begin(); it != properties.end(); ++it )
101101
{
102102
flux << std::setw( keyWidth ) << it->first << ": " << it->second << std::endl;
@@ -109,7 +109,7 @@ std::ostream& operator<<( std::ostream& flux, const UnknownProperties& unknownPr
109109
{
110110
flux << separator << " Unknown stream " << separator << std::endl;
111111

112-
PropertyVector properties = unknownProperties.getPropertiesAsVector();
112+
PropertyVector properties = unknownProperties.asVector();
113113
for( PropertyVector::iterator it = properties.begin(); it != properties.end(); ++it )
114114
{
115115
flux << std::setw( keyWidth ) << it->first << ": " << it->second << std::endl;

test/pyTest/testProperties.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,6 @@ def testCheckFilePropertiesAsJson():
139139

140140
import json
141141
# throw exception if it is not a valid JSON
142-
json.loads(inputFile.getProperties().getPropertiesAsJson())
142+
json.loads(inputFile.getProperties().asJson())
143143

144144

test/pyTest/testTranscoderRewrap.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ def checkStream(src_stream, dst_stream):
3131
"""
3232
Check the values of the given streams properties.
3333
"""
34-
src_propertiesMap = src_stream.getPropertiesAsMap()
35-
dst_propertiesMap = dst_stream.getPropertiesAsMap()
34+
src_propertiesMap = src_stream.asMap()
35+
dst_propertiesMap = dst_stream.asMap()
3636
for key in dst_propertiesMap:
3737
# skip metadata of stream
3838
if key in [x[0] for x in src_stream.getMetadatas()]:

0 commit comments

Comments
 (0)