InputFile: refactore analyse

Clement Champetier · Clement Champetier · commit 9cb1b2d3d680 · 2014-11-17T14:19:15.000+01:00
Split properties nstantiation into 2 lines: better for debugging with
breakpoint and easier to read.
diff --git a/src/AvTranscoder/file/InputFile.cpp b/src/AvTranscoder/file/InputFile.cpp
@@ -79,32 +79,38 @@ InputFile& InputFile::analyse( IProgress& progress, const EAnalyseLevel level )
 		{
 			case AVMEDIA_TYPE_VIDEO:
 			{
-				_properties.getVideoProperties().push_back( VideoProperties( _formatContext, streamId, progress, level ) );
+				VideoProperties properties( _formatContext, streamId, progress, level );
+				_properties.getVideoProperties().push_back( properties );
 				break;
 			}
 			case AVMEDIA_TYPE_AUDIO:
 			{
-				_properties.getAudioProperties().push_back( AudioProperties( _formatContext, streamId ) );
+				AudioProperties properties( _formatContext, streamId );
+				_properties.getAudioProperties().push_back( properties );
 				break;
 			}
 			case AVMEDIA_TYPE_DATA:
 			{
-				_properties.getDataProperties().push_back( DataProperties( _formatContext, streamId ) );
+				DataProperties properties( _formatContext, streamId );
+				_properties.getDataProperties().push_back( properties );
 				break;
 			}
 			case AVMEDIA_TYPE_SUBTITLE:
 			{
-				_properties.getSubtitleProperties().push_back( SubtitleProperties( _formatContext, streamId ) );
+				SubtitleProperties properties( _formatContext, streamId );
+				_properties.getSubtitleProperties().push_back( properties );
 				break;
 			}
 			case AVMEDIA_TYPE_ATTACHMENT:
 			{
-				_properties.getAttachementProperties().push_back( AttachementProperties( _formatContext, streamId ) );
+				AttachementProperties properties( _formatContext, streamId );
+				_properties.getAttachementProperties().push_back( properties );
 				break;
 			}
 			case AVMEDIA_TYPE_UNKNOWN:
 			{
-				_properties.getUnknownPropertiesProperties().push_back( UnknownProperties( _formatContext, streamId ) );
+				UnknownProperties properties( _formatContext, streamId );
+				_properties.getUnknownPropertiesProperties().push_back( properties );
 				break;
 			}
 			case AVMEDIA_TYPE_NB:

Original file line number	Diff line number	Diff line change
`@@ -79,32 +79,38 @@ InputFile& InputFile::analyse( IProgress& progress, const EAnalyseLevel level )`
`79`	`79`	`{`
`80`	`80`	`case AVMEDIA_TYPE_VIDEO:`
`81`	`81`	`{`
`82`		`- _properties.getVideoProperties().push_back( VideoProperties( _formatContext, streamId, progress, level ) );`
	`82`	`+ VideoProperties properties( _formatContext, streamId, progress, level );`
	`83`	`+ _properties.getVideoProperties().push_back( properties );`
`83`	`84`	`break;`
`84`	`85`	`}`
`85`	`86`	`case AVMEDIA_TYPE_AUDIO:`
`86`	`87`	`{`
`87`		`- _properties.getAudioProperties().push_back( AudioProperties( _formatContext, streamId ) );`
	`88`	`+ AudioProperties properties( _formatContext, streamId );`
	`89`	`+ _properties.getAudioProperties().push_back( properties );`
`88`	`90`	`break;`
`89`	`91`	`}`
`90`	`92`	`case AVMEDIA_TYPE_DATA:`
`91`	`93`	`{`
`92`		`- _properties.getDataProperties().push_back( DataProperties( _formatContext, streamId ) );`
	`94`	`+ DataProperties properties( _formatContext, streamId );`
	`95`	`+ _properties.getDataProperties().push_back( properties );`
`93`	`96`	`break;`
`94`	`97`	`}`
`95`	`98`	`case AVMEDIA_TYPE_SUBTITLE:`
`96`	`99`	`{`
`97`		`- _properties.getSubtitleProperties().push_back( SubtitleProperties( _formatContext, streamId ) );`
	`100`	`+ SubtitleProperties properties( _formatContext, streamId );`
	`101`	`+ _properties.getSubtitleProperties().push_back( properties );`
`98`	`102`	`break;`
`99`	`103`	`}`
`100`	`104`	`case AVMEDIA_TYPE_ATTACHMENT:`
`101`	`105`	`{`
`102`		`- _properties.getAttachementProperties().push_back( AttachementProperties( _formatContext, streamId ) );`
	`106`	`+ AttachementProperties properties( _formatContext, streamId );`
	`107`	`+ _properties.getAttachementProperties().push_back( properties );`
`103`	`108`	`break;`
`104`	`109`	`}`
`105`	`110`	`case AVMEDIA_TYPE_UNKNOWN:`
`106`	`111`	`{`
`107`		`- _properties.getUnknownPropertiesProperties().push_back( UnknownProperties( _formatContext, streamId ) );`
	`112`	`+ UnknownProperties properties( _formatContext, streamId );`
	`113`	`+ _properties.getUnknownPropertiesProperties().push_back( properties );`
`108`	`114`	`break;`
`109`	`115`	`}`
`110`	`116`	`case AVMEDIA_TYPE_NB:`