Video/Audio frames: fix seg fault when process a graph of filters

Clement Champetier · Clement Champetier · commit a5ad30ed75cc · 2016-10-28T17:17:57.000+02:00
We should unref the frames before delete their data.
diff --git a/src/AvTranscoder/data/decoded/AudioFrame.cpp b/src/AvTranscoder/data/decoded/AudioFrame.cpp
@@ -63,6 +63,8 @@ std::string AudioFrame::getChannelLayoutDesc() const
 
 AudioFrame::~AudioFrame()
 {
+    if(_frame->buf[0])
+        av_frame_unref(_frame);
     if(_dataAllocated)
         freeData();
 }
diff --git a/src/AvTranscoder/data/decoded/VideoFrame.cpp b/src/AvTranscoder/data/decoded/VideoFrame.cpp
@@ -59,6 +59,8 @@ VideoFrame::VideoFrame(const VideoFrameDesc& desc, const bool forceDataAllocatio
 
 VideoFrame::~VideoFrame()
 {
+    if(_frame->buf[0])
+        av_frame_unref(_frame);
     if(_dataAllocated)
         freeData();
 }

Original file line number	Diff line number	Diff line change
`@@ -63,6 +63,8 @@ std::string AudioFrame::getChannelLayoutDesc() const`
`63`	`63`
`64`	`64`	`AudioFrame::~AudioFrame()`
`65`	`65`	`{`
	`66`	`+ if(_frame->buf[0])`
	`67`	`+ av_frame_unref(_frame);`
`66`	`68`	`if(_dataAllocated)`
`67`	`69`	`freeData();`
`68`	`70`	`}`
Original file line number	Diff line number	Diff line change
`@@ -59,6 +59,8 @@ VideoFrame::VideoFrame(const VideoFrameDesc& desc, const bool forceDataAllocatio`
`59`	`59`
`60`	`60`	`VideoFrame::~VideoFrame()`
`61`	`61`	`{`
	`62`	`+ if(_frame->buf[0])`
	`63`	`+ av_frame_unref(_frame);`
`62`	`64`	`if(_dataAllocated)`
`63`	`65`	`freeData();`
`64`	`66`	`}`