StreamProperties: fixed access of AVCodecContext properties if several analysis are launched

Clement Champetier · Clement Champetier · commit a90c1e365a24 · 2016-07-12T14:54:50.000+02:00
* There is no need to open/close a codec to access its options.
* This update of the codec state (opened/closed) could be problem if there are transcoding operations after the analysis.
diff --git a/src/AvTranscoder/properties/StreamProperties.cpp b/src/AvTranscoder/properties/StreamProperties.cpp
@@ -38,11 +38,7 @@ StreamProperties::StreamProperties(const FileProperties& fileProperties, const s
         if(_codec)
         {
             // load specific options of the codec
-            if(avcodec_open2(_codecContext, _codec, NULL) == 0)
-            {
-                loadOptions(_options, _codecContext);
-                avcodec_close(_codecContext);
-            }
+            loadOptions(_options, _codecContext);
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -38,11 +38,7 @@ StreamProperties::StreamProperties(const FileProperties& fileProperties, const s`
`38`	`38`	`if(_codec)`
`39`	`39`	`{`
`40`	`40`	`// load specific options of the codec`
`41`		`- if(avcodec_open2(_codecContext, _codec, NULL) == 0)`
`42`		`- {`
`43`		`- loadOptions(_options, _codecContext);`
`44`		`- avcodec_close(_codecContext);`
`45`		`- }`
	`41`	`+ loadOptions(_options, _codecContext);`
`46`	`42`	`}`
`47`	`43`	`}`
`48`	`44`	`}`