IFrame: fix memory leak when calling assignValue

Clement Champetier · Clement Champetier · commit a92879d620b2 · 2016-10-28T11:18:52.000+02:00
* The data buffer of the frame should be freed before allocate a new
buffer.
* The new buffer should be allocated using malloc instead of free, since
ffmpeg/libav uses free to deallocate the data. The valgrind error was:
"Mismatched free() / delete / delete []".
diff --git a/src/AvTranscoder/data/decoded/IFrame.cpp b/src/AvTranscoder/data/decoded/IFrame.cpp
@@ -64,13 +64,19 @@ void IFrame::freeAVFrame()
 
 void IFrame::assignValue(const unsigned char value)
 {
+    // Free the existing data
+    freeData();
+
     // Create the buffer
     const int bufferSize = getSize();
-    unsigned char* dataBuffer = new unsigned char[bufferSize];
+    unsigned char* dataBuffer = static_cast<unsigned char*>(malloc(bufferSize * sizeof(unsigned char)));
     memset(dataBuffer, value, bufferSize);
 
     // Fill the frame
     assignBuffer(dataBuffer);
+
+    // Prepare to free the data
+    _dataAllocated = true;
 }
 
 bool IFrame::isAudioFrame() const
