Transcoder: refactored how to check string parameters when addStream

Clement Champetier · Clement Champetier · commit c18072c153e0 · 2016-07-21T12:48:24.000+02:00
diff --git a/src/AvTranscoder/transcoder/Transcoder.cpp b/src/AvTranscoder/transcoder/Transcoder.cpp
@@ -38,10 +38,10 @@ Transcoder::~Transcoder()
 void Transcoder::addStream(const InputStreamDesc& inputStreamDesc, const std::string& profileName, const float offset)
 {
     // Check filename
-    if(inputStreamDesc._filename.length() == 0)
+    if(inputStreamDesc._filename.empty())
         throw std::runtime_error("Can't process a stream without a filename indicated.");
 
-    if(profileName.length() == 0)
+    if(profileName.empty())
     {
         // Re-wrap
         if(!inputStreamDesc.demultiplexing())

Original file line number	Diff line number	Diff line change
`@@ -38,10 +38,10 @@ Transcoder::~Transcoder()`
`38`	`38`	`void Transcoder::addStream(const InputStreamDesc& inputStreamDesc, const std::string& profileName, const float offset)`
`39`	`39`	`{`
`40`	`40`	`// Check filename`
`41`		`- if(inputStreamDesc._filename.length() == 0)`
	`41`	`+ if(inputStreamDesc._filename.empty())`
`42`	`42`	`throw std::runtime_error("Can't process a stream without a filename indicated.");`
`43`	`43`
`44`		`- if(profileName.length() == 0)`
	`44`	`+ if(profileName.empty())`
`45`	`45`	`{`
`46`	`46`	`// Re-wrap`
`47`	`47`	`if(!inputStreamDesc.demultiplexing())`