VideoProperties: getNbFrames returns 0 if the info is not available

Clement Champetier · Clement Champetier · commit e3968368a7e0 · 2016-06-20T16:31:32.000+02:00
diff --git a/src/AvTranscoder/properties/VideoProperties.cpp b/src/AvTranscoder/properties/VideoProperties.cpp
@@ -396,7 +396,17 @@ size_t VideoProperties::getNbFrames() const
         throw std::runtime_error("unknown format context");
     size_t nbFrames = _formatContext->streams[_streamIndex]->nb_frames;
     if(nbFrames == 0)
-        nbFrames = getFps() * getDuration();
+    {
+        LOG_WARN("The number of frames in the stream '" << _streamIndex << "' of file '" << _formatContext->filename << "' is unknown.")
+        const float duration = getDuration();
+        if(duration != 0)
+        {
+            LOG_INFO("Try to compute the number of frames from the fps and the duration.")
+            nbFrames = getFps() * duration;
+        }
+        else
+            return 0;
+    }
     return nbFrames;
 }
 
diff --git a/src/AvTranscoder/properties/VideoProperties.hpp b/src/AvTranscoder/properties/VideoProperties.hpp
@@ -43,7 +43,7 @@ class AvExport VideoProperties : public StreamProperties
     size_t getBitRate() const; ///< in bits/s
     size_t getMaxBitRate() const;
     size_t getMinBitRate() const;
-    size_t getNbFrames() const;
+    size_t getNbFrames() const; ///< 0 if unknown
     size_t getTicksPerFrame() const;
     size_t getWidth() const;
     size_t getHeight() const;
