OuputFile: allocate AVFormatContext in constructor

Clement Champetier · Clement Champetier · commit effcd7aafa8e · 2014-07-29T10:55:05.000+02:00
* Allocate AVFormatContext in OuputFile's constructor (before the
setup).
* Reason: if setProfile before setup, the AVFormatContext is NULL and so
wa can set no format options.
diff --git a/src/AvTranscoder/File/OutputFile.cpp b/src/AvTranscoder/File/OutputFile.cpp
@@ -26,6 +26,10 @@ OutputFile::OutputFile( const std::string& filename )
 	, _filename      ( filename )
 	, _packetCount   ( 0 )
 {
+	if( ( _formatContext = avformat_alloc_context() ) == NULL )
+	{
+		throw std::runtime_error( "unable to create format context" );
+	}
 }
 
 bool OutputFile::setup()
@@ -38,11 +42,6 @@ bool OutputFile::setup()
 		throw std::runtime_error( "unable to find format" );
 	}
 
-	if( ( _formatContext = avformat_alloc_context() ) == NULL )
-	{
-		throw std::runtime_error( "unable to create format context" );
-	}
-
 	_formatContext->oformat = _outputFormat;
 
 	if( !( _outputFormat->flags & AVFMT_NOFILE ) )

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,10 @@ OutputFile::OutputFile( const std::string& filename )`
`26`	`26`	`, _filename ( filename )`
`27`	`27`	`, _packetCount ( 0 )`
`28`	`28`	`{`
	`29`	`+ if( ( _formatContext = avformat_alloc_context() ) == NULL )`
	`30`	`+ {`
	`31`	`+ throw std::runtime_error( "unable to create format context" );`
	`32`	`+ }`
`29`	`33`	`}`
`30`	`34`
`31`	`35`	`bool OutputFile::setup()`
`@@ -38,11 +42,6 @@ bool OutputFile::setup()`
`38`	`42`	`throw std::runtime_error( "unable to find format" );`
`39`	`43`	`}`
`40`	`44`
`41`		`- if( ( _formatContext = avformat_alloc_context() ) == NULL )`
`42`		`- {`
`43`		`- throw std::runtime_error( "unable to create format context" );`
`44`		`- }`
`45`		`-`
`46`	`45`	`_formatContext->oformat = _outputFormat;`
`47`	`46`
`48`	`47`	`if( !( _outputFormat->flags & AVFMT_NOFILE ) )`