AvInputStream: use std::queue instead of std::vector for stream cache

Valentin Noel · Valentin Noel · commit f5a1b3f0d833 · 2014-12-04T16:13:46.000+01:00
diff --git a/src/AvTranscoder/codedStream/AvInputStream.cpp b/src/AvTranscoder/codedStream/AvInputStream.cpp
@@ -76,7 +76,7 @@ bool AvInputStream::readNextPacket( CodedData& data )
 	if( ! _streamCache.empty() )
 	{
 		_streamCache.front().getBuffer().swap( data.getBuffer() );
-		_streamCache.erase( _streamCache.begin() );
+		_streamCache.pop();
 	}
 	// else read next packet
 	else
@@ -94,7 +94,7 @@ void AvInputStream::addPacket( AVPacket& packet )
 		return;
 
 	CodedData data;
-	_streamCache.push_back( data );
+	_streamCache.push( data );
 	_streamCache.back().getBuffer().resize( packet.size );
 	if( packet.size != 0 )
 		memcpy( _streamCache.back().getPtr(), packet.data, packet.size );
@@ -148,7 +148,7 @@ double AvInputStream::getDuration() const
 
 void AvInputStream::clearBuffering()
 {
-	_streamCache.clear();
+	_streamCache = std::queue<CodedData>();
 }
 
 AVStream* AvInputStream::getAVStream() const
diff --git a/src/AvTranscoder/codedStream/AvInputStream.hpp b/src/AvTranscoder/codedStream/AvInputStream.hpp
@@ -3,6 +3,8 @@
 
 #include "IInputStream.hpp"
 
+#include <queue>
+
 struct AVStream;
 
 namespace avtranscoder
@@ -45,7 +47,7 @@ class AvExport AvInputStream : public IInputStream
 	InputFile* _inputFile;  ///< Has link (no ownership)
 	ICodec* _codec;  ///< Has ownership
 
-	std::vector<CodedData> _streamCache;
+	std::queue<CodedData> _streamCache;
 
 	size_t _streamIndex;  ///<  Index of the stream in the input file
 	bool _bufferized;  ///< If the stream is bufferized

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ bool AvInputStream::readNextPacket( CodedData& data )`
`76`	`76`	`if( ! _streamCache.empty() )`
`77`	`77`	`{`
`78`	`78`	`_streamCache.front().getBuffer().swap( data.getBuffer() );`
`79`		`- _streamCache.erase( _streamCache.begin() );`
	`79`	`+ _streamCache.pop();`
`80`	`80`	`}`
`81`	`81`	`// else read next packet`
`82`	`82`	`else`
`@@ -94,7 +94,7 @@ void AvInputStream::addPacket( AVPacket& packet )`
`94`	`94`	`return;`
`95`	`95`
`96`	`96`	`CodedData data;`
`97`		`- _streamCache.push_back( data );`
	`97`	`+ _streamCache.push( data );`
`98`	`98`	`_streamCache.back().getBuffer().resize( packet.size );`
`99`	`99`	`if( packet.size != 0 )`
`100`	`100`	`memcpy( _streamCache.back().getPtr(), packet.data, packet.size );`
`@@ -148,7 +148,7 @@ double AvInputStream::getDuration() const`
`148`	`148`
`149`	`149`	`void AvInputStream::clearBuffering()`
`150`	`150`	`{`
`151`		`- _streamCache.clear();`
	`151`	`+ _streamCache = std::queue<CodedData>();`
`152`	`152`	`}`
`153`	`153`
`154`	`154`	`AVStream* AvInputStream::getAVStream() const`