Fix encoding of last frames #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 21, 2016 14:24
The AVPacket data attribut should be set to NULL: the encoder will allocate it.
* Only the returned value of the avcodec function is needed. * Indeed, the encoded process could be a success, without any data encoded (end of process).
Add private method encode.
* Add a comment. * Add const keyword.
Add private method encode.
Override in avcodec encoded method.
| { | ||
| throw std::runtime_error("Encode audio frame error: avcodec encode audio frame - " + | ||
| getDescriptionFromErrorCode(ret)); | ||
| } | ||
| return ret == 0 && gotPacket == 1; |
There was a problem hiding this comment.
The condition ret == 0 is not necessary here, because if it's false, you throw a runtime error (just before) !
added 2 commits
April 22, 2016 14:51
Unecessary to check returned value of avcodec encode method twice.
| #else | ||
| const int ret = avcodec_encode_audio(&avCodecContext, encodedData.data, encodedData.size, decodedData); | ||
| if(ret < 0) | ||
| { | ||
| throw std::runtime_error("Encode audio frame error: avcodec encode audio frame - " + | ||
| getDescriptionFromErrorCode(ret)); | ||
| } | ||
| return ret == 0; | ||
| return true; |
There was a problem hiding this comment.
hm.. Shouldn't ret be more than 0 ? And wouldn't it be a bad value ?
There was a problem hiding this comment.
Yes: https://ffmpeg.org/doxygen/2.7/group__lavc__encoding.html#gaf12a9da0d33f50ff406e03572fab4763
"""
Returns:
On error a negative value is returned, on success zero or the number of bytes used to encode the data read from the input buffer.
"""
valnoel
added a commit
to valnoel/avTranscoder
that referenced
this pull request
Jul 22, 2016
…ation Fix output stream duration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this tuttleofx issue: tuttleofx/TuttleOFX#544
Will up to v0.9.4 after this PR.