Skip to content

Audio processing #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cchampet
Copy link
Member

@cchampet cchampet commented Jun 2, 2014

InputStreamAudio: fix bug when decode audio stream.
Also add getters in AudioDesc.

Clement Champetier added 2 commits June 2, 2014 11:55
* InputStreamAudio: update constructor to indicate number of channels of
the CodecContext.
* AudioDesc: add getters for channels, sample rate and sample format.
* SetAudioParameters: use copy instead of reference for AVSampleFormat
(enum).
@@ -27,7 +27,7 @@ class AvExport AudioDesc
void setAudioCodec( const std::string& codecName );
void setAudioCodec( const AVCodecID codecId );

void setAudioParameters( const size_t sampleRate, const size_t channels, const AVSampleFormat& sampleFormat );
void setAudioParameters( const size_t sampleRate, const size_t channels, const AVSampleFormat sampleFormat );
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourquoi retirer la reférence si l'objet est const ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

car ce n'est pas un objet, mais une valeur d'enum ...

Le 2 juin 2014 12:06, Fabien Castan notifications@github.com a écrit :

In src/AvTranscoder/DatasStructures/AudioDesc.hpp:

@@ -27,7 +27,7 @@ class AvExport AudioDesc
void setAudioCodec( const std::string& codecName );
void setAudioCodec( const AVCodecID codecId );

  • void setAudioParameters( const size_t sampleRate, const size_t channels, const AVSampleFormat& sampleFormat );
  • void setAudioParameters( const size_t sampleRate, const size_t channels, const AVSampleFormat sampleFormat );

Pourquoi retirer la reférence si l'objet est const ?


Reply to this email directly or view it on GitHub
https://github.com/MarcAntoine-Arnaud/avTranscoder/pull/3/files#r13277664
.

[image: Mikros Image - Pub Evian Spider-man the amazing babyme 2]
http://www.mikrosimage.eu/realisations/pub-l-evian-spider-man-the-amazing-babyme-2/
Marc-Antoine ARNAUD
R&D Software Developer -
Image Processing & Media Technology Expert

+33 1 55 63 11 00
mrn@mikrosimage.eu

Mikros Image /
Digital Post-Production for Video and Film

www.mikrosimage.eu

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

MarcAntoine-Arnaud added a commit that referenced this pull request Jun 2, 2014
@MarcAntoine-Arnaud MarcAntoine-Arnaud merged commit f703b30 into avTranscoder:master Jun 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants