Skip to content

Commit 84313a8

Browse files
committed
Misc. little fixes for tests that ryan added
--HG-- extra : convert_revision : svn%3Aacbfec75-9323-0410-a652-858a13e371e0/trunk%401055
1 parent 80a6d3d commit 84313a8

File tree

4 files changed

+18
-9
lines changed

4 files changed

+18
-9
lines changed

src/html5lib/filters/formfiller.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ def __iter__(self):
6666

6767
elif name == "textarea":
6868
field_type = "textarea"
69-
field_name = dict(reversed(token["data"]))["name"]
69+
field_name = dict((token["data"])[::-1])["name"]
7070

7171
elif name == "select":
7272
field_type = "select"

src/html5lib/html5parser.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -809,7 +809,7 @@ def startTagCloseP(self, name, attributes):
809809

810810
def startTagForm(self, name, attributes):
811811
if self.tree.formPointer:
812-
self.parser.parseError("Unexpected start tag (form). Ignored.")
812+
self.parser.parseError(u"unexpected-start-tag", {"name": "form"})
813813
else:
814814
if self.tree.elementInScope("p"):
815815
self.endTagP("p")
@@ -1017,7 +1017,8 @@ def endTagBody(self, name):
10171017
# XXX Need to take open <p> tags into account here. We shouldn't imply
10181018
# </p> but we should not throw a parse error either. Specification is
10191019
# likely to be updated.
1020-
if self.tree.openElements[1].name != "body":
1020+
if (len(self.tree.openElements) == 1 or
1021+
self.tree.openElements[1].name != "body"):
10211022
# innerHTML case
10221023
self.parser.parseError()
10231024
return
@@ -1410,7 +1411,7 @@ def endTagCaption(self, name):
14101411
if self.tree.openElements[-1].name != "caption":
14111412
self.parser.parseError("expected-one-end-tag-but-got-another",
14121413
{"gotName": "caption",
1413-
"expectedNmae": self.tree.openElements[-1].name})
1414+
"expectedName": self.tree.openElements[-1].name})
14141415
while self.tree.openElements[-1].name != "caption":
14151416
self.tree.openElements.pop()
14161417
self.tree.openElements.pop()

tests/test_parser.py

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
import os
22
import sys
3+
import traceback
4+
35
import StringIO
46
import unittest
57
from support import html5lib_test_files, TestData, convert, convertExpected
@@ -63,10 +65,16 @@ def runParserTest(self, innerHTML, input, expected, errors, treeClass):
6365
#XXX - move this out into the setup function
6466
#concatenate all consecutive character tokens into a single token
6567
p = html5parser.HTMLParser(tree = treeClass)
66-
if innerHTML:
67-
document = p.parseFragment(StringIO.StringIO(input), innerHTML)
68-
else:
69-
document = p.parse(StringIO.StringIO(input))
68+
69+
try:
70+
if innerHTML:
71+
document = p.parseFragment(StringIO.StringIO(input), innerHTML)
72+
else:
73+
document = p.parse(StringIO.StringIO(input))
74+
except:
75+
errorMsg = "\n".join(["\n\nInput:", input, "\nExpected:", expected,
76+
"\nTraceback:", traceback.format_exc()])
77+
self.assertTrue(False, errorMsg)
7078

7179
output = convertTreeDump(p.tree.testSerializer(document))
7280
output = attrlist.sub(sortattrs, output)

utils/package.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ def __init__(self, inDir, outDir, version="0", status=4, installDir="~"):
2828
self.outFiles = []
2929

3030
def runall(self):
31-
self.getFileList()
3231
self.copyTestData()
32+
self.getFileList()
3333
self.copy()
3434
self.makeSetupFile()
3535
self.preprocess()

0 commit comments

Comments
 (0)