natives/testing: Update frameSkip signature and implementation.

dmitshur · dmitshur · commit 9f7f458dd67d · 2018-08-21T00:07:06.000-04:00
The scope of frameSkip helper has changed in Go 1.11.
Update the function signature and implementation to match.

This change helps GopherJS with running tests.
diff --git a/compiler/natives/src/testing/testing.go b/compiler/natives/src/testing/testing.go
@@ -2,6 +2,8 @@
 
 package testing
 
+import "runtime"
+
 // The upstream callerName and frameSkip rely on runtime.Callers,
 // and panic if there are zero callers found. However, runtime.Callers
 // is not implemented for GopherJS at this time, so we can't use
@@ -11,8 +13,14 @@ func callerName(skip int) string {
 	// TODO: Implement if possible.
 	return "<unknown>"
 }
-func (*common) frameSkip(skip int) int {
-	// Upstream frameSkip requires a functional runtime.Callers.
-	// TODO: Implement if possible.
-	return skip
+
+func (*common) frameSkip(skip int) runtime.Frame {
+	_, file, line, ok := runtime.Caller(skip)
+	if !ok {
+		return runtime.Frame{}
+	}
+	return runtime.Frame{
+		File: file,
+		Line: line,
+	}
 }
