Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aws-cloudformation/cloudformation-cli-python-plugin
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: aws-cloudformation/cloudformation-cli-python-plugin
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: mypy
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 13 commits
  • 3 files changed
  • 2 contributors

Commits on Mar 24, 2021

  1. testing Python 3.9 

    fixes #139
python/mypy#8614
https://github.com/python/mypy/releases
https://github.com/pre-commit/mirrors-mypy/releases
    @PatMyron
    PatMyron committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    3fc09d6 View commit details
    Browse the repository at this point in the history

  2. removing unused ignore type comment 

    src/cloudformation_cli_python_lib/recast.py:130: error: unused 'type: ignore' comment
https://github.com/aws-cloudformation/cloudformation-cli-python-plugin/pull/145/checks?check_run_id=1513282646
    @PatMyron
    PatMyron committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    a488eea View commit details
    Browse the repository at this point in the history

  3. Revert "removing unused ignore type comment" 

    This reverts commit d3772be.
    @PatMyron
    PatMyron committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    5c80931 View commit details
    Browse the repository at this point in the history

  4. ignoring unused ignore type comment 

    https://mypy.readthedocs.io/en/stable/common_issues.html#silencing-linters
    @PatMyron
    PatMyron committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    5f5d7b1 View commit details
    Browse the repository at this point in the history

  5. removing python-check-blanket-noqa

    @PatMyron
    PatMyron committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    ffddae2 View commit details
    Browse the repository at this point in the history

  6. removing noqa

    @PatMyron
    PatMyron committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    71378db View commit details
    Browse the repository at this point in the history

  7. noqa without type ignore

    @PatMyron
    PatMyron committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    8d0c63f View commit details
    Browse the repository at this point in the history

  8. Revert "noqa without type ignore" 

    This reverts commit bd8bdea.
    @PatMyron
    PatMyron committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    7e1337f View commit details
    Browse the repository at this point in the history

  9. silence imports 

    https://mypy.readthedocs.io/en/stable/running_mypy.html#following-imports
    @PatMyron
    PatMyron committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    8a071df View commit details
    Browse the repository at this point in the history

  10. Revert "silence imports" 

    This reverts commit a605069.
    @PatMyron
    PatMyron committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    595d78f View commit details
    Browse the repository at this point in the history

  11. only ignoring type comment for Python version 3.6 

    https://mypy.readthedocs.io/en/stable/common_issues.html#python-version-and-system-platform-checks
    @PatMyron
    PatMyron committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    d3912b0 View commit details
    Browse the repository at this point in the history

  12. disabling --warn-unused-ignores 

    https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-warn-unused-ignores
    @PatMyron
    PatMyron committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    e60fc6f View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. ignoring new pylint check

    @PatMyron
    PatMyron authored Apr 7, 2021
    Configuration menu
    Copy the full SHA
    7142f6d View commit details
    Browse the repository at this point in the history
Loading