BUG29324966: Add missing username connection argument for driver compatibility

nmariz · nmariz · commit 502fd1ea5ab5 · 2019-02-22T16:28:52.000Z
This patch adds the missing username connection argument as an alias of the
user in the classic connector.

Test was added for regression.
diff --git a/lib/mysql/connector/abstracts.py b/lib/mysql/connector/abstracts.py
@@ -276,6 +276,7 @@ def config(self, **kwargs):
         compat_map = [
             # (<other driver argument>,<translates to>)
             ('db', 'database'),
+            ('username', 'user'),
             ('passwd', 'password'),
             ('connect_timeout', 'connection_timeout'),
         ]
diff --git a/tests/test_bugs.py b/tests/test_bugs.py
@@ -5626,3 +5626,30 @@ def test_retrieve_from_LONGBLOB(self):
 
         cur.close()
         cnx.close()
+
+
+class BugOra29324966(tests.MySQLConnectorTests):
+    """BUG#29324966: ADD MISSING USERNAME CONNECTION ARGUMENT FOR DRIVER
+    COMPATIBILITY.
+    """
+    def setUp(self):
+        pass
+
+    def tearDown(self):
+        pass
+
+    @foreach_cnx()
+    def test_connection_args_compatibility(self):
+        config = self.config.copy()
+        config["username"] = config["user"]
+        config["passwd"] = config["password"]
+        config["db"] = config["database"]
+        config["connect_timeout"] = config["connection_timeout"]
+
+        config.pop("user")
+        config.pop("password")
+        config.pop("database")
+        config.pop("connection_timeout")
+
+        cnx = self.cnx.__class__(**config)
+        cnx.close()

Original file line number	Diff line number	Diff line change
`@@ -276,6 +276,7 @@ def config(self, **kwargs):`
`276`	`276`	`compat_map = [`
`277`	`277`	`# (<other driver argument>,<translates to>)`
`278`	`278`	`('db', 'database'),`
	`279`	`+ ('username', 'user'),`
`279`	`280`	`('passwd', 'password'),`
`280`	`281`	`('connect_timeout', 'connection_timeout'),`
`281`	`282`	`]`