Support 'trust' authentication method #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the PostgreSQL server's response to the initial login packet, it includes a field indicating what kind of authentication the server would like the client to use. We were not checking that field. If it is 0, that means no authentication is needed and the client can just go ahead. As a bonus, since we are now checking the value of that field, we can provide a more specific error message if the server wants to use an authentication type which this library does not currently support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the PostgreSQL server's response to the initial login packet, it includes a field indicating what kind of authentication the server would like the client to use. We were not checking that field. If it is 0, that means no authentication is needed and the client can just go ahead.
As a bonus, since we are now checking the value of that field, we can provide a more specific error message if the server wants to use an authentication type which this library does not currently support.
This code is working on my own installation of Nginx + Postgres 14.