Merge pull request docker-java#1100 from dtretyakov/filters

KostyaSha · web-flow · commit 9116e14a3b4c · 2018-09-27T02:34:28.000+03:00
Add withFilter methods in ListNetworksCmd &amp; ListVolumesCmd
diff --git a/src/main/java/com/github/dockerjava/api/command/ListNetworksCmd.java b/src/main/java/com/github/dockerjava/api/command/ListNetworksCmd.java
@@ -5,6 +5,7 @@
 
 import javax.annotation.CheckForNull;
 
+import java.util.Collection;
 import java.util.List;
 import java.util.Map;
 
@@ -22,6 +23,13 @@ public interface ListNetworksCmd extends SyncDockerCmd<List<Network>> {
 
     ListNetworksCmd withIdFilter(String... networkId);
 
+    /**
+     * @param filterName
+     * @param filterValues
+     *            - Show only networks where the filter matches the given values
+     */
+    ListNetworksCmd withFilter(String filterName, Collection<String> filterValues);
+
     interface Exec extends DockerCmdSyncExec<ListNetworksCmd, List<Network>> {
     }
 }
diff --git a/src/main/java/com/github/dockerjava/api/command/ListVolumesCmd.java b/src/main/java/com/github/dockerjava/api/command/ListVolumesCmd.java
@@ -1,5 +1,6 @@
 package com.github.dockerjava.api.command;
 
+import java.util.Collection;
 import java.util.List;
 import java.util.Map;
 
@@ -21,6 +22,13 @@ public interface ListVolumesCmd extends SyncDockerCmd<ListVolumesResponse> {
      */
     ListVolumesCmd withDanglingFilter(Boolean dangling);
 
+    /**
+     * @param filterName
+     * @param filterValues
+     *            - Show only volumes where the filter matches the given values
+     */
+    ListVolumesCmd withFilter(String filterName, Collection<String> filterValues);
+
     interface Exec extends DockerCmdSyncExec<ListVolumesCmd, ListVolumesResponse> {
     }
 }
diff --git a/src/main/java/com/github/dockerjava/core/command/ListNetworksCmdImpl.java b/src/main/java/com/github/dockerjava/core/command/ListNetworksCmdImpl.java
@@ -4,9 +4,12 @@
 import com.github.dockerjava.api.model.Network;
 import com.github.dockerjava.core.util.FiltersBuilder;
 
+import java.util.Collection;
 import java.util.List;
 import java.util.Map;
 
+import static com.google.common.base.Preconditions.checkNotNull;
+
 public class ListNetworksCmdImpl extends AbstrDockerCmd<ListNetworksCmd, List<Network>> implements ListNetworksCmd {
 
     private FiltersBuilder filtersBuilder = new FiltersBuilder();
@@ -31,4 +34,11 @@ public ListNetworksCmd withNameFilter(String... networkName) {
         this.filtersBuilder.withFilter("name", networkName);
         return this;
     }
+
+    @Override
+    public ListNetworksCmd withFilter(String filterName, Collection<String> filterValues) {
+        checkNotNull(filterValues, filterName + " was not specified");
+        this.filtersBuilder.withFilter(filterName, filterValues);
+        return this;
+    }
 }
diff --git a/src/main/java/com/github/dockerjava/core/command/ListVolumesCmdImpl.java b/src/main/java/com/github/dockerjava/core/command/ListVolumesCmdImpl.java
@@ -2,6 +2,7 @@
 
 import static com.google.common.base.Preconditions.checkNotNull;
 
+import java.util.Collection;
 import java.util.List;
 import java.util.Map;
 
@@ -33,4 +34,11 @@ public ListVolumesCmd withDanglingFilter(Boolean dangling) {
         this.filters.withFilter("dangling", dangling.toString());
         return this;
     }
+
+    @Override
+    public ListVolumesCmd withFilter(String filterName, Collection<String> filterValues) {
+        checkNotNull(filterValues, filterName + " was not specified");
+        this.filters.withFilter(filterName, filterValues);
+        return this;
+    }
 }
