Skip to content

Commit e774a60

Browse files
authored
Merge pull request docker-java#853 from fengxx/feature/default_request_config
set default socket timeout for RequestConfig
2 parents 3180671 + abf4743 commit e774a60

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/main/java/com/github/dockerjava/jaxrs/JerseyDockerCmdExecFactory.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,15 +134,17 @@ public void init(DockerClientConfig dockerClientConfig) {
134134
clientConfig.register(ResponseStatusExceptionFilter.class);
135135
clientConfig.register(JsonClientFilter.class);
136136
clientConfig.register(JacksonJsonProvider.class);
137-
137+
RequestConfig.Builder requestConfigBuilder = RequestConfig.custom();
138138
// logging may disabled via log level
139139
clientConfig.register(new SelectiveLoggingFilter(LOGGER, true));
140140

141141
if (readTimeout != null) {
142+
requestConfigBuilder.setSocketTimeout(readTimeout);
142143
clientConfig.property(ClientProperties.READ_TIMEOUT, readTimeout);
143144
}
144145

145146
if (connectTimeout != null) {
147+
requestConfigBuilder.setConnectTimeout(connectTimeout);
146148
clientConfig.property(ClientProperties.CONNECT_TIMEOUT, connectTimeout);
147149
}
148150

@@ -221,9 +223,9 @@ public void shutdown() {
221223

222224
// Configure connection pool timeout
223225
if (connectionRequestTimeout != null) {
224-
clientConfig.property(ApacheClientProperties.REQUEST_CONFIG, RequestConfig.custom()
225-
.setConnectionRequestTimeout(connectionRequestTimeout).build());
226+
requestConfigBuilder.setConnectionRequestTimeout(connectionRequestTimeout);
226227
}
228+
clientConfig.property(ApacheClientProperties.REQUEST_CONFIG, requestConfigBuilder.build());
227229
ClientBuilder clientBuilder = ClientBuilder.newBuilder().withConfig(clientConfig);
228230

229231
if (sslContext != null) {

0 commit comments

Comments
 (0)