Skip to content

Commit 6c16364

Browse files
gibfahnphillipj
gibfahn
authored and
phillipj
committed
labels: change "V8" labelling to "V8 Engine" (nodejs#138)
Refs: nodejs/CTC#103
1 parent 932b06b commit 6c16364

File tree

5 files changed

+21
-20
lines changed

5 files changed

+21
-20
lines changed

‎lib/node-labels.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const subSystemLabelsMap = new Map([
2424
[/^src\/node_url/, ['c++', 'url-whatwg',
2525
'dont-land-on-v4.x', 'dont-land-on-v6.x']],
2626
[/^src\/node_util/, ['c++', 'util']],
27-
[/^src\/(?:node_v8|v8abbr)/, ['c++', 'V8']],
27+
[/^src\/(?:node_v8|v8abbr)/, ['c++', 'V8 Engine']],
2828
[/^src\/node_contextify/, ['c++', 'vm']],
2929
[/^src\/.*win32.*/, ['c++', 'windows']],
3030
[/^src\/node_zlib/, ['c++', 'zlib']],
@@ -61,7 +61,7 @@ const subSystemLabelsMap = new Map([
6161
[/^tools\/(?:certdata|mkssldef|mk-ca-bundle)/, ['tools', 'openssl', 'tls']],
6262
[/^tools\/msvs\//, ['tools', 'windows', 'install']],
6363
[/^tools\/[^/]+\.bat$/, ['tools', 'windows']],
64-
[/^tools\/make-v8/, ['tools', 'V8']],
64+
[/^tools\/make-v8/, ['tools', 'V8 Engine']],
6565
// all other tool changes should be marked as such
6666
[/^tools\//, 'tools'],
6767
[/^\.eslint|\.remark|\.editorconfig/, 'tools'],
@@ -70,6 +70,7 @@ const subSystemLabelsMap = new Map([
7070
// libuv needs an explicit mapping, as the ordinary /deps/ mapping below would
7171
// end up as libuv changes labeled with "uv" (which is a non-existing label)
7272
[/^deps\/uv\//, 'libuv'],
73+
[/^deps\/v8\//, 'V8 Engine'],
7374
[/^deps\/([^/]+)/, '$1'],
7475

7576
/* JS subsystems */
@@ -121,7 +122,7 @@ const exclusiveLabelsMap = new Map([
121122

122123
// more specific benchmarks
123124
[/^benchmark\/buffers\//, ['benchmark', 'buffer']],
124-
[/^benchmark\/(?:arrays|es)\//, ['benchmark', 'V8']],
125+
[/^benchmark\/(?:arrays|es)\//, ['benchmark', 'V8 Engine']],
125126
[/^benchmark\/_http/, ['benchmark', 'http']],
126127
[/^benchmark\/(?:misc|fixtures)\//, 'benchmark'],
127128
[/^benchmark\/streams\//, ['benchmark', 'stream']],

‎test/_fixtures/repo-labels-page-2.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
},
3030
{
3131
"id": 176191361,
32-
"url": "https://api.github.com/repos/nodejs/node/labels/V8",
33-
"name": "V8",
32+
"url": "https://api.github.com/repos/nodejs/node/labels/V8 Engine",
33+
"name": "V8 Engine",
3434
"color": "0052cc",
3535
"default": false
3636
},

‎test/_fixtures/repo-labels.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,8 +150,8 @@
150150
"color": "5319e7"
151151
},
152152
{
153-
"url": "https://api.github.com/repos/nodejs/node/labels/V8",
154-
"name": "V8",
153+
"url": "https://api.github.com/repos/nodejs/node/labels/V8 Engine",
154+
"name": "V8 Engine",
155155
"color": "0052cc"
156156
}
157157
]

‎test/integration/node-labels-webhook.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,9 +121,9 @@ tap.test('Does not create labels which does not already exist', (t) => {
121121
})
122122

123123
// reported bug: https://github.com/nodejs/github-bot/issues/92
124-
tap.test('Adds V8 label when PR has deps/v8 file changes', (t) => {
124+
tap.test('Adds V8 Engine label when PR has deps/v8 file changes', (t) => {
125125
const clock = lolex.install()
126-
const expectedLabels = ['V8']
126+
const expectedLabels = ['V8 Engine']
127127
const webhookPayload = readFixture('pull-request-opened-v8.json')
128128

129129
const filesScope = nock('https://api.github.com')

‎test/unit/node-labels.test.js

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ const srcCases = [
113113
[ ['url-whatwg', 'dont-land-on-v4.x', 'dont-land-on-v6.x'],
114114
['node_url.cc', 'node_url.h'] ],
115115
[ 'util', ['node_util.cc'] ],
116-
[ 'V8', ['node_v8.cc', 'v8abbr.h'] ],
116+
[ 'V8 Engine', ['node_v8.cc', 'v8abbr.h'] ],
117117
[ 'vm', ['node_contextify.cc'] ],
118118
[ 'windows',
119119
['backtrace_win32.cc',
@@ -173,12 +173,12 @@ tap.test('label: "inspector" when ./src/inspector_* has been changed', (t) => {
173173
t.end()
174174
})
175175

176-
tap.test('label: "v8" when ./deps/v8/ files has been changed', (t) => {
176+
tap.test('label: "V8 Engine" when ./deps/v8/ files has been changed', (t) => {
177177
const labels = nodeLabels.resolveLabels([
178178
'deps/v8/src/arguments.cc'
179179
])
180180

181-
t.same(labels, ['v8'])
181+
t.same(labels, ['V8 Engine'])
182182

183183
t.end()
184184
})
@@ -193,13 +193,13 @@ tap.test('label: "libuv" when ./deps/uv/ files has been changed', (t) => {
193193
t.end()
194194
})
195195

196-
tap.test('label: "v8", "openssl" when ./deps/v8/ and ./deps/openssl/ files has been changed', (t) => {
196+
tap.test('label: "V8 Engine", "openssl" when ./deps/v8/ and ./deps/openssl/ files has been changed', (t) => {
197197
const labels = nodeLabels.resolveLabels([
198198
'deps/v8/src/arguments.cc',
199199
'deps/openssl/openssl/ssl/ssl_rsa.c'
200200
])
201201

202-
t.same(labels, ['v8', 'openssl'])
202+
t.same(labels, ['V8 Engine', 'openssl'])
203203

204204
t.end()
205205
})
@@ -245,7 +245,7 @@ tap.test('label: not "lib / src" when only deps have been changed', (t) => {
245245
'deps/v8/test/cctest/interpreter/bytecode_expectations/BasicLoops.golden'
246246
])
247247

248-
t.same(labels, ['v8'])
248+
t.same(labels, ['V8 Engine'])
249249

250250
t.end()
251251
})
@@ -347,7 +347,7 @@ tap.test('label: version labels (new)', (t) => {
347347
'deps/v8/test/mjsunit/regress/regress-5033.js'
348348
], 'v6.x')
349349

350-
t.same(labels, ['v8', 'v6.x'])
350+
t.same(labels, ['V8 Engine', 'v6.x'])
351351

352352
t.end()
353353
})
@@ -359,7 +359,7 @@ tap.test('label: version labels (new, staging)', (t) => {
359359
'deps/v8/test/mjsunit/regress/regress-5033.js'
360360
], 'v6.x-staging')
361361

362-
t.same(labels, ['v8', 'v6.x'])
362+
t.same(labels, ['V8 Engine', 'v6.x'])
363363

364364
t.end()
365365
})
@@ -371,7 +371,7 @@ tap.test('label: no version labels (master)', (t) => {
371371
'deps/v8/test/mjsunit/regress/regress-5033.js'
372372
], 'master')
373373

374-
t.same(labels, ['v8'])
374+
t.same(labels, ['V8 Engine'])
375375

376376
t.end()
377377
})
@@ -430,7 +430,7 @@ const specificBenchmarks = [
430430
[ 'tls', ['tls/throughput.js'] ],
431431
[ 'url', ['url/url-resolve.js'] ],
432432
[ 'util', ['util/format.js'] ],
433-
[ 'V8', ['arrays/var-int.js', 'es/defaultparams-bench.js'] ],
433+
[ 'V8 Engine', ['arrays/var-int.js', 'es/defaultparams-bench.js'] ],
434434
[ 'vm', ['vm/run-in-context.js'] ]
435435
]
436436
for (const info of specificBenchmarks) {
@@ -510,7 +510,7 @@ const specificTools = [
510510
[ ['openssl', 'tls'], ['certdata.txt', 'mkssldef.py', 'mk-ca-bundle.pl'] ],
511511
[ ['windows'], ['sign.bat'] ],
512512
[ ['windows', 'install'], ['msvs/msi/product.wxs'] ],
513-
[ ['V8'], ['make-v8.sh'] ]
513+
[ ['V8 Engine'], ['make-v8.sh'] ]
514514
]
515515
for (const info of specificTools) {
516516
let labels = info[0]

0 commit comments

Comments
 (0)