Skip to content

Commit ccd5ce0

Browse files
committed
Finish addressing the comments
1 parent 440eb07 commit ccd5ce0

File tree

3 files changed

+13
-12
lines changed

3 files changed

+13
-12
lines changed

DEVELOPING.md

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,16 @@
11
# For Developers
22

3+
## Updating internal dependencies
4+
5+
1. Modify the `./python/pip_install/tools/requirements.txt` file and run:
6+
```
7+
bazel run //tools/private/update_deps:update_pip_deps
8+
```
9+
1. Bump the coverage dependencies using the script using:
10+
```
11+
bazel run //tools/private/update_deps:update_coverage_deps <VERSION>
12+
```
13+
314
## Releasing
415

516
Start from a clean checkout at `main`.
@@ -8,16 +19,6 @@ Before running through the release it's good to run the build and the tests loca
819
also test-drive the commit in an existing Bazel workspace to sanity check functionality.
920

1021
#### Steps
11-
1. (Optional) modify the `./python/pip_install/tools/requirements.txt` file and run `./tools/update_pip_deps.sh` script:
12-
1. Using system python:
13-
```bash
14-
./tools/update_pip_deps.py
15-
```
16-
1. Using bazel toolchain:
17-
```bash
18-
bazel run --enable_bzlmod @python_3_10_9//:python3 -- ./tools/update_pip_deps.py
19-
```
20-
1. (Optional) bump the coverage dependencies using the script `./tools/update_coverage_deps.py <VERSION>`.
2122
1. [Determine the next semantic version number](#determining-semantic-version)
2223
1. Create a tag and push, e.g. `git tag 0.5.0 upstream/main && git push upstream --tags`
2324
NOTE: Pushing the tag will trigger release automation.

tools/private/update_deps/update_file.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ def replace_snippet(
4545
start_marker: str,
4646
end_marker: str,
4747
) -> str:
48-
"""update a file on disk to replace text in a file between two markers.
48+
"""Update a file on disk to replace text in a file between two markers.
4949
5050
Args:
5151
path: pathlib.Path, the path to the file to be modified.

tools/private/update_deps/update_file_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
import unittest
1616

17-
from tools.private.update_file import replace_snippet, unified_diff
17+
from tools.private.update_deps.update_file import replace_snippet, unified_diff
1818

1919

2020
class TestReplaceSnippet(unittest.TestCase):

0 commit comments

Comments
 (0)